From: sashiko-bot@kernel.org
To: "Tariq Toukan" <tariqt@nvidia.com>
Cc: linux-rdma@vger.kernel.org
Subject: Re: [PATCH net] net/mlx5: DPLL, fix fractional frequency offset scaling
Date: Thu, 15 Oct 2026 07:46:30 +0000 [thread overview]
Message-ID: <sashiko-outbox-172430@kernel.org> (raw)
In-Reply-To: <20261015074035.1092340-1-tariqt@nvidia.com>
> From: Carolina Jubran <cjubran@nvidia.com>
>
> The frequency_diff is reported by firmware in parts-per-trillion, which
> is exactly what the DPLL core now expects from the ffo_get callback.
>
> Commit bc443c253fcd ("dpll: expose fractional frequency offset in ppt")
> switched the callback contract to ppt but assumed frequency_diff was in
> ppm and scaled it by 1000000 to "convert" it. Since the value was
> already ppt, this makes both exported attributes wrong.
>
> Report frequency_diff as is and let the core divide it down for the
> legacy ppm attribute.
>
> Fixes: f035dca34ede ("net/mlx5: DPLL, Implement fractional frequency offset get pin op")
> Signed-off-by: Carolina Jubran <cjubran@nvidia.com>
> Reviewed-by: Jiri Pirko <jiri@nvidia.com>
> Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261015074035.1092340-1-tariqt@nvidia.com?part=1
next prev parent reply other threads:[~2026-10-15 7:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-15 7:40 [PATCH net] net/mlx5: DPLL, fix fractional frequency offset scaling Tariq Toukan
2026-10-15 7:43 ` netdev-bot+sinfo
2026-10-15 9:28 ` Carolina Jubran
2026-10-15 7:46 ` sashiko-bot [this message]
2026-10-15 10:49 ` Daniel Machon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-172430@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.