Re: [PATCH v2 4/6] arm64: dts: qcom: glymur-crd: Add PM8010 camera PMIC

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dts: qcom: undocumented compatible qcom,pm8010-i2c lacks driver support
--

commit b406354a7d9e1a182f11a64fe71ecec95efdafff
Author: Jishnu Prakash <jishnu.prakash@oss.qualcomm.com>

arm64: dts: qcom: glymur-crd: Add PM8010 camera PMIC

This commit adds a PM8010 PMIC node with seven LDO regulators and pinctrl
configuration for the reset pin. The LDOs provide power to the camera sensors
and associated hardware.

> diff --git a/arch/arm64/boot/dts/qcom/glymur-crd.dtsi b/arch/arm64/boot/dts/qcom/glymur-crd.dtsi
> --- a/arch/arm64/boot/dts/qcom/glymur-crd.dtsi
> +++ b/arch/arm64/boot/dts/qcom/glymur-crd.dtsi
> @@ -671,6 +671,72 @@ ptn3222_1: redriver@47 {
>  
>  		#phy-cells = <0>;
>  	};
> +
> +	pm8010: pmic@8 {
> +		compatible = "qcom,pm8010-i2c";

[Severity: Medium]
Is there a missing driver or dt-binding for this compatible string? 

A search across the tree indicates that there is no documentation or driver 
support for qcom,pm8010-i2c. Since the PM8010 is traditionally controlled via 
SPMI/RPMh, and no I2C driver variant appears to have been introduced, will this 
cause a regression where the PMIC device silently fails to probe?

Without the PMIC probing, its regulators will not be registered, which may cause 
downstream devices (like the camera sensors) to indefinitely defer probing. This 
could also result in dtbs_check failures due to the missing binding.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261015-glymur_camss_dts-v2-0-e7b1f403146f@oss.qualcomm.com?part=4