Re: [PATCH 4/7] rust: io: project primitive accessors directly

[sashiko-bot@kernel.org]

> The primitive accessors, `read8` to `write64` and their `try_` variants,
> pass their offset as an `IoLoc` to the generic `read`, `write`,
> `try_read` and `try_write`, which project the view to that location and
> then call `read_val` or `write_val`. Commit 147b41ba23d6 ("rust: io: use
> generic read/write accessors for primitive accesses") made them do so to
> reduce the number of unsafe blocks.
> 
> Since commit e0454ec1220c ("rust: io: use view types instead of
> addresses for `Io`"), projecting to an offset is safe. Thus, have the
> primitive accessors project with `io_view` and `io_view_assert` and call
> `read_val` or `write_val` themselves. The bounds checks are the same.
> 
> This prepares for access modes on I/O locations, added in a following
> patch, which make the bounds of the generic methods depend on the mode
> of the location. The primitive accessors keep their current bounds.
> 
> No functional change intended.
> 
> Signed-off-by: Daniel Almeida <daniel.almeida@collabora.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261015-io-access-modes-v1-0-93611b84b5e3@collabora.com?part=4