Re: [PATCH v2 2/2] arm64: dts: qcom: oneplus-kebab: new device

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: qcom: tlmm node name and input-enable schema violation
--

commit d33a306deafbc7e2920b017aacb1c37a8d11464b
Author: Frieder Hannenheim <git@fhannenheim.net>

arm64: dts: qcom: oneplus-kebab: new device

This commit adds the initial device-tree for the OnePlus 8T.

[1] https://github.com/LineageOS/android_kernel_oneplus_sm8250/blob/lineage-23.2/arch/arm64/boot/dts/vendor/oplus/kona-kebab-overlay.dts

> diff --git a/arch/arm64/boot/dts/qcom/sm8250-oneplus-kebab.dts b/arch/arm64/boot/dts/qcom/sm8250-oneplus-kebab.dts
> new file mode 100644
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/sm8250-oneplus-kebab.dts

[ ... ]

> +&tlmm {
> +	pm8008_default: pm8008-default-state {
> +		pins = "gpio93";
> +		function = "gpio";
> +		bias-pull-up;
> +		output-high;
> +		drive-strength = <2>;
> +	};
> +
> +	pm8008_interrupt: pm8008-interrupt {
> +		pins = "gpio112";
> +		function = "gpio";
> +		bias-disable;
> +		input-enable;
> +	};

[Severity: Low]
Does this pinctrl node name violate the dt-binding schema? The
qcom,sm8250-pinctrl.yaml schema enforces a regex that requires node
names to end with "-state" (or "-pins"). Using "pm8008-interrupt" might
cause a dt_binding_check failure since unevaluatedProperties is false.

Additionally, should "input-enable" be included here? The
qcom,tlmm-common.yaml schema explicitly forbids this property, so its
presence will likely cause schema validation to fail when running
make dtbs_check.

> +};

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261015-kebab_dts-v2-0-e783463bffd3@fhannenheim.net?part=2