Re: [PATCH v5 1/3] dt-bindings: remoteproc: imx_rproc: document memory-region-names to avoid hidden ABI

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: imx-rproc: strict regex rejects valid memory-region-names
--

commit 6408464abda5d8740cc2d4f521608bce19b964e6
Author: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>

dt-bindings: remoteproc: imx_rproc: document memory-region-names to avoid hidden ABI
    
Document the optional memory-region-names property explicitly to identify the 
expected memory regions. This avoids relying on memory node names as a hidden 
DT ABI, which previously allowed incorrect names to silently pass validation.
    
Link: https://lore.kernel.org/imx/a3602ef8-2b77-4cc3-adef-2c4cba08a5d9@nabladev.com/ [1]
Link: https://lore.kernel.org/imx/alexXTYQHUs76J7v@SMW015318/T/#mb9dc709ff3adc24d9db6d30c973f37b580f6f1f9 [2]

> diff --git a/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml
> index c18f71b648890..f87036299a7b6 100644
> --- a/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml
> @@ -62,6 +62,15 @@ properties:
>      minItems: 1
>      maxItems: 32
>  
> +  memory-region-names:
> +    minItems: 1
> +    maxItems: 32
> +    items:
> +      anyOf:
> +        - const: rsc-table
> +        - pattern: "^vdev[0-9]+(buffer|vring[0-9]+)$"
> +        - pattern: "^m(4|7|33)-reserved(-[a-z0-9-]+)+$"

[Severity: Low]
Does this regular expression structurally exclude the valid base names
themselves?

Because of the + quantifier at the end of the pattern, it requires at least
one suffix. If a device tree author attempts to add memory-region-names =
"m7-reserved" to match an existing node label like m7_reserved (e.g., in
imx95-19x19-evk.dts), dtbs_check will throw a validation error.

Should the + be changed to * to allow "m4-reserved", "m7-reserved", and
"m33-reserved" without requiring a suffix?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261015-memory-region-name-v5-0-abc358b39a96@nxp.com?part=1