From: sashiko-bot@kernel.org
To: Frank.Li@oss.nxp.com,
"open list:DMA GENERIC OFFLOAD ENGINE SUBSYSTEM"
<dmaengine@vger.kernel.org>
Cc: imx@lists.linux.dev, vkoul@kernel.org, Frank.Li@kernel.org
Subject: Re: [PATCH v2 1/1] dmaengine: ppc4xx: adma: remove unused async_tx.h include
Date: Thu, 15 Oct 2026 16:03:32 +0000 [thread overview]
Message-ID: <sashiko-outbox-173127@kernel.org> (raw)
In-Reply-To: <20261015155616.3068503-1-Frank.Li@oss.nxp.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dmaengine: missing prototype for ppc440spe_async_tx_find_best_channel()
--
commit 7df6c7a27c8059b2cc2b7731da8108aa6dffb69a
Author: Frank Li <Frank.Li@nxp.com>
dmaengine: ppc4xx: adma: remove unused async_tx.h include
This commit removes the async_tx.h include from adma.c to prepare for
deprecating the async_tx framework. The commit message states the include
is no longer needed and its functions come from dmaengine.h.
> diff --git a/drivers/dma/ppc4xx/adma.c b/drivers/dma/ppc4xx/adma.c
> index bcc54d584e2bf..05041b99581a1 100644
> --- a/drivers/dma/ppc4xx/adma.c
> +++ b/drivers/dma/ppc4xx/adma.c
> @@ -17,7 +17,6 @@
>
> #include <linux/init.h>
> #include <linux/module.h>
> -#include <linux/async_tx.h>
[Severity: Low]
Does removing this include cause a missing prototype regression for
ppc440spe_async_tx_find_best_channel()?
The prototype for this globally exported function is defined in
arch/powerpc/include/asm/async_tx.h, which is included via
linux/async_tx.h:
include/linux/async_tx.h:
#ifdef CONFIG_ARCH_HAS_ASYNC_TX_FIND_CHANNEL
#include <asm/async_tx.h>
#else
Removing linux/async_tx.h leaves the function without a visible prototype
in adma.c, causing a build warning.
> #include <linux/delay.h>
> #include <linux/dma-mapping.h>
> #include <linux/spinlock.h>
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261015155616.3068503-1-Frank.Li@oss.nxp.com?part=1
next prev parent reply other threads:[~2026-10-15 16:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-15 15:56 [PATCH v2 1/1] dmaengine: ppc4xx: adma: remove unused async_tx.h include Frank.Li
2026-10-15 16:03 ` sashiko-bot [this message]
2026-10-15 19:30 ` Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-173127@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=Frank.Li@oss.nxp.com \
--cc=dmaengine@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=sashiko-reviews@lists.linux.dev \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.