Re: [PATCH v4 04/16] media: sony-starvis2: Parameterise the configuration to allow for other models

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] media: sony-starvis2: unconditional common_regs_written = true on error
--

commit 9eba4e98350150880f04e6b7769441de57543230
Author: Dave Stevenson <dave.stevenson@raspberrypi.com>

media: sony-starvis2: Parameterise the configuration to allow for other models

This commit extracts and parameterises sensor configuration parameters,
such as pixel array sizes, default VMAX, and common registers. This enables
the driver to support additional Sony Starvis 2 models using the same core
logic.

> diff --git a/drivers/media/i2c/sony-starvis2.c b/drivers/media/i2c/sony-starvis2.c
> index c4f590c489d99..189caac780667 100644
> --- a/drivers/media/i2c/sony-starvis2.c
> +++ b/drivers/media/i2c/sony-starvis2.c
> @@ -896,8 +927,12 @@ static int starvis2_write_common(struct starvis2 *starvis2)
>  {
>  	int ret = 0;
>  
> -	cci_multi_reg_write(starvis2->cci, common_regs, ARRAY_SIZE(common_regs),
> -			    &ret);
> +	if (!starvis2->variant)
> +		/* Powered on during probe to do detection. Variant unknown. */
> +		return 0;
> +
> +	cci_multi_reg_write(starvis2->cci, starvis2->variant->common_regs,
> +			    starvis2->variant->num_common_regs, &ret);
>  
>  	cci_write(starvis2->cci, STARVIS2_REG_INCK_SEL, starvis2->inck_sel_val,
>  		  &ret);
[ ... ]
>  	cci_write(starvis2->cci, STARVIS2_REG_INTERFACE_SEL,
>  		  STARVIS2_INTERFACE_2L_4L, &ret);
>  
>  	starvis2->common_regs_written = true;

[Severity: Medium]
If a transient I2C error occurs during starvis2_write_common(), the
cci_multi_reg_write() or cci_write() functions will set the error in ret.

Does this unconditionally set starvis2->common_regs_written to true before
returning even when ret is non-zero?

If an error is returned, a subsequent attempt to start streaming might see
starvis2->common_regs_written as true and skip writing the common registers,
leaving the sensor in a partially initialized state.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261015-media-starvis2-v4-0-75fcdb4163f3@raspberrypi.com?part=4