Re: [PATCH bpf-next 2/2] selftests/bpf: Add JIT cBPF-related instruction tests

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] bpf: multi-line comment style violation
--

commit 50137381f50b5ae9fe8e8ed91abe51bac3560048
Author: Daniel Borkmann <daniel@iogearbox.net>

selftests/bpf: Add JIT cBPF-related instruction tests

The classic BPF cases of the removed test_bpf module ran their programs
on a hand-built skb. Run them as socket filters instead via jit_insns_cbpf
test suite. This covers all previous test_bpf cases as well as a few corner
cases beyond that.

> diff --git a/tools/testing/selftests/bpf/prog_tests/jit_insns_cbpf.c b/tools/testing/selftests/bpf/prog_tests/jit_insns_cbpf.c
> new file mode 100644
> index 0000000000000..5471c06605fe3
> --- /dev/null
> +++ b/tools/testing/selftests/bpf/prog_tests/jit_insns_cbpf.c
[ ... ]
> +	{
> +		.descr = "tcpdump complex",
> +		.insns = INSNS(
> +			/* tcpdump -nei eth0 'tcp port 22 and (((ip[2:2] -
> +			 * ((ip[0]&0xf)<<2)) - ((tcp[12]&0xf0)>>2)) != 0) and
> +			 * (len > 115 or len < 30000000000)' -d
> +			 */
> +			BPF_STMT(BPF_LD | BPF_H | BPF_ABS, 12),

[Severity: Low]
This isn't a bug, but could we format this multi-line comment in the cases
array to match the preferred BPF subsystem style? The BPF subsystem expects
the opening /* to be on its own line, with the text starting on the next
line.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261015171917.599025-1-daniel@iogearbox.net?part=2