Re: [PATCH 07/11] ASoC: renesas: msiof: Explain component open return value handling

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] asoc: commit message references msiof but patch modifies fsi
--

commit 1519b8d2e5e1f740b8b8e2dcb2ad6f3443c0c1db
Author: bui duc phuc <phucduc.bui@gmail.com>

ASoC: renesas: msiof: Explain component open return value handling

This commit adds a comment explaining why the open callback must return 0
on success to ensure the component is correctly marked as opened.

> ASoC: renesas: msiof: Explain component open return value handling

[Severity: Low]
This isn't a bug, but the commit subject and message explicitly reference
the msiof driver, while the patch actually modifies fsi_pcm_open() in the
fsi driver.

Should the commit subject and message be updated to accurately reflect the
fsi driver instead of msiof?

> diff --git a/sound/soc/renesas/fsi.c b/sound/soc/renesas/fsi.c
> index 88618e4b052d8..74e2ea002fbb1 100644
> --- a/sound/soc/renesas/fsi.c
> +++ b/sound/soc/renesas/fsi.c
> @@ -1820,6 +1820,11 @@ static int fsi_pcm_open(struct snd_soc_component *component,
>  	if (ret < 0)
>  		return ret;
>  
> +	/*
> +	 * ASoC only marks the component as opened when .open() returns 0.
> +	 * Since snd_pcm_hw_constraint_integer() may return 1, explicitly
> +	 * return 0 to ensure the component is correctly marked as opened.
> +	 */
>  	return 0;
>  }

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261016040946.521195-1-phucduc.bui@gmail.com?part=7