From: sashiko-bot@kernel.org
To: "Sreeshankar K" <sreeshankar0910@gmail.com>
Cc: linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v11 4/5] dt-bindings: cpufreq: qcom-hw: Document SM7250 cpufreq hardware
Date: Fri, 16 Oct 2026 04:32:44 +0000 [thread overview]
Message-ID: <sashiko-outbox-173787@kernel.org> (raw)
In-Reply-To: <20261016042432.824-5-sreeshankar0910@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: cpufreq: qcom-hw: missing SM7250 in schema conditionals
--
commit 7eca354281cb4ab83cc6aed6ad713ee095a5b71a
Author: Sreeshankar K <sreeshankar0910@gmail.com>
dt-bindings: cpufreq: qcom-hw: Document SM7250 cpufreq hardware
Document the cpufreq hardware on the SM7250 SoC.
> diff --git a/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml b/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml
> index 98eb36bff1727..2dc2c265cac06 100644
> --- a/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml
> +++ b/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml
> @@ -29,6 +29,7 @@ properties:
> - qcom,sdm845-cpufreq-hw
> - qcom,sm6115-cpufreq-hw
> - qcom,sm6350-cpufreq-hw
> + - qcom,sm7250-cpufreq-hw
[Severity: Medium]
Should this new compatible string also be propagated to the hardware-specific
conditionals in the allOf block?
If the new compatible string is omitted from the conditional blocks, schema
validation for qcom,sm7250-cpufreq-hw will fall back to the top-level bounds.
Device trees with incorrect register or interrupt configurations will pass
validation.
Since the SM7250 has 3 register domains, should it be added to the constraint
block enforcing exactly 3 items?
Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml:allOf:
- if:
properties:
compatible:
contains:
enum:
- qcom,milos-cpufreq-epss
- qcom,qcs8300-cpufreq-epss
- qcom,sc7280-cpufreq-epss
- qcom,sm8250-cpufreq-epss
- qcom,sm8350-cpufreq-epss
- qcom,sm8450-cpufreq-epss
- qcom,sm8550-cpufreq-epss
then:
properties:
reg:
minItems: 3
maxItems: 3
> - qcom,sm8150-cpufreq-hw
> - const: qcom,cpufreq-hw
>
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261016042432.824-1-sreeshankar0910@gmail.com?part=4
next prev parent reply other threads:[~2026-10-16 4:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-16 4:24 [PATCH v11 0/5] Add initial support for Qualcomm SM7250 SoC Sreeshankar K
2026-10-16 4:24 ` [PATCH v11 1/5] dt-bindings: clock: Add SM7250 global clock controller Sreeshankar K
2026-10-16 4:24 ` [PATCH v11 2/5] clk: qcom: Add Global Clock Controller (GCC) driver for SM7250 Sreeshankar K
2026-10-16 4:40 ` sashiko-bot
2026-10-16 4:24 ` [PATCH v11 3/5] dt-bindings: firmware: qcom,scm: Document SM7250 SCM Sreeshankar K
2026-10-16 4:24 ` [PATCH v11 4/5] dt-bindings: cpufreq: qcom-hw: Document SM7250 cpufreq hardware Sreeshankar K
2026-10-16 4:32 ` sashiko-bot [this message]
2026-10-16 4:24 ` [PATCH v11 5/5] arm64: dts: qcom: Add SM7250 devicetree file Sreeshankar K
2026-10-16 4:41 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-173787@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=sreeshankar0910@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.