From: sashiko-bot@kernel.org
To: "Wandun Chen" <chenwandun1@gmail.com>,
robh@kernel.org, baoquan.he@linux.dev, rppt@kernel.org,
m.szyprowski@samsung.com
Cc: catalin.marinas@arm.com, will@kernel.org, mark.rutland@arm.com,
chenhuacai@kernel.org, kernel@xen0n.name, pjw@kernel.org,
palmer@dabbelt.com, aou@eecs.berkeley.edu, alex@ghiti.fr,
tglx@kernel.org, mingo@redhat.com, bp@alien8.de,
dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
saravanak@kernel.org, akpm@linux-foundation.org,
pasha.tatashin@soleen.com, pratyush@kernel.org,
ruirui.yang@linux.dev, robin.murphy@arm.com,
kexec@lists.infradead.org
Subject: Re: [RESEND PATCH v8 3/8] crash_core: serialize crash header preparation against hotplug
Date: Fri, 16 Oct 2026 06:33:52 +0000 [thread overview]
Message-ID: <sashiko-outbox-173869@kernel.org> (raw)
In-Reply-To: <20261016061549.4181390-4-chenwandun1@gmail.com>
> From: Wandun Chen <chenwandun@lixiang.com>
>
> crash_prepare_headers() counts memory ranges before populating the
> allocated crash_mem array. The weak implementation used by ARM64,
> RISC-V and LoongArch walks memblock.memory, while x86 performs the same
> two-pass operation over system RAM resources. Concurrent memory hotplug
> can change range source between the two walks and make the populate
> pass overflow cmem->ranges.
>
> Take device_hotplug_lock when preparing crash headers during
> kexec_file_load(). The x86/riscv memory hotplug path already takes
> device_hotplug_lock, so call __crash_prepare_headers() directly
> to avoid recursive locking.
>
> Sashiko reported this issue in [1].
>
> Fixes: 3751e728cef2 ("arm64: kexec_file: add crash dump support")
> Fixes: 1bcca8620a91 ("LoongArch: Add crash dump support for kexec_file")
> Fixes: 8acea455fafa ("RISC-V: Support for kexec_file on panic")
> Fixes: dd5f726076cc ("kexec: support for kexec on panic using new system call")
> Signed-off-by: Wandun Chen <chenwandun@lixiang.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261016061549.4181390-1-chenwandun1@gmail.com?part=3
next prev parent reply other threads:[~2026-10-16 6:33 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-16 6:15 [RESEND PATCH v8 0/8] kdump: reduce vmcore size and capture time Wandun Chen
2026-10-16 6:15 ` Wandun Chen
2026-10-16 6:15 ` [RESEND PATCH v8 1/8] riscv: build crash_mem ranges from memblock instead of resource tree Wandun Chen
2026-10-16 6:15 ` Wandun Chen
2026-10-16 6:28 ` sashiko-bot
2026-10-16 6:15 ` [RESEND PATCH v8 2/8] crash_core: fold duplicated memblock arch hooks into the weak default Wandun Chen
2026-10-16 6:15 ` Wandun Chen
2026-10-16 6:30 ` sashiko-bot
2026-10-16 6:15 ` [RESEND PATCH v8 3/8] crash_core: serialize crash header preparation against hotplug Wandun Chen
2026-10-16 6:15 ` Wandun Chen
2026-10-16 6:33 ` sashiko-bot [this message]
2026-10-16 6:15 ` [RESEND PATCH v8 4/8] crash_core: replace for_each_mem_range() with for_each_mem_region() Wandun Chen
2026-10-16 6:15 ` Wandun Chen
2026-10-16 6:29 ` sashiko-bot
2026-10-16 6:15 ` [RESEND PATCH v8 5/8] memblock: introduce MEMBLOCK_NODUMP flag Wandun Chen
2026-10-16 6:15 ` Wandun Chen
2026-10-16 6:26 ` sashiko-bot
2026-10-16 6:15 ` [RESEND PATCH v8 6/8] of: reserved_mem: add dumpable flag to opt-in vmcore Wandun Chen
2026-10-16 6:15 ` Wandun Chen
2026-10-16 6:24 ` sashiko-bot
2026-10-16 6:15 ` [RESEND PATCH v8 7/8] of: reserved_mem: mark /reserved-memory entries with MEMBLOCK_NODUMP Wandun Chen
2026-10-16 6:15 ` Wandun Chen
2026-10-16 6:32 ` sashiko-bot
2026-10-16 6:15 ` [RESEND PATCH v8 8/8] crash_core: skip MEMBLOCK_NODUMP regions when building vmcore ELF header Wandun Chen
2026-10-16 6:15 ` Wandun Chen
2026-10-16 6:25 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-173869@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=baoquan.he@linux.dev \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=chenhuacai@kernel.org \
--cc=chenwandun1@gmail.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=kernel@xen0n.name \
--cc=kexec@lists.infradead.org \
--cc=m.szyprowski@samsung.com \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=palmer@dabbelt.com \
--cc=pasha.tatashin@soleen.com \
--cc=pjw@kernel.org \
--cc=pratyush@kernel.org \
--cc=robh@kernel.org \
--cc=robin.murphy@arm.com \
--cc=rppt@kernel.org \
--cc=ruirui.yang@linux.dev \
--cc=saravanak@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=tglx@kernel.org \
--cc=will@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.