Re: [PATCH v4 1/2] media: dt-bindings: imx908: Add Sony IMX908 sensor

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: Top-level additionalProperties: false breaks allOf references
--

commit 4681de18fac98c8519949f316873059d73610eb4
Author: Lachlan Michael <lachlan.michael@sony.com>

media: dt-bindings: imx908: Add Sony IMX908 sensor

This commit adds a new device tree binding for the Sony IMX908 CMOS image
sensor. It defines properties for a MIPI CSI-2 interface outputting RAW10
and RAW12 formats.

> diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx908.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx908.yaml
> new file mode 100644
> index 0000000000000..828db1175e2f5
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx908.yaml

[ ... ]

> +allOf:
> +  - $ref: /schemas/media/video-interface-devices.yaml#
> +
> +properties:

[ ... ]

> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - dvdd-supply
> +  - ovdd-supply
> +  - avdd-supply
> +  - port
> +
> +additionalProperties: false

[Severity: Medium]
Since this schema includes an allOf reference to video-interface-devices.yaml,
should this use unevaluatedProperties: false instead of
additionalProperties: false?

Using additionalProperties only considers the properties explicitly declared
in the local properties dictionary and ignores properties introduced via $ref
in an allOf block. If a device tree node defines any valid inherited standard
property, such as rotation or orientation, schema validation will incorrectly
reject it as an invalid additional property. Changing to
unevaluatedProperties: false will correctly allow properties evaluated by the
referenced schemas.

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261016075918.19345-1-lachlan.michael@sony.com?part=1