From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5585BCCA462 for ; Fri, 16 Oct 2026 09:09:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Date:References: In-Reply-To:Cc:To:Subject:From:Message-ID:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xXvQUYQq/V4WFnYPIPJ3BW4/Hh49gfF6YVGeqZmBW9M=; b=XCtoHOxJW8ilED Gd9l6K8R4seBVIKFx34QkHTac9Jv7Bsumw6WEbEDiNrEnjTXIEI2/L8sWVCpr/EbgaBi4meFMPQ5k NEEEgNtn1vEI3mfs/n/qAsv14X70hRKeZSEJfr/klUulIDEWlRPzDLD+fEwNo0Y4+yBrdq/LpnZt6 w8w1b2G9lYfWL2z8yjH5ypFjVmVv9smSWZ91l2u/lGDDWw4AOZCtg2NY3b95dYEfp7GFfQj2XEhGu 3XUi4dB9TQVI+gJxfXyQxxtbVBNQpnDl6kN00E5dRIjJMct0h8MI5LSoD0iA57MdV7H/Z1xog1dX+ gseq4Qp6j9zRx/5fh95A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xHdwj-00000002R4a-0Cb2; Fri, 16 Oct 2026 09:09:49 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xHdwh-00000002R4Q-35yF for linux-phy@lists.infradead.org; Fri, 16 Oct 2026 09:09:47 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 371B943F13; Fri, 16 Oct 2026 09:09:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A0AA11F000C5; Fri, 16 Oct 2026 09:09:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1792141787; bh=au5NZ+uww3QWwRsPTibFWYI4OmwUlU9DRbnVjOMpM94=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=mK4P8GvTaB9JQANCXJvbCOgytSroeCfQBVFJiKMamobKbpzqSsUAEq+z6v6/uW88d 5l/D3oi6bnTb7yGyPIsWk7I1mR22YcEqDpvIWodIJq74G6FGPgzNccP+yVZoEvOf8N v9K4X+GCqelXKaz7UNjy6ZHNAm06uUUenISpmuQXs6pThlyBL2kKI4cAZIWr9lans+ NNVDsHuhMxznG8ltVn67NqwgZYrFTxYRP0t9WSnc5/siX5qUUoS6zNwDoMHttRH7gq Ac1Imyr6/TVW0515oh/5Ftqyl+1UwJX3zE4okg8TR0CJ0kp1AnH1NOCWuENNoDgaQT jB0XYbn8hiuVA== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v5 3/8] phy: rockchip-samsung-dcphy: Move block-level setup to runtime resume To: "Jason Yang" Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org, vkoul@kernel.org, neil.armstrong@linaro.org, olteanv@gmail.com In-Reply-To: <20261016-dcphy-rx-v1-v5-3-e63b49eabe2d@gmail.com> References: <20261016-dcphy-rx-v1-v5-0-e63b49eabe2d@gmail.com> <20261016-dcphy-rx-v1-v5-3-e63b49eabe2d@gmail.com> Date: Fri, 16 Oct 2026 09:09:46 +0000 X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MSBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW01lZGl1bV0gcGh5OiBkY3BoeTog UExMIGxlZnQgZW5hYmxlZCBvbiBsb2NrIGZhaWx1cmUsIHByZXZlbnRpbmcgcmVjb3ZlcnkKLS0K CmNvbW1pdCAwNDM2YmZlNTUyMmEzMWVmNjU3MjRiNzFkZDJmNjgzZjAxZWJlYWExCkF1dGhvcjog SmFzb24gWWFuZyA8amFzb245ODE2NkBnbWFpbC5jb20+CgpwaHk6IHJvY2tjaGlwLXNhbXN1bmct ZGNwaHk6IE1vdmUgYmxvY2stbGV2ZWwgc2V0dXAgdG8gcnVudGltZSByZXN1bWUKClRoaXMgY29t bWl0IG1vdmVzIHRoZSBibG9jay1sZXZlbCBBUEIgcmVzZXQgYW5kIEJJQVMgY29uZmlndXJhdGlv bgpmcm9tIHRoZSBwb3dlci1vbiBwYXRoIHRvIHJ1bnRpbWUgcmVzdW1lLiBUaGlzIHByZXZlbnRz IHJlc2V0dGluZwp0aGUgYmxvY2sgdW5kZXJuZWF0aCBhIFBIWSB0aGF0IGlzIGFscmVhZHkgcnVu bmluZyB3aGVuIG11bHRpcGxlCmNvbnN1bWVycyBhcmUgcHJlc2VudC4KCj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvcGh5L3JvY2tjaGlwL3BoeS1yb2NrY2hpcC1zYW1zdW5nLWRjcGh5LmMgYi9kcml2 ZXJzL3BoeS9yb2NrY2hpcC9waHktcm9ja2NoaXAtc2Ftc3VuZy1kY3BoeS5jCj4gaW5kZXggNzM4 MjA0M2UxZjMxOS4uMTQ3MWExNTYzZDJhMSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL3BoeS9yb2Nr Y2hpcC9waHktcm9ja2NoaXAtc2Ftc3VuZy1kY3BoeS5jCj4gKysrIGIvZHJpdmVycy9waHkvcm9j a2NoaXAvcGh5LXJvY2tjaGlwLXNhbXN1bmctZGNwaHkuYwoKWyAuLi4gXQoKPiBAQCAtMTM2Miwx MCArMTM2MSw2IEBAIHN0YXRpYyBpbnQgc2Ftc3VuZ19taXBpX2RjcGh5X3Bvd2VyX29uKHN0cnVj dCBwaHkgKnBoeSkKPiAgewo+ICAJc3RydWN0IHNhbXN1bmdfbWlwaV9kY3BoeSAqc2Ftc3VuZyA9 IHBoeV9nZXRfZHJ2ZGF0YShwaHkpOwo+ICAKPiAtCXJlc2V0X2NvbnRyb2xfYXNzZXJ0KHNhbXN1 bmctPmFwYl9yc3QpOwo+IC0JdWRlbGF5KDEpOwo+IC0JcmVzZXRfY29udHJvbF9kZWFzc2VydChz YW1zdW5nLT5hcGJfcnN0KTsKPiAtCgpbU2V2ZXJpdHk6IE1lZGl1bV0KSWYgc2Ftc3VuZ19taXBp X2RjcGh5X3BsbF9lbmFibGUoKSBmYWlscyB0byBsb2NrLCBpdCByZXR1cm5zIHdpdGhvdXQgY2xl YXJpbmcKdGhlIFBMTF9FTiBiaXQgaW4gUExMX0NPTjA6Cgpkcml2ZXJzL3BoeS9yb2NrY2hpcC9w aHktcm9ja2NoaXAtc2Ftc3VuZy1kY3BoeS5jOnNhbXN1bmdfbWlwaV9kY3BoeV9wbGxfZW5hYmxl KCkgewoJcmVnbWFwX3VwZGF0ZV9iaXRzKHNhbXN1bmctPnJlZ21hcCwgUExMX0NPTjAsIFBMTF9F TiwgUExMX0VOKTsKCglyZXQgPSByZWdtYXBfcmVhZF9wb2xsX3RpbWVvdXQoc2Ftc3VuZy0+cmVn bWFwLCBQTExfU1RBVDAsCgkJCQkgICAgICAgc3RzLCAoc3RzICYgUExMX0xPQ0spLCAxMDAwLCAy MDAwMCk7CglpZiAocmV0IDwgMCkKCQlkZXZfZXJyKHNhbXN1bmctPmRldiwgIkRDLVBIWSBwbGwg ZmFpbGVkIHRvIGxvY2tcbiIpOwoKCXJldHVybiByZXQ7Cn0KCkJlY2F1c2UgdGhpcyBwYXRjaCBy ZW1vdmVzIHRoZSBhcGJfcnN0IHNlcXVlbmNlIGZyb20gdGhlIHBvd2VyX29uIHBhdGgsIHRoZQpz dGFsZSBQTExfRU4gYml0IGlzIG5vIGxvbmdlciBjbGVhcmVkIGJ5IHRoZSBoYXJkd2FyZSByZXNl dCBvbiBzdWJzZXF1ZW50CnJldHJpZXMuCgpEb2VzIHRoaXMgbGVhdmUgdGhlIGhhcmR3YXJlIGlu IGFuIGFjdGl2ZSBidXQgZmFpbGVkIHN0YXRlLCBwb3RlbnRpYWxseQpjYXVzaW5nIHVuZGVmaW5l ZCBiZWhhdmlvciBvciBwcmV2ZW50aW5nIHRoZSBQTEwgZnJvbSBsb2NraW5nIGR1cmluZyB0aGUK bmV4dCBwb3dlcl9vbiBhdHRlbXB0PwoKPiAgCXN3aXRjaCAoc2Ftc3VuZy0+dHlwZSkgewo+ICAJ Y2FzZSBQSFlfVFlQRV9EUEhZOgo+ICAJCXJldHVybiBzYW1zdW5nX21pcGlfZHBoeV9wb3dlcl9v bihzYW1zdW5nKTsKCi0tIApTYXNoaWtvIEFJIHJldmlldyDCtyBodHRwczovL3Nhc2hpa28uZGV2 LyMvcGF0Y2hzZXQvMjAyNjEwMTYtZGNwaHktcngtdjEtdjUtMC1lNjNiNDllYWJlMmRAZ21haWwu Y29tP3BhcnQ9MwoKLS0gCmxpbnV4LXBoeSBtYWlsaW5nIGxpc3QKbGludXgtcGh5QGxpc3RzLmlu ZnJhZGVhZC5vcmcKaHR0cHM6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8v bGludXgtcGh5Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C8DAE45C70A for ; Fri, 16 Oct 2026 09:09:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792141789; cv=none; b=gPYn0Ktc/8rYKhB4lx3GJCz8SJz+cNqJeBGBWfM139du5TCWdPrQwniOa8qQPdRq8W96JYD8V2YdbTPJAu5xS0CXPfswZKTg7GNlK7duPMhEp4z2t2NLwm1dpKFV+h13WTcWXCT3F7zvEdv6E13pGI5QZm5wgCUcuAPLGa/CaWs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792141789; c=relaxed/simple; bh=okaqFpl6hflwl3tgUEbSCH/7wwTcyVLb87qs7QWILTA=; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type: Date; b=CxyA4KZAigT9KglhRPII+Sk3lMwqhyKYXZv1rmlCdKSce8hr88Yznxmnnt9G2zv6igajEL06HKFCOJDhb2tXadNYmMR54v0LDOVArDOj8VW5IqzSfX6jEGDNWmgUcTlcyA5k+FdsH4R+LJa8kDkTpEo0aQrWnlRXZgRqRiPFZ3I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=mK4P8GvT; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="mK4P8GvT" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A0AA11F000C5; Fri, 16 Oct 2026 09:09:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1792141787; bh=au5NZ+uww3QWwRsPTibFWYI4OmwUlU9DRbnVjOMpM94=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=mK4P8GvTaB9JQANCXJvbCOgytSroeCfQBVFJiKMamobKbpzqSsUAEq+z6v6/uW88d 5l/D3oi6bnTb7yGyPIsWk7I1mR22YcEqDpvIWodIJq74G6FGPgzNccP+yVZoEvOf8N v9K4X+GCqelXKaz7UNjy6ZHNAm06uUUenISpmuQXs6pThlyBL2kKI4cAZIWr9lans+ NNVDsHuhMxznG8ltVn67NqwgZYrFTxYRP0t9WSnc5/siX5qUUoS6zNwDoMHttRH7gq Ac1Imyr6/TVW0515oh/5Ftqyl+1UwJX3zE4okg8TR0CJ0kp1AnH1NOCWuENNoDgaQT jB0XYbn8hiuVA== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v5 3/8] phy: rockchip-samsung-dcphy: Move block-level setup to runtime resume Reply-To: sashiko-reviews@lists.linux.dev To: "Jason Yang" Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org, vkoul@kernel.org, neil.armstrong@linaro.org, olteanv@gmail.com In-Reply-To: <20261016-dcphy-rx-v1-v5-3-e63b49eabe2d@gmail.com> References: <20261016-dcphy-rx-v1-v5-0-e63b49eabe2d@gmail.com> <20261016-dcphy-rx-v1-v5-3-e63b49eabe2d@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 16 Oct 2026 09:09:46 +0000 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Medium] phy: dcphy: PLL left enabled on lock failure, preventing recovery -- commit 0436bfe5522a31ef65724b71dd2f683f01ebeaa1 Author: Jason Yang phy: rockchip-samsung-dcphy: Move block-level setup to runtime resume This commit moves the block-level APB reset and BIAS configuration from the power-on path to runtime resume. This prevents resetting the block underneath a PHY that is already running when multiple consumers are present. > diff --git a/drivers/phy/rockchip/phy-rockchip-samsung-dcphy.c b/drivers/= phy/rockchip/phy-rockchip-samsung-dcphy.c > index 7382043e1f319..1471a1563d2a1 100644 > --- a/drivers/phy/rockchip/phy-rockchip-samsung-dcphy.c > +++ b/drivers/phy/rockchip/phy-rockchip-samsung-dcphy.c [ ... ] > @@ -1362,10 +1361,6 @@ static int samsung_mipi_dcphy_power_on(struct phy = *phy) > { > struct samsung_mipi_dcphy *samsung =3D phy_get_drvdata(phy); > =20 > - reset_control_assert(samsung->apb_rst); > - udelay(1); > - reset_control_deassert(samsung->apb_rst); > - [Severity: Medium] If samsung_mipi_dcphy_pll_enable() fails to lock, it returns without cleari= ng the PLL_EN bit in PLL_CON0: drivers/phy/rockchip/phy-rockchip-samsung-dcphy.c:samsung_mipi_dcphy_pll_en= able() { regmap_update_bits(samsung->regmap, PLL_CON0, PLL_EN, PLL_EN); ret =3D regmap_read_poll_timeout(samsung->regmap, PLL_STAT0, sts, (sts & PLL_LOCK), 1000, 20000); if (ret < 0) dev_err(samsung->dev, "DC-PHY pll failed to lock\n"); return ret; } Because this patch removes the apb_rst sequence from the power_on path, the stale PLL_EN bit is no longer cleared by the hardware reset on subsequent retries. Does this leave the hardware in an active but failed state, potentially causing undefined behavior or preventing the PLL from locking during the next power_on attempt? > switch (samsung->type) { > case PHY_TYPE_DPHY: > return samsung_mipi_dphy_power_on(samsung); --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261016-dcphy-rx-v= 1-v5-0-e63b49eabe2d@gmail.com?part=3D3