From: sashiko-bot@kernel.org
To: "Crescent Hsieh" <crescentcy.hsieh@moxa.com>
Cc: linux-usb@vger.kernel.org
Subject: Re: [PATCH 3/6] USB: serial: add stop and start callbacks
Date: Fri, 16 Oct 2026 10:13:09 +0000 [thread overview]
Message-ID: <sashiko-outbox-174129@kernel.org> (raw)
In-Reply-To: <20261016100351.681390-4-crescentcy.hsieh@moxa.com>
> The tty layer uses the stop and start operations to suspend and resume
> output, but the USB serial core does not currently provide them. This
> prevents USB serial subdrivers from handling output flow control through
> the normal tty path.
>
> Add tty stop and start operations and forward them to optional USB
> serial driver callbacks. Drivers which do not provide the callbacks
> retain the existing behaviour.
>
> Signed-off-by: Crescent Hsieh <crescentcy.hsieh@moxa.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261016100351.681390-1-crescentcy.hsieh@moxa.com?part=3
next prev parent reply other threads:[~2026-10-16 10:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-16 10:03 [PATCH 0/6] USB: serial: mxuport: improve tty operation support Crescent Hsieh
2026-10-16 10:03 ` [PATCH 1/6] USB: serial: mxuport: use usb_control_msg_recv() Crescent Hsieh
2026-10-16 10:12 ` sashiko-bot
2026-10-16 10:03 ` [PATCH 2/6] USB: serial: mxuport: initialize modem status on open Crescent Hsieh
2026-10-16 10:16 ` sashiko-bot
2026-10-16 10:03 ` [PATCH 3/6] USB: serial: add stop and start callbacks Crescent Hsieh
2026-10-16 10:13 ` sashiko-bot [this message]
2026-10-16 10:03 ` [PATCH 4/6] USB: serial: mxuport: handle output flow control Crescent Hsieh
2026-10-16 10:13 ` sashiko-bot
2026-10-16 10:03 ` [PATCH 5/6] USB: serial: mxuport: handle TCFLSH buffer purge Crescent Hsieh
2026-10-16 10:23 ` sashiko-bot
2026-10-16 10:03 ` [PATCH 6/6] USB: serial: mxuport: wait for UART transmit completion Crescent Hsieh
2026-10-16 10:15 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-174129@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=crescentcy.hsieh@moxa.com \
--cc=linux-usb@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.