Re: [PATCH] dt-bindings: crypto: qcom,inline-crypto-engine: Add IPQ5210, IPQ5424 and IPQ9650

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: compatible strings in enum list are not sorted alphabetically
--

commit e22b78d683f92d3a3cc416d808b2c4da1c5e0341
Author: Varadarajan Narayanan <varadarajan.narayanan@oss.qualcomm.com>

dt-bindings: crypto: qcom,inline-crypto-engine: Add IPQ5210, IPQ5424 and IPQ9650

Document the Inline Crypto Engine compatibles for the Qualcomm IPQ5210,
IPQ5424 and IPQ9650 SoCs. Separate the power-domains requirement from the
two-clock requirement because these SoCs do not require power-domains. Preserve
the existing requirements for other platforms.

> diff --git a/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml b/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml
> index 23bf98c2b9fa0..e838694bb70a8 100644
> --- a/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml
> +++ b/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml

[ ... ]

> @@ -89,6 +91,29 @@ allOf:
>          clock-names:
>            minItems: 2
>  
> +  - if:
> +      not:
> +        properties:
> +          compatible:
> +            contains:
> +              enum:
> +                - qcom,ipq5424-inline-crypto-engine
> +                - qcom,ipq5210-inline-crypto-engine

[Severity: Low]
This isn't a bug, but should these compatible strings be kept in alphabetical
order? It looks like qcom,ipq5424-inline-crypto-engine was placed before
qcom,ipq5210-inline-crypto-engine.

> +                - qcom,ipq9650-inline-crypto-engine
> +                - qcom,kaanapali-inline-crypto-engine
> +                - qcom,qcs8300-inline-crypto-engine

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261016-ice-v1-1-4098b1972f31@oss.qualcomm.com?part=1