All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "David Carlier" <devnexen@gmail.com>
Cc: virtualization@lists.linux.dev,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Eugenio Perez" <eperezma@redhat.com>
Subject: Re: [PATCH net-next v3 1/3] vsock: move SOL_SOCKET options to vsock_sol_socket_setsockopt()
Date: Fri, 16 Oct 2026 13:36:24 +0000	[thread overview]
Message-ID: <sashiko-outbox-174385@kernel.org> (raw)
In-Reply-To: <20261016132716.272018-2-devnexen@gmail.com>

> SO_ZEROCOPY is handled inline in vsock_connectible_setsockopt(). Move it
> to a helper with a switch on optname, so other SOL_SOCKET options can be
> added as new cases. The value parsing goes to its own helper too, so each
> option can do its own checks before it.
> 
> No functional change.
> 
> Signed-off-by: David Carlier <devnexen@gmail.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261016132716.272018-1-devnexen@gmail.com?part=1


  reply	other threads:[~2026-10-16 13:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-16 13:27 [PATCH net-next v3 0/3] vsock: SO_INQ for stream sockets David Carlier
2026-10-16 13:27 ` [PATCH net-next v3 1/3] vsock: move SOL_SOCKET options to vsock_sol_socket_setsockopt() David Carlier
2026-10-16 13:36   ` sashiko-bot [this message]
2026-10-16 13:27 ` [PATCH net-next v3 2/3] vsock: support SO_INQ on stream sockets David Carlier
2026-10-16 13:36   ` sashiko-bot
2026-10-16 13:27 ` [PATCH net-next v3 3/3] vsock/test: cover SO_INQ David Carlier
2026-10-16 13:36   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-174385@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=devnexen@gmail.com \
    --cc=eperezma@redhat.com \
    --cc=mst@redhat.com \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=virtualization@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.