Re: [PATCH 02/10] dt-bindings: pinctrl: Add devicetree bindings for DM816x SoC Pinctrl

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] dt-bindings: dm816x: PIN_INPUT/OUTPUT macros implicitly enable pulldowns
--

commit adcfa5381ee4b63a7366410a6458384ec5d3b10f
Author: Ettore Chimenti <ettore.chimenti@linaro.org>

dt-bindings: pinctrl: Add devicetree bindings for DM816x SoC Pinctrl

This commit adds devicetree bindings for TI DM816x SoC pinctrl configuration.
It uses the OMAP2/3 definitions but attempts to handle the inverted
pullup/down enable macros specific to this SoC.

> diff --git a/include/dt-bindings/pinctrl/dm816x.h b/include/dt-bindings/pinctrl/dm816x.h
> new file mode 100644
> index 0000000000000..15aa15bca9bd5
> --- /dev/null
> +++ b/include/dt-bindings/pinctrl/dm816x.h
> @@ -0,0 +1,20 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
> +/*
> + * This header provides constants specific to DM816X pinctrl bindings.
> + */
> +
> +#ifndef _DT_BINDINGS_PINCTRL_DM816X_H
> +#define _DT_BINDINGS_PINCTRL_DM816X_H
> +
> +#include <dt-bindings/pinctrl/omap.h>
> +
> +#undef PULL_UP
> +#undef PULL_ENA
> +
> +/* DM81xx mux bit defines */
> +#define PULL_ENA		(0 << 3)  /* Pullup enabled  => 0 */
> +#define PULL_DIS		(1 << 3)  /* Pullup disabled => 1 */

[Severity: High]
Does this implicitly enable pulldowns for all inputs and outputs? 

Because the DM816x SoC uses inverted pull-enable logic where bit 3 being 0
enables the pull resistor, inheriting the generic PIN_INPUT and PIN_OUTPUT
macros directly from omap.h will evaluate them with bit 3 as 0. 

This makes it difficult to configure floating inputs or plain outputs without
pulls using the standard macros. Should this header also #undef and redefine
PIN_INPUT and PIN_OUTPUT to bitwise-OR the PULL_DIS flag so that pulls are
disabled by default?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261016-patch-ektor5-dm8168-dts-v1-0-b4ce30217028@linaro.org?part=2