Re: [PATCH 2/3] iio: light: Update DT bindings for GP2AP002

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] iio: gp2ap002: vled regulator leak in error paths
--

commit 999604192c18f52748ad72ac0d26233473334acf
Author: Christoph Rudorff <chris@rudorff.com>

iio: light: Update DT bindings for GP2AP002

This commit adds the missing vled-supply regulator to the device tree
bindings for the Sharp GP2AP002 sensor.

> diff --git a/Documentation/devicetree/bindings/iio/light/sharp,gp2ap002.yaml b/Documentation/devicetree/bindings/iio/light/sharp,gp2ap002.yaml
> index 99bddf31cbed2..2b5025043168a 100644
> --- a/Documentation/devicetree/bindings/iio/light/sharp,gp2ap002.yaml
> +++ b/Documentation/devicetree/bindings/iio/light/sharp,gp2ap002.yaml
> @@ -33,6 +33,9 @@ properties:
>    vio-supply:
>      description: VIO power supply a phandle to a regulator
>  
> +  vled-supply:
> +    description: LED power supply a phandle to a regulator
> +
>    io-channels:
>      maxItems: 1
>      description: ALSOUT ADC channel to read the ambient light

While reviewing this binding addition, I noticed the corresponding driver
code might be missing cleanup for this regulator.

drivers/iio/light/gp2ap002.c:gp2ap002_probe() {
...
	ret = regulator_enable(gp2ap002->vled);
	if (ret) {
		dev_err(dev, "failed to enable VLED regulator\n");
		goto out_disable_vio;
	}

	msleep(20);

	/*
	 * Initialize the device and signal to runtime PM that now we are
	 * definitely up and using power.
	 */
	ret = gp2ap002_init(gp2ap002);
	if (ret) {
		dev_err(dev, "initialization failed\n");
		goto out_disable_vio;
	}
...
out_disable_vio:
	regulator_disable(gp2ap002->vio);
out_disable_vdd:
	regulator_disable(gp2ap002->vdd);
	return ret;
}

[Severity: Medium]
Does this code leak the vled regulator? If initialization fails, the error path
jumps to out_disable_vio, completely skipping the disablement of vled and
leaving it indefinitely enabled.

The same sequence appears during runtime resume:

drivers/iio/light/gp2ap002.c:gp2ap002_runtime_resume() {
...
	ret = regulator_enable(gp2ap002->vled);
	if (ret) {
		dev_err(dev, "failed to enable VLED regulator in resume path\n");
		goto out_disable_vio;
	}

	msleep(20);

	ret = gp2ap002_init(gp2ap002);
	if (ret) {
		dev_err(dev, "re-initialization failed\n");
		goto out_disable_vio;
	}
...
out_disable_vio:
	regulator_disable(gp2ap002->vio);
out_disable_vdd:
	regulator_disable(gp2ap002->vdd);
	return ret;
}

[Severity: Medium]
Does this code similarly leak the vled regulator during a resume failure?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261016-iio-light-gp2ap002-v1-0-7c93312fa8d5@rudorff.com?part=2