Re: [PATCH net-next v25 2/3] net: phy: Add support for Template Control register for PMA

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] uapi: internal GENMASK() macro in exported header breaks userspace builds
--

commit b7a3d7bbc3ea78c17c69740f5d19e179c57d12cd
Author: Kyle Switch <kyle.switch@motor-comm.com>

net: phy: Add support for Template Control register for PMA

This commit adds support for the 10GBASE-T PMA Template Test Mode register
field. It allows selecting one of eight test modes used for PHY validation.

> diff --git a/include/uapi/linux/mdio.h b/include/uapi/linux/mdio.h
> index 06f4bc3c20c71..353ca13c64fca 100644
> --- a/include/uapi/linux/mdio.h
> +++ b/include/uapi/linux/mdio.h

[ ... ]

> @@ -320,6 +321,17 @@
>  /* PMA 10GBASE-R Fast Retrain status and control register. */
>  #define MDIO_PMA_10GBR_FSRT_ENABLE	0x0001	/* Fast retrain enable */
>  
> +/* PMA 10GBASE-T Template Test Mode Register*/
> +#define MDIO_PMA_10GBT_TESTMODE_MASK GENMASK(15, 13) /* Template test mode */

[Severity: Medium]
Will this break userspace builds? The GENMASK() macro is an internal kernel
macro defined in <linux/bits.h> and is not exported to userspace.

If an external program includes <linux/mdio.h> and attempts to use
MDIO_PMA_10GBT_TESTMODE_MASK, won't it encounter compilation failures due to
the undefined macro? Should this be defined using an explicit hexadecimal
literal (like 0xE000) or the __GENMASK() macro instead to keep the exported
UAPI header functional for userspace applications?

> +#define MDIO_PMA_10GBT_TESTMODE_NORMAL 0x0 /* Template Normal */
> +#define MDIO_PMA_10GBT_TESTMODE_1 0x1 /* Template TestMode1 */

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261015145021.2216003-1-kyle.switch@motor-comm.com?part=2