Re: [PATCH 2/2] KVM: selftests: Reject GICv3 ITS with a GICv5 VGIC

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] selftests: vgic_v5.c uses ad hoc skip messages and direct exit() instead of TAP
--

commit 1b97dfda1bac7a30c8395c0645ac8efb945b4639
Author: Sascha Bischoff <sascha.bischoff@arm.com>

KVM: selftests: Reject GICv3 ITS with a GICv5 VGIC

Check that a GICv3 ITS and a GICv5 VGIC cannot be paired, regardless
of which device is created first. Skip the check when the host does not
expose a GICv3 ITS.

> diff --git a/tools/testing/selftests/kvm/arm64/vgic_v5.c b/tools/testing/selftests/kvm/arm64/vgic_v5.c
> index d5df742b23001..5bf7d99d29147 100644
> --- a/tools/testing/selftests/kvm/arm64/vgic_v5.c
> +++ b/tools/testing/selftests/kvm/arm64/vgic_v5.c
[ ... ]
> @@ -2003,8 +2003,40 @@ int test_kvm_device(u32 gic_dev_type)
>  	return 0;
>  }
>  
> +static void test_vgic_v3_its_with_vgic_v5(void)
> +{
> +	struct kvm_vm *vm = vm_create_barebones();
> +	int gic_fd, its_fd, ret;
> +
> +	if (__kvm_test_create_device(vm, KVM_DEV_TYPE_ARM_VGIC_ITS)) {
> +		pr_info("No GICv3 ITS support; skipping mixed-model test.\n");
> +		kvm_vm_free(vm);
> +		return;
> +	}

[Severity: Medium]
When running test_vgic_v3_its_with_vgic_v5() on a host without GICv3 ITS
support, this prints an unstructured skip message and returns directly.

Could this be converted to use a TAP reporting macro like
ksft_test_result_skip() instead of an ad-hoc pr_info() and return?

Additionally, running the test suite on a host without GICv5 support calls
exit(KSFT_SKIP) directly in main() instead of using ksft_exit_skip().
Are there plans to update the main() exit path as well?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261016152225.898761-1-sascha.bischoff@arm.com?part=2