From: sashiko-bot@kernel.org
To: wyibo6109@gmail.com, linux-input@vger.kernel.org
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org,
dmitry.torokhov@gmail.com
Subject: Re: [PATCH v6 1/2] dt-bindings: input: add OnePlus pogo-pin keyboard
Date: Fri, 16 Oct 2026 16:45:03 +0000 [thread overview]
Message-ID: <sashiko-outbox-174660@kernel.org> (raw)
In-Reply-To: <20261016163859.1070138-2-wyibo6109@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] MAINTAINERS: new ONEPLUS entry is inserted out of alphabetical order
--
commit a3b7a3bdc211b0789ad103d539fa35e6dcf0f689
Author: Yibo Wang <wyibo6109@gmail.com>
dt-bindings: input: add OnePlus pogo-pin keyboard
This commit adds device tree bindings for the OnePlus Pad and OPPO Pad
pogo-pin smart keyboards. It defines the required properties for the keyboard
MCU attached via UART, and adds the corresponding maintainer entry.
> diff --git a/MAINTAINERS b/MAINTAINERS
> index b8c4e1080af94..d81e400059ced 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -20154,6 +20154,12 @@ S: Maintained
> F: Documentation/ABI/testing/sysfs-bus-platform-onboard-usb-dev
> F: drivers/usb/misc/onboard_usb_dev.c
>
> +ONEPLUS POGO-PIN KEYBOARD DRIVER
> +M: Yibo Wang <wyibo6109@gmail.com>
> +L: linux-input@vger.kernel.org
> +S: Maintained
> +F: Documentation/devicetree/bindings/input/oneplus,pogo-keyboard.yaml
> +
> ONENAND FLASH DRIVER
[Severity: Low]
This isn't a bug, but should this new maintainer entry be placed further
down to preserve alphabetical sorting? Since P in ONEPLUS comes after N in
ONENAND, inserting it here places it out of alphabetical order, which might
trigger warnings from automated sorting checks or checkpatch.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261016163859.1070138-1-wyibo6109@gmail.com?part=1
next prev parent reply other threads:[~2026-10-16 16:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-16 16:38 [PATCH v6 0/2] Input: add support for OnePlus/OPPO Pad pogo-pin keyboards wyibo6109
2026-10-16 16:38 ` [PATCH v6 1/2] dt-bindings: input: add OnePlus pogo-pin keyboard wyibo6109
2026-10-16 16:45 ` sashiko-bot [this message]
2026-10-16 16:38 ` [PATCH v6 2/2] Input: add OnePlus/OPPO Pad pogo-pin keyboard serdev driver wyibo6109
2026-10-16 16:49 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-174660@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=wyibo6109@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.