Re: [PATCH v27 3/4] rust: leds: Add multicolor classdev abstractions

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] rust: missing #[inline] attribute on MultiColorDevice Deref implementation
--

commit 613f67478931d09e9dba3aabd68d89e0638569b4
Author: Markus Probst <markus.probst@posteo.de>

rust: leds: Add multicolor classdev abstractions

This commit adds Rust abstractions for multicolor led class devices. It
introduces the MultiColor led mode, MultiColorSubLed, MultiColorDevice,
and DeviceBuilder::build_multicolor to handle registration and lifecycle
management of multicolor LEDs.

> diff --git a/rust/kernel/led/multicolor.rs b/rust/kernel/led/multicolor.rs
> new file mode 100644
> index 0000000000000..aebc8a24712ab
> --- /dev/null
> +++ b/rust/kernel/led/multicolor.rs

[ ... ]

> +impl<'bound, T: LedOps + 'bound> Deref for MultiColorDevice<'bound, T> {
> +    type Target = T;
> +
> +    fn deref(&self) -> &Self::Target {
> +        &self.ops
> +    }
> +}

[Severity: Low]
This isn't a bug, but according to the Rust subsystem guidelines, small
functions in abstractions that merely forward to a field or a C binding
should be annotated with #[inline].

Since the Deref::deref method implementation for MultiColorDevice is a
trivial field access, should this include the #[inline] annotation? Without
it, the optimizer might be hindered from inlining the dereference effectively
across crate boundaries.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261016-rust_leds-v27-0-2c296d8a8e5b@posteo.de?part=3