From: sashiko-bot@kernel.org
To: "Yuho Choi" <oss.patchbox@gmail.com>
Cc: linux-rdma@vger.kernel.org
Subject: Re: [PATCH net-next v1 3/4] net/mlx5: DR, Don't free the send ring CQ if destroying it fails
Date: Sat, 17 Oct 2026 04:59:32 +0000 [thread overview]
Message-ID: <sashiko-outbox-175296@kernel.org> (raw)
In-Reply-To: <20261016045849.813696-9-oss.patchbox@gmail.com>
> dr_destroy_cq() ignores the result of mlx5_core_destroy_cq() and frees
> the CQ buffer, doorbell record and struct mlx5dr_cq anyway. If
> DESTROY_CQ fails, the CQ may still exist in firmware and retain access
> to its buffer and doorbell record. mlx5_core_destroy_cq() also returns
> early in that case, without waiting for EQ handlers that may already
> hold a reference to the CQ.
>
> Keep the CQ and its buffer when DESTROY_CQ fails, as the regular mlx5_ib
> CQ destroy path does. A device in internal error is not affected, since
> the mlx5 core reports success for DESTROY_CQ in that state.
>
> Fixes: 297cccebdc5a ("net/mlx5: DR, Expose an internal API to issue RDMA operations")
> Assisted-by: LLM
> Signed-off-by: Yuho Choi <oss.patchbox@gmail.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261016045849.813696-6-oss.patchbox@gmail.com?part=3
next prev parent reply other threads:[~2026-10-17 4:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-16 4:57 [PATCH net-next v1 0/4] net/mlx5: Don't free CQs whose destroy failed Yuho Choi
2026-10-16 4:57 ` [PATCH net-next v1 1/4] net/mlx5: Don't free the ASO CQ if destroying it fails Yuho Choi
2026-10-17 4:59 ` sashiko-bot
2026-10-16 4:57 ` [PATCH net-next v1 2/4] net/mlx5: Don't free the WC test " Yuho Choi
2026-10-17 4:59 ` sashiko-bot
2026-10-16 4:57 ` [PATCH net-next v1 3/4] net/mlx5: DR, Don't free the send ring " Yuho Choi
2026-10-17 4:59 ` sashiko-bot [this message]
2026-10-16 4:57 ` [PATCH net-next v1 4/4] net/mlx5: HWS, Don't free the send ring CQ buffer if destroying the CQ fails Yuho Choi
2026-10-17 4:59 ` sashiko-bot
2026-10-16 6:59 ` [PATCH net-next v1 0/4] net/mlx5: Don't free CQs whose destroy failed Junxian Huang
2026-10-16 13:30 ` Yuho Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-175296@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=oss.patchbox@gmail.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.