Re: [PATCH net-next v2 1/5] dt-bindings: net: maxlinear: add MxL86211C VDDP supply

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: overly restrictive select block breaks validation for other PHYs
--

commit 695546f38e461889fde9ccbc3738543cebc3766c
Author: Robert Marko <robert.marko@sartura.hr>

dt-bindings: net: maxlinear: add MxL86211C VDDP supply

This commit describes the VDDP supply used by the MxL86211C PHY.
It adds a new schema section to validate that the supply requirement is met
when the MxL86211C PHY ID is present.

> diff --git a/Documentation/devicetree/bindings/net/maxlinear,gpy2xx.yaml b/Documentation/devicetree/bindings/net/maxlinear,gpy2xx.yaml
> index 8a3713abd1ca9..a0dfb6192d81b 100644
> --- a/Documentation/devicetree/bindings/net/maxlinear,gpy2xx.yaml
> +++ b/Documentation/devicetree/bindings/net/maxlinear,gpy2xx.yaml
> @@ -10,10 +10,38 @@ maintainers:
>    - Andrew Lunn <andrew@lunn.ch>
>    - Michael Walle <michael@walle.cc>
>  
> +select:
> +  properties:
> +    compatible:
> +      contains:
> +        const: ethernet-phy-idc133.5400
> +  required:
> +    - compatible

[Severity: Medium]
Does this top-level select block restrict the entire schema to only match this
single PHY ID? By acting as a gatekeeper for the whole schema, it appears this
breaks validation for all other supported GPY2xx PHYs.

For example, the maxlinear,use-broken-interrupts property intended for
GPY215B/C might no longer be validated, and even pre-existing examples in the
schema might fail to match.

> +
>  allOf:
>    - $ref: ethernet-phy.yaml#
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: ethernet-phy-idc133.5400
> +      required:
> +        - compatible
> +
> +    then:
> +      required:
> +        - vddp-supply
> +
> +    else:
> +      properties:
> +        vddp-supply: false

[Severity: Medium]
Since the top-level select block already guarantees that the compatible string
contains ethernet-phy-idc133.5400, does this else branch become dead code? 

The if condition will always evaluate to true when this file is applied, so
this branch won't be able to enforce the vddp-supply restriction on other
PHYs.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261016112033.949026-1-robert.marko@sartura.hr?part=1