Re: [PATCH net-next v8 2/4] net: mana: give each HWC message slot its own completion state

[sashiko-bot@kernel.org]

> From: Long Li <longli@microsoft.com>
> 
> Concurrent requests require the response handler and the waiting sender to
> agree on the lifetime and result state of each message slot.
> 
> Protect the caller's output buffer, Linux error and device status with a
> per-slot lock. Publish the output buffer only while the sender is waiting
> and withdraw it before every return. A late response cannot copy through a
> pointer to caller storage whose lifetime has ended.
> 
> Reinitialize completion and result state under both the allocation and
> per-slot locks when acquiring the slot. A response handler can still hold
> the per-slot lock after the previous sender has returned its admission
> permit, so an unpublished bitmap bit alone is not sufficient protection.
> If the response records its result while the timed wait expires, return
> [ ... ]
> Link: https://lore.kernel.org/r/20260908035201.402424-4-longli@microsoft.com
> Link: https://lore.kernel.org/r/179196575434.434549.4428132041097324407@kernel.org
> Link: https://lore.kernel.org/r/179196575640.434549.9102950927041409151@kernel.org
> Signed-off-by: Long Li <longli@microsoft.com>
> Signed-off-by: Wei Hu <weh@microsoft.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1791998462.git.weh@linux.microsoft.com?part=2