Re: [PATCH] USB: serial: garmin_gps: explicitly stop read urb on unbind

[sashiko-bot@kernel.org]

> The garmin_gps read URB may be submitted from the interrupt URB
> completion handler and should therefore be stopped after stopping the
> interrupt URB and before freeing the port data during port unbind.
> 
> When a USB serial device is disconnected (or unbound through sysfs),
> USB serial core stops and poisons the port URBs before unbinding the
> port however so there is no risk for a use-after-free in the read URB
> completion handler even if the driver does not stop it in its remove()
> callback.
> 
> Stop the read URB explicitly for consistency, to avoid relying on core
> and to prevent false positive reports from LLMs.
> 
> Note that this was erroneously flagged as a use-after-free by Sashiko.
> 
> Signed-off-by: Johan Hovold <johan@kernel.org>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261017121019.1777984-1-johan@kernel.org?part=1