All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Johan Hovold" <johan@kernel.org>
Cc: linux-usb@vger.kernel.org
Subject: Re: [PATCH] USB: serial: usb_wwan: handle urb allocation failure
Date: Sat, 17 Oct 2026 12:38:18 +0000	[thread overview]
Message-ID: <sashiko-outbox-175506@kernel.org> (raw)
In-Reply-To: <20261017123515.1788872-1-johan@kernel.org>

> Make sure to bail out from probe if URB allocation fails to avoid ever
> dereferencing a NULL-pointer in usb_wwan_write() or on resume of an open
> port.
> 
> Note that URB allocation is not expected to fail unless doing fault
> injection.
> 
> The usb_wwan_write() issue was flagged by Sashiko.
> 
> Fixes: 58cfe9113e48 ("[PATCH] USB: add Option Card driver")
> Cc: stable@vger.kernel.org
> Signed-off-by: Johan Hovold <johan@kernel.org>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261017123515.1788872-1-johan@kernel.org?part=1


      reply	other threads:[~2026-10-17 12:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-17 12:35 [PATCH] USB: serial: usb_wwan: handle urb allocation failure Johan Hovold
2026-10-17 12:38 ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-175506@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=johan@kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.