Re: [RFC PATCH v2 1/7] kbuild: factor the userspace ABI flags out into KBUILD_USERABI

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] kbuild: KBUILD_USERABI omitted from SBOM environment allowlist
--

commit 907dedf7b95c5c493b503479d22886e4a895a2f8
Author: Sasha Levin <sashal@kernel.org>

kbuild: factor the userspace ABI flags out into KBUILD_USERABI

This commit factors out the userspace ABI flags into a new KBUILD_USERABI
variable and exports it. This allows programs built outside of kbuild's
userprogs to be compiled for the same ABI without inheriting other flags.

> diff --git a/Makefile b/Makefile
> index 7c855e6fe5448..8c94aff229b21 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -650,7 +650,7 @@ export CPP AR NM STRIP OBJCOPY OBJDUMP READELF PAHOLE RESOLVE_BTFIDS LEX YACC AW
>  export PERL PYTHON3 CHECK CHECKFLAGS MAKE UTS_MACHINE HOSTCXX
>  export KGZIP KBZIP2 KLZOP LZMA LZ4 XZ ZSTD TAR
>  export KBUILD_HOSTCXXFLAGS KBUILD_HOSTLDFLAGS KBUILD_HOSTLDLIBS KBUILD_PROCMACROLDFLAGS LDFLAGS_MODULE
> -export KBUILD_USERCFLAGS KBUILD_USERLDFLAGS
> +export KBUILD_USERCFLAGS KBUILD_USERLDFLAGS KBUILD_USERABI

[Severity: Low]
Does this new exported variable also need to be added to the SPDX SBOM
environment allowlist?

Currently, KBUILD_USERCFLAGS and KBUILD_USERLDFLAGS are explicitly tracked
in KERNEL_BUILD_VARIABLES_ALLOWLIST in scripts/sbom/sbom/environment.py:

scripts/sbom/sbom/environment.py:
KERNEL_BUILD_VARIABLES_ALLOWLIST = [
    ...
    "KBUILD_USERCFLAGS",
    "KBUILD_USERLDFLAGS",
    ...
]

Leaving KBUILD_USERABI off this list means its value will not be captured
in the SPDX SBOM generated by scripts/sbom, resulting in incomplete build
metadata documentation for the userspace ABI configuration.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261016143143.3613501-1-sashal@kernel.org?part=1