Re: [PATCH v3 2/3] arm64: dts: qcom: Add sm8250-oneplus-common.dtsi

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] arm64: dts: qcom: duplicate KEY_VOLUMEDOWN on gpio-keys and pon_resin
--

commit 7ef24e1b9b48012e8e7fa23614b055d4480b386c
Author: Frieder Hannenheim <git@fhannenheim.net>

arm64: dts: qcom: Add sm8250-oneplus-common.dtsi

This commit adds a common device tree include file for OnePlus devices
based on the Qualcomm SM8250 SoC, defining shared reserved memory
regions, regulators, PMIC GPIOs, PON keys, and UFS configuration.

> diff --git a/arch/arm64/boot/dts/qcom/sm8250-oneplus-common.dtsi b/arch/arm64/boot/dts/qcom/sm8250-oneplus-common.dtsi
> new file mode 100644
> index 0000000000000..6d7793c792f05
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/sm8250-oneplus-common.dtsi
> @@ -0,0 +1,607 @@

[ ... ]

> +	gpio_keys: gpio-keys {
> +		compatible = "gpio-keys";
> +		label = "Volume keys";
> +
> +		pinctrl-0 = <&vol_down_l &vol_up_n>;
> +		pinctrl-names = "default";
> +
> +		key-vol-down {
> +			label = "Volume Down";
> +			linux,code = <KEY_VOLUMEDOWN>;
> +			gpios = <&pm8150_gpios 7 GPIO_ACTIVE_LOW>;
> +			debounce-interval = <15>;
> +			linux,can-disable;
> +			wakeup-source;
> +		};
> +
> +		key-vol-up {
> +			label = "Volume Up";
> +			gpios = <&pm8150_gpios 6 GPIO_ACTIVE_LOW>;
> +			linux,code = <KEY_VOLUMEUP>;
> +			debounce-interval = <15>;
> +			linux,can-disable;
> +			wakeup-source;
> +		};
> +	};

[ ... ]

> +&pm8150_gpios {
> +	vol_up_n: vol-up-n-state {
> +		pins = "gpio6";
> +		function = "normal";
> +		power-source = <1>;
> +		input-enable;
> +		bias-pull-up;
> +	};
> +
> +	vol_down_l: vol-down-l-state {
> +		pins = "gpio7";
> +		function = "normal";
> +		power-source = <1>;
> +		input-enable;
> +		bias-pull-up;
> +	};
> +};
> +
> +&pon {
> +	mode-bootloader = <0x2>;
> +	mode-recovery = <0x1>;
> +};
> +
> +&pon_pwrkey {
> +	status = "okay";
> +};
> +
> +&pon_resin {
> +	linux,code = <KEY_VOLUMEDOWN>;
> +
> +	status = "okay";
> +};

[Severity: Medium]
Should KEY_VOLUMEDOWN be registered in both gpio_keys (via key-vol-down
on pm8150_gpios 7) and pon_resin?

With both nodes enabled, both the gpio-keys driver and the pm8941-pwrkey
driver probe and register active wakeup-capable input devices for
KEY_VOLUMEDOWN. Depending on how the physical button is wired on these
boards, wouldn't this either emit duplicate KEY_VOLUMEDOWN events across
two separate input devices on every button press, or leave one of the two
input drivers monitoring an unconnected or wrong PMIC pin?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261017-kebab_dts-v3-0-5fc3ca52a383@fhannenheim.net?part=2