From: sashiko-bot@kernel.org
To: "Marek Vasut" <marek.vasut+renesas@mailbox.org>,
linux-pci@vger.kernel.org
Subject: Re: [PATCH] PCI: rcar-host: Free MSI IRQs on error
Date: Sat, 17 Oct 2026 17:24:28 +0000 [thread overview]
Message-ID: <sashiko-outbox-175701@kernel.org> (raw)
In-Reply-To: <20261017172122.225861-1-marek.vasut+renesas@mailbox.org>
> The rcar_pcie_get_resources() calls irq_of_parse_and_map() on both IRQs.
> The rcar_pcie_enable_msi() called afterward calls devm_request_irq() on
> both IRQs. In case a failure occurs after rcar_pcie_enable_msi() was
> already called, the invocation of irq_dispose_mapping() on those two
> IRQs triggers a WARNING:
>
> remove_proc_entry: removing non-empty directory 'irq/96', leaking at least 'R-Car MSI'
>
> Fix this by calling devm_free_irq() on those two IRQs before invocation
> of irq_dispose_mapping(), this way the IRQ is free'd before it is
> unmapped. Fix matching issue in rcar_pcie_enable_msi() fail path too.
>
> Fixes: 290c1fb35860 ("PCI: rcar: Add MSI support for PCIe")
> Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261017172122.225861-1-marek.vasut+renesas@mailbox.org?part=1
prev parent reply other threads:[~2026-10-17 17:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-17 17:20 [PATCH] PCI: rcar-host: Free MSI IRQs on error Marek Vasut
2026-10-17 17:24 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-175701@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=marek.vasut+renesas@mailbox.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.