Re: [PATCH] usb: phy: gpio-vbus: disable VBUS work during removal

[sashiko-bot@kernel.org]

> Legacy users such as PXA UDC obtain this PHY through usb_get_phy(),
> which does not create a supplier device link. A sysfs unbind of the PHY
> can therefore run while the gadget consumer remains bound.
> 
> The VBUS IRQ remains registered until devres cleanup, after
> gpio_vbus_remove() returns. With the gadget still registered, an IRQ
> after cancel_delayed_work_sync() returns can queue another instance of
> the delayed work. The 100 ms delay lets devres release the GPIO, OTG and
> driver state before that instance runs.
> 
> Disable and drain the delayed work during removal so late IRQs cannot
> queue it again. This also rejects work queued by set_peripheral(), which
> calls the IRQ handler directly. The managed IRQ is released before the
> GPIO and driver state accessed by its handler are freed.
> 
> This issue was identified as part of our ongoing research while
> reviewing kernel code.
> 
> Fixes: c2344f13b59e ("USB: gpio_vbus: add delayed vbus_session calls")
> Co-developed-by: Ijae Kim <ae878000@gmail.com>
> Signed-off-by: Ijae Kim <ae878000@gmail.com>
> Signed-off-by: Myeonghun Pak <mhun512@gmail.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/179229341073.3942822.17212567068599854952.gpio-vbus@gmail.com?part=1