Re: [PATCH v3 02/21] ASoC: dt-bindings: cs42l42: Document additional dai-common properties

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] ASoC: dt-bindings: cs42l42: unconstrained #sound-dai-cells property
--

commit 41e0b44d1b55811c2f6af66b07ffb649188a35d3
Author: James Calligeros <jcalligeros99@gmail.com>

ASoC: dt-bindings: cs42l42: Document additional dai-common properties

This patch references dai-common.yaml# and documents #sound-dai-cells
and sound-name-prefix in the cirrus,cs42l42.yaml device tree binding.

> diff --git a/Documentation/devicetree/bindings/sound/cirrus,cs42l42.yaml b/Documentation/devicetree/bindings/sound/cirrus,cs42l42.yaml
> index ab4c7d22dc0eb..aba2121ac64a7 100644
> --- a/Documentation/devicetree/bindings/sound/cirrus,cs42l42.yaml
> +++ b/Documentation/devicetree/bindings/sound/cirrus,cs42l42.yaml
> @@ -9,6 +9,9 @@ title: Cirrus Logic CS42L42 audio CODEC
>  maintainers:
>    - patches@opensource.cirrus.com
>  
> +allOf:
> +  - $ref: dai-common.yaml#
> +
>  description:
>    The CS42L42 is a low-power audio codec designed for portable applications.
>    It provides a high-dynamic range, stereo DAC for audio playback and a mono
> @@ -26,6 +29,10 @@ properties:
>        The I2C address of the CS42L42.
>      maxItems: 1
>  
> +  '#sound-dai-cells': true
> +
> +  sound-name-prefix: true
> +

[Severity: Low]
Should '#sound-dai-cells' be constrained to const: 0 here instead of true?

In Documentation/devicetree/bindings/sound/dai-common.yaml,
'#sound-dai-cells': true is a generic placeholder, and referencing codec
schemas normally constrain the cell count to match the hardware.

In sound/soc/codecs/cs42l42.c, cs42l42_common_probe() registers a single
DAI without a custom .of_xlate_dai_name callback:

    ret = devm_snd_soc_register_component(cs42l42->dev, component_drv, dai, 1);

Leaving '#sound-dai-cells' as true allows non-zero cell counts in device
tree nodes to pass schema validation while failing at runtime during
ASoC DAI phandle resolution.

Also, if additionalProperties: false at the bottom of
Documentation/devicetree/bindings/sound/cirrus,cs42l42.yaml is changed
to unevaluatedProperties: false when referencing dai-common.yaml# in
allOf, would that avoid needing to list sound-name-prefix: true here?

>    VP-supply:
>      description:
>        VP power supply.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261018-macaudio-v3-0-abdff7741dea@gmail.com?part=2