Re: [RFC PATCH 4/5] perf/tests: convert check_all_lines_matched.pl to Python

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] perf tests: check_all_lines_matched.py is never wired up or installed
--

commit d9f6b313408b62305572a2fb532ed1583f0179f7
Author: Breno Rodrigues Alves <breno3011alves@gmail.com>

perf/tests: convert check_all_lines_matched.pl to Python

This commit adds a Python 3 implementation of
tools/perf/tests/shell/common/check_all_lines_matched.pl.

> diff --git a/tools/perf/tests/shell/common/check_all_lines_matched.py b/tools/perf/tests/shell/common/check_all_lines_matched.py
> new file mode 100755
> index 0000000000000..352a56d8b9809
> --- /dev/null
> +++ b/tools/perf/tests/shell/common/check_all_lines_matched.py
> @@ -0,0 +1,45 @@
> +#!/usr/bin/env python3
> +# SPDX-License-Identifier: GPL-2.0
> +
> +import os
> +import re
> +import sys
> +
> +
> +def main(argv):

[Severity: Medium]
Should this commit also update the existing callers and installation rules,
and remove tools/perf/tests/shell/common/check_all_lines_matched.pl?

Currently, check_all_lines_matched.py is added, but the shell test scripts
still invoke check_all_lines_matched.pl (which is also not updated in the
subsequent commit f4ac81889a75 in this series):

tools/perf/tests/shell/base_probe/test_adding_blacklisted.sh:
		"$DIR_PATH/../common/check_all_lines_matched.pl" \
			"$REGEX_SKIP_MESSAGE" "$REGEX_NOT_FOUND_MESSAGE" \

tools/perf/tests/shell/base_probe/test_adding_kernel.sh:
"$DIR_PATH/../common/check_all_lines_matched.pl" \
	"$RE_LINE_EMPTY" "List of pre-defined events" \

tools/perf/tests/shell/base_report/test_basic.sh:
grep -P -v '^#' $LOGS_DIR/basic_pid.log | grep -P '\s+[\d\.]+%' | \
	"$DIR_PATH/../common/check_all_lines_matched.pl" "systemd|init"

In addition, the install-tests target in tools/perf/Makefile.perf only
installs *.sh and *.pl files from tests/shell/common, omitting *.py:

tools/perf/Makefile.perf:
		$(INSTALL) tests/shell/common/*.sh '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/tests/shell/common'; \
		$(INSTALL) tests/shell/common/*.pl '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/tests/shell/common'; \

[ ... ]

> +if __name__ == "__main__":
> +    sys.exit(main(sys.argv[1:]))
> \ No newline at end of file

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261018125641.23064-1-breno3011alves@gmail.com?part=4