Re: [PATCH v9 1/8] HID: topping: transport for the M62's vendor controls

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] HID: topping: missing pm_ptr() on topping_driver PM callbacks
--

commit cefe32a6b81c6b7ed6128d273a5c5c6a50f7896a
Author: Mikhail Gavrilov <mikhail.v.gavrilov@gmail.com>

HID: topping: transport for the M62's vendor controls

This commit adds a HID transport driver for the Topping M62 USB audio
interface's vendor control protocol, connecting to snd-usb-audio via the
component framework.

> diff --git a/drivers/hid/hid-topping.c b/drivers/hid/hid-topping.c
> new file mode 100644
> index 0000000000000..a8854b2d15306
> --- /dev/null
> +++ b/drivers/hid/hid-topping.c
> @@ -0,0 +1,498 @@

[ ... ]

> +static struct hid_driver topping_driver = {
> +	.name		= "topping",
> +	.id_table	= topping_devices,
> +	.probe		= topping_probe,
> +	.remove		= topping_remove,
> +	.raw_event	= topping_raw_event,
> +	.suspend	= topping_suspend,
> +	.resume		= topping_resume,
> +	.reset_resume	= topping_resume,
> +};
> +module_hid_driver(topping_driver);

[Severity: Low]
In drivers/hid/hid-core.c, hid_driver_suspend(), hid_driver_resume(), and
hid_driver_reset_resume() are only built when CONFIG_PM is enabled:

drivers/hid/hid-core.c:
#ifdef CONFIG_PM
int hid_driver_suspend(struct hid_device *hdev, pm_message_t state)
{
	if (hdev->driver && hdev->driver->suspend)
		return hdev->driver->suspend(hdev, state);

	return 0;
}

Should .suspend, .resume, and .reset_resume in topping_driver be wrapped
with pm_ptr() so that topping_suspend() and topping_resume() can be
eliminated by the compiler when CONFIG_PM is disabled?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261018124838.129349-1-mikhail.v.gavrilov@gmail.com?part=1