Re: [PATCH v13 3/3] rtc: Add Raspberry Pi 5 RTC driver

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] rtc: Kconfig RTC_DRV_RPI depends on non-existent ARCH_BRCM2835 symbol
--

commit a6bed19cc6f6abde9685896060e26f766fe6119a
Author: Sander Speetjens <sander.speetjens@gmail.com>

rtc: Add Raspberry Pi 5 RTC driver

This commit adds an RTC driver for the Raspberry Pi 5 custom DA9091 RTC,
accessed via the Raspberry Pi firmware mailbox interface.

> diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
> index 05b9233b94189..b4ed5ebea11a1 100644
> --- a/drivers/rtc/Kconfig
> +++ b/drivers/rtc/Kconfig
> @@ -1999,6 +1999,18 @@ config RTC_DRV_R7301
>  	   This driver can also be built as a module. If so, the module
>  	   will be called rtc-r7301.
>  
> +config RTC_DRV_RPI
> +	tristate "Raspberry Pi RTC"
> +	depends on RASPBERRYPI_FIRMWARE || (COMPILE_TEST && !RASPBERRYPI_FIRMWARE)
> +	depends on ARCH_BRCM2835 || COMPILE_TEST
> +	default ARCH_BRCM2835

[Severity: High]
Should ARCH_BRCM2835 be ARCH_BCM2835 here?

No Kconfig symbol named ARCH_BRCM2835 exists in the tree; the platform
symbol defined in arch/arm64/Kconfig.platforms and used by
config RASPBERRYPI_FIRMWARE in drivers/firmware/Kconfig is ARCH_BCM2835:

	depends on ARCH_BCM2835 || COMPILE_TEST
	depends on BCM2835_MBOX
	default ARCH_BCM2835

Because ARCH_BRCM2835 is undefined, Kconfig evaluates it as n, preventing
RTC_DRV_RPI from being selected or defaulted on Raspberry Pi builds unless
COMPILE_TEST is enabled.

> +	help
> +	  If you say yes here you get support for the RTC found on
> +	  Raspberry Pi 5th gen devices.
> +
> +	  This driver can also be built as a module. If so, the module
> +	  will be called rtc-raspberrypi.
> +
>  config RTC_DRV_STM32
>  	tristate "STM32 RTC"
>  	select REGMAP_MMIO

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261018150028.1047172-1-sander.speetjens@gmail.com?part=3