All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Prashant Sengar" <prashantsengar25031@gmail.com>
Cc: linux-usb@vger.kernel.org
Subject: Re: [PATCH net] net: usb: lan78xx: avoid NULL PHY dereference in WoL setup
Date: Sun, 18 Oct 2026 15:24:23 +0000	[thread overview]
Message-ID: <sashiko-outbox-176234@kernel.org> (raw)
In-Reply-To: <20261018151830.643511-1-prashantsengar25031@gmail.com>

> LAN7801 supports fixed-link configurations without an attached PHY.
> However, lan78xx_set_wol() unconditionally passes netdev->phydev
> to phy_ethtool_set_wol(), which dereferences the missing PHY.
> 
> Only call the PHY Wake-on-LAN helper when a PHY is attached.
> 
> The issue was reproduced with USB Raw Gadget and dummy_hcd in QEMU.
> The unmodified driver triggered a NULL pointer dereference.
> With this change, the same ioctl completes successfully.
> 
> Fixes: e110bc825897 ("net: usb: lan78xx: Convert to PHYLINK for improved PHY and MAC management")
> 
> Signed-off-by: Prashant Sengar <prashantsengar25031@gmail.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261018151830.643511-1-prashantsengar25031@gmail.com?part=1


  reply	other threads:[~2026-10-18 15:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-18 15:18 [PATCH net] net: usb: lan78xx: avoid NULL PHY dereference in WoL setup Prashant Sengar
2026-10-18 15:24 ` sashiko-bot [this message]
2026-10-18 16:21 ` Andrew Lunn
2026-10-19 15:20 ` netdev-bot+sashiko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-176234@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=prashantsengar25031@gmail.com \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.