From: sashiko-bot@kernel.org
To: "Pasha Tatashin" <pasha.tatashin@soleen.com>,
rppt@kernel.org, kuba@kernel.org, enelsonmoore@gmail.com,
bp@alien8.de, shuah@kernel.org, david@kernel.org,
akpm@linux-foundation.org, ljs@kernel.org, mhocko@suse.com,
skhan@linuxfoundation.org, vbabka@kernel.org,
dapeng1.mi@linux.intel.com, corbet@lwn.net, surenb@google.com,
kexec@lists.infradead.org, pratyush@kernel.org,
rdunlap@infradead.org, elver@google.com, graf@amazon.com,
lirongqing@baidu.com, liam@infradead.org, jlayton@kernel.org
Subject: Re: [PATCH v1 4/8] kho: do not modify incoming serialized blocks
Date: Mon, 19 Oct 2026 02:18:54 +0000 [thread overview]
Message-ID: <sashiko-outbox-176521@kernel.org> (raw)
In-Reply-To: <20261019021111.990394-5-pasha.tatashin@soleen.com>
> When restoring an incoming block set via kho_block_set_restore(), the
> physical chain of blocks is already linked and bs->head_pa is already
> set. However, kho_block_add() unconditionally rewrites last->ser->next
> and bs->head_pa, and kho_block_set_shrink_one() clears
> new_last->ser->next even when operating on an incoming block set.
>
> In the upcoming KHO read-only mode, incoming serialized blocks are
> mapped read-only and must not be modified. Guard the ser->next and
> bs->head_pa updates in kho_block_add() and kho_block_set_shrink_one()
> with !bs->incoming.
>
> Signed-off-by: Pasha Tatashin <pasha.tatashin@soleen.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261019021111.990394-1-pasha.tatashin@soleen.com?part=4
next prev parent reply other threads:[~2026-10-19 2:18 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-19 2:11 [PATCH v1 0/8] kho: add read-only Kexec Handover mode Pasha Tatashin
2026-10-19 2:11 ` [PATCH v1 1/8] kho: expose physical address of outgoing FDT Pasha Tatashin
2026-10-19 2:18 ` sashiko-bot
2026-10-19 2:11 ` [PATCH v1 2/8] kho: move radix tree, vmalloc, and FDT helpers to internal header Pasha Tatashin
2026-10-19 2:18 ` sashiko-bot
2026-10-19 2:11 ` [PATCH v1 3/8] kho: validate preservation metadata in kho_restore_vmalloc() Pasha Tatashin
2026-10-19 2:18 ` sashiko-bot
2026-10-19 2:11 ` [PATCH v1 4/8] kho: do not modify incoming serialized blocks Pasha Tatashin
2026-10-19 2:18 ` sashiko-bot [this message]
2026-10-19 2:11 ` [PATCH v1 5/8] kho: add read-only Kexec Handover mode Pasha Tatashin
2026-10-19 2:18 ` sashiko-bot
2026-10-19 2:11 ` [PATCH v1 6/8] kho: support read-only KHO mode in kho_block Pasha Tatashin
2026-10-19 2:18 ` sashiko-bot
2026-10-19 2:11 ` [PATCH v1 7/8] kho: test: support read-only KHO mode in test_kho Pasha Tatashin
2026-10-19 2:19 ` sashiko-bot
2026-10-19 2:11 ` [PATCH v1 8/8] selftests: kho: add read-only KHO test to vmtest.sh Pasha Tatashin
2026-10-19 2:19 ` sashiko-bot
2026-10-19 8:43 ` [PATCH v1 0/8] kho: add read-only Kexec Handover mode Mike Rapoport
2026-10-19 14:23 ` Pasha Tatashin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-176521@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=corbet@lwn.net \
--cc=dapeng1.mi@linux.intel.com \
--cc=david@kernel.org \
--cc=elver@google.com \
--cc=enelsonmoore@gmail.com \
--cc=graf@amazon.com \
--cc=jlayton@kernel.org \
--cc=kexec@lists.infradead.org \
--cc=kuba@kernel.org \
--cc=liam@infradead.org \
--cc=lirongqing@baidu.com \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
--cc=pasha.tatashin@soleen.com \
--cc=pratyush@kernel.org \
--cc=rdunlap@infradead.org \
--cc=rppt@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.