Re: [RFC PATCH] dt-bindings: timer: renesas,tmu: add SH7305 compatible

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] dt-bindings: timer: renesas,tmu: missing sh7305 in resets conditional
- [Low] dt-bindings: timer: renesas,tmu: inconsistent sh7305 compatible naming
--

commit 5a47059b449e5e852ab342ee0c095fa0177a28ca
Author: Artem Novak <artem122novak@gmail.com>

dt-bindings: timer: renesas,tmu: add SH7305 compatible

This commit adds a compatible string for the Renesas SH7305 three-channel
Timer Unit (TMU) to the Renesas TMU Device Tree binding.

> diff --git a/Documentation/devicetree/bindings/timer/renesas,tmu.yaml b/Documentation/devicetree/bindings/timer/renesas,tmu.yaml
> index b1229595acfbf..8ecc57cc3d917 100644
> --- a/Documentation/devicetree/bindings/timer/renesas,tmu.yaml
> +++ b/Documentation/devicetree/bindings/timer/renesas,tmu.yaml
> @@ -21,6 +21,7 @@ properties:
>    compatible:
>      items:
>        - enum:
> +          - renesas,sh7305-tmu  # SH7305
>            - renesas,tmu-r8a73a4  # R-Mobile APE6
>            - renesas,tmu-r8a7740  # R-Mobile A1
>            - renesas,tmu-r8a7742  # RZ/G1H

[Severity: Medium]
Does SH7305 also need to be added to the conditional exclusion list for
resets (and potentially power-domains) later in
Documentation/devicetree/bindings/timer/renesas,tmu.yaml?

In this binding, power-domains is listed unconditionally under required, and
resets is required for all compatibles not explicitly exempted in the
if/then block:

  required:
    - compatible
    - reg
    - interrupts
    - interrupt-names
    - clocks
    - clock-names
    - power-domains

  if:
    not:
      properties:
        compatible:
          contains:
            enum:
              - renesas,tmu-r8a73a4
              - renesas,tmu-r8a7740
              - renesas,tmu-r8a7778
              - renesas,tmu-r8a7779
  then:
    required:
      - resets

That enum exempts older R-Mobile and R-Car Gen1 SoCs whose clock controllers
lack per-module reset control for the TMU. Since SH7305 is an older SuperH
(SH-4A / SH4AL-DSP) SoC without a per-module reset controller for the TMU,
won't omitting the SH7305 compatible from this exclusion list cause
dt_binding_check / dtbs_check validation to fail on SH7305 TMU nodes that do
not specify resets?

[Severity: Low]
Should this compatible string be named renesas,tmu-sh7305 and sorted
alphabetically after renesas,tmu-r8a779h0 instead of renesas,sh7305-tmu?

Documentation/devicetree/bindings/soc/renesas/renesas-soc.yaml states in its
description:

  When adding new compatibles to existing bindings, use the format in the
  existing binding, even if it contradicts the above.

Every existing SoC-specific entry in
Documentation/devicetree/bindings/timer/renesas,tmu.yaml uses the
renesas,tmu-<soc> format (from renesas,tmu-r8a73a4 through
renesas,tmu-r8a779h0).

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261019022717.511096-1-artem122novak@gmail.com?part=1