From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D2934848A9; Mon, 19 Oct 2026 05:52:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792389215; cv=none; b=Wls4/CJyo3X/nMrCnVC1d43RFLjKNSW59dvsx2GhX+X+JtvE8TfjIrEPYlKOEfigSAkxjmrRHG7+6qzaFwv4aI/6gipIvXf3/Ys1nhXXO8d2lfCP2Me5IyOeWPWGFwV2hbp1YIr6U48Jo6iz/fu7j/3i+VzsyZiUmLCQgBl4jOM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792389215; c=relaxed/simple; bh=Odbrb2g/txfb1JtG5kb/n0FRk7MR1WMWlgdmU0jJ1X0=; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type: Date; b=c5kXSHEhRd1lToyLMyjL8lzfG13jDQT1TSeq301Ku3yhAKEos0sTqqDFGCpE+YeDo5YLcGQVecfrpZyCZkfRkZwgEuzIgMLy6moKWx9Pq443306eXznzUE0u/xmxu+/PLe5PPntp9rNkh0pPaxlUDEjJREMG6F4C6hhwtc3eAdY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=OFYMXqBa; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="OFYMXqBa" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7193A1F000C5; Mon, 19 Oct 2026 05:52:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1792389127; bh=rkza5uVRf34cN3QyerCAeal95ev4k8kEa3sElA7jHBE=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=OFYMXqBanYhuS4CFmXxh8oVGz7ZlxTDx99/nflQfpNGVEaiEVutaAGucoj/4rUSL2 rz3hIzTqv1ClPFoQ882yy3Wx7us2HvNYAyOShCcD/kLMDH76WsMRQLYpQEY5MrT0bJ r9HSi4bTDPBje+MLoTf5XG4fGZmllMDFpLiQk7u9F7Sjqxot97R1iea3ozk4lcZybZ BUfQEK+TsjcAgmMbIAlLbZ6MURi5H/GuBzyMBSGgapvI3Jkm4WBsb87Wj6bmqYZ5de vWlvBqNAAkslUahxpbivyXgSpCslTlVD1ZKkF69u2OoTmCg8anOfBfKVfOyxC+YfWI rwbKUfSsqLf0A== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH 3/3] i3c: master: svc: Add Amlogic A9 glue layer Reply-To: sashiko-reviews@lists.linux.dev To: "Junyi Zhao" Cc: linux-i3c@lists.infradead.org, devicetree@vger.kernel.org, linux-amlogic@lists.infradead.org, imx@lists.linux.dev, robh@kernel.org, conor+dt@kernel.org, Frank.Li@kernel.org, neil.armstrong@linaro.org, "Alexandre Belloni" In-Reply-To: <20261019-a9_i3c-v1-3-329d819d621f@amlogic.com> References: <20261019-a9_i3c-v1-0-329d819d621f@amlogic.com> <20261019-a9_i3c-v1-3-329d819d621f@amlogic.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Mon, 19 Oct 2026 05:52:07 +0000 Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 4 potential issue(= s) to consider: - [High] i3c: master: svc: broken probe deferral in amlogic_i3c_probe() - [Medium] i3c: master: svc: clock enable leak in amlogic_i3c_remove() - [Medium] i3c: master: svc: i3c-amlogic: missing I3C_AO_FCLK_DIV_CTRL rest= ore on resume - [Medium] i3c: master: svc: incorrect fclk rate and divider math in amlogi= c_i3c_probe() -- commit cf70cd7b59395de84561d30a5e3b3862aa275ac4 Author: Junyi Zhao i3c: master: svc: Add Amlogic A9 glue layer This commit adds an Amlogic A9 glue driver for the Silvaco SVC I3C controller, providing Amlogic-specific clock and runtime PM handling while reusing the common SVC I3C core driver. > diff --git a/drivers/i3c/master/svc/i3c-amlogic.c b/drivers/i3c/master/sv= c/i3c-amlogic.c > new file mode 100644 > index 0000000000000..82300d6ae5a31 > --- /dev/null > +++ b/drivers/i3c/master/svc/i3c-amlogic.c > @@ -0,0 +1,250 @@ [ ... ] > +static int default_i3c_fclk_rate_init(struct svc_i3c_master *master, > + struct clk *fclk, unsigned long rate) > +{ > + int err; > + > + err =3D clk_set_rate(fclk, rate); > + if (err) > + return dev_err_probe(master->dev, err, > + "setting fast clock rate failed\n"); > + > + return 0; > +} > + > +static int ao_i3c_fclk_rate_init(struct svc_i3c_master *master, > + struct clk *fclk, unsigned long rate) > +{ > + unsigned int div_cnt, reg_val; > + unsigned long fin_freq =3D clk_get_rate(fclk); > + > + if (!fin_freq) > + return dev_err_probe(master->dev, -EINVAL, > + "can't get I3C fast clock rate\n"); > + > + div_cnt =3D div64_u64(fin_freq, rate); > + if (!div_cnt || div_cnt > I3C_AO_FCLK_DIV_MASK) > + return dev_err_probe(master->dev, -EINVAL, > + "requested fast clock frequency too low\n"); > + > + reg_val =3D I3C_AO_FCLK_DIV_EN | I3C_AO_FCLK_EN | (div_cnt - 1); > + writel(reg_val, master->regs + I3C_AO_FCLK_DIV_CTRL); > + > + return 0; > +} > + > +static int amlogic_i3c_probe(struct platform_device *pdev) > +{ > + struct device *dev =3D &pdev->dev; > + const struct amlogic_i3c_drvdata *data; > + struct svc_i3c_master *master; > + struct amlogic_i3c_priv *priv; > + struct clk *fclk; > + int ret, i; [ ... ] > + priv->num_clks =3D devm_clk_bulk_get_all(dev, &priv->clks); > + if (priv->num_clks < 0) > + return dev_err_probe(dev, -EINVAL, "can't get I3C clocks\n"); [Severity: High] Should amlogic_i3c_probe() pass priv->num_clks instead of -EINVAL to dev_err_probe() here? When devm_clk_bulk_get_all() returns -EPROBE_DEFER because the clock controller has not probed yet, passing a hardcoded -EINVAL causes dev_err_probe() to log an error and abort probing permanently instead of deferring. > + > + for (i =3D 0; i < priv->num_clks; i++) { > + if (!strcmp(priv->clks[i].id, "fast_clk")) > + break; > + } > + > + if (i =3D=3D priv->num_clks) > + return dev_err_probe(dev, -EINVAL, > + "can't get I3C peripheral clock\n"); > + > + if (IS_ERR(priv->clks[i].clk)) > + return PTR_ERR(priv->clks[i].clk); > + fclk =3D priv->clks[i].clk; > + > + ret =3D clk_bulk_prepare_enable(priv->num_clks, priv->clks); > + if (ret) > + return dev_err_probe(dev, ret, "can't enable I3C clocks\n"); > + > + master->dev =3D dev; > + master->bsp_priv =3D priv; > + ret =3D data->fclk_rate_init(master, fclk, I3C_DEFAULT_FCLK_RATE); > + if (ret) > + goto err_disable_clks; > + master->fclk_rate =3D I3C_DEFAULT_FCLK_RATE; [Severity: Medium] Can the divider math in ao_i3c_fclk_rate_init() and the hardcoded master->fclk_rate assignment in amlogic_i3c_probe() fail probe on a 24 MHz input clock or produce an inaccurate fclk_rate? In ao_i3c_fclk_rate_init(), div_cnt =3D div64_u64(fin_freq, rate) truncates= via integer division: 1. For the Always-On I3C controller, fast_clk is a9_ao_sys_i3c, which is gated from a9_ao_sys (muxed between the 24 MHz ao_xtal and sys). When fin_freq is 24 MHz, div64_u64(24000000, 25000000) evaluates to 0, causing ao_i3c_fclk_rate_init() to fail probe with -EINVAL. 2. When fin_freq is not an exact multiple of 25 MHz (for example, a 166.67 MHz sys clock), div64_u64(fin_freq, rate) truncates down to 6, configuring I3C_AO_FCLK_DIV_CTRL for 27.78 MHz while master->fclk_rate is hardcoded to I3C_DEFAULT_FCLK_RATE (25 MHz). Similarly, in default_i3c_fclk_rate_init(), clk_set_rate() rounds to the closest rate supported by the clock tree rather than guaranteeing 25 MHz. When the actual clock rate exceeds 25 MHz, svc_i3c_master_bus_init() and svc_i3c_master_set_speed() compute ppbaud, odbaud, and i2cbaud assuming 25 MHz, which can drive push-pull SCL above the 12.5 MHz MIPI I3C limit. 3. Because (div_cnt - 1) is written into the 8-bit I3C_AO_FCLK_DIV_MASK fie= ld (GENMASK(7, 0)), the maximum supported divider is I3C_AO_FCLK_DIV_MASK += 1 (256), so checking div_cnt > I3C_AO_FCLK_DIV_MASK is off by one. Should ao_i3c_fclk_rate_init() round the divider up (for example with DIV_ROUND_UP_ULL) and update master->fclk_rate to the actual divided or queried clock rate? > + > + pm_runtime_set_autosuspend_delay(dev, SVC_I3C_PM_TIMEOUT_MS); > + pm_runtime_use_autosuspend(dev); > + pm_runtime_get_noresume(dev); > + pm_runtime_set_active(dev); > + pm_runtime_enable(dev); [ ... ] > +static void amlogic_i3c_remove(struct platform_device *pdev) > +{ > + struct svc_i3c_master *master =3D platform_get_drvdata(pdev); > + > + svc_i3c_master_remove(master); > + > + pm_runtime_dont_use_autosuspend(&pdev->dev); > + pm_runtime_disable(&pdev->dev); > +} [Severity: Medium] Does amlogic_i3c_remove() leak clock prepare and enable references on priv->clks when the device is still active at removal time? In amlogic_i3c_probe(), clocks are acquired via devm_clk_bulk_get_all() and manually enabled with clk_bulk_prepare_enable(priv->num_clks, priv->clks). During removal, svc_i3c_master_remove() calls i3c_master_unregister()->svc_i3c_master_bus_cleanup(), which resumes the device via pm_runtime_resume_and_get() and calls pm_runtime_put_autosuspend(). If CONFIG_PM is disabled (where runtime PM helpers are no-ops), or if runti= me suspend is prevented at removal time (for example via sysfs power/control or because svc_i3c_master_enable_hotjoin() incremented master->dev's runtime PM usage count without a matching put in svc_i3c_master_remove()), pm_runtime_dont_use_autosuspend() will not invoke amlogic_i3c_runtime_suspend(). Should amlogic_i3c_remove() check !pm_runtime_status_suspended(&pdev->dev) after pm_runtime_disable(&pdev->dev) and call clk_bulk_disable_unprepare() and pm_runtime_set_suspended(&pdev->dev)? > + > +static int __maybe_unused amlogic_i3c_runtime_suspend(struct device *dev) > +{ > + struct svc_i3c_master *master =3D dev_get_drvdata(dev); > + struct amlogic_i3c_priv *priv =3D master->bsp_priv; > + > + svc_i3c_save_regs(master); > + clk_bulk_disable_unprepare(priv->num_clks, priv->clks); > + pinctrl_pm_select_sleep_state(dev); > + > + return 0; > +} > + > +static int __maybe_unused amlogic_i3c_runtime_resume(struct device *dev) > +{ > + struct svc_i3c_master *master =3D dev_get_drvdata(dev); > + struct amlogic_i3c_priv *priv =3D master->bsp_priv; > + int ret; > + > + pinctrl_pm_select_default_state(dev); > + ret =3D clk_bulk_prepare_enable(priv->num_clks, priv->clks); > + if (ret) > + return ret; > + > + svc_i3c_restore_regs(master); > + > + return 0; > +} [Severity: Medium] On "amlogic,i3c-ao-a9" devices, can I3C_AO_FCLK_DIV_CTRL lose its configuration across suspend and resume? During probe, ao_i3c_fclk_rate_init() writes I3C_AO_FCLK_DIV_EN, I3C_AO_FCLK_EN, and the divider into master->regs + I3C_AO_FCLK_DIV_CTRL. When suspending and resuming via amlogic_i3c_runtime_suspend() and amlogic_i3c_runtime_resume() (which are also used for system sleep via pm_runtime_force_suspend() and pm_runtime_force_resume()), svc_i3c_save_regs() and svc_i3c_restore_regs() only save and restore SVC_I3C_MCONFIG and SVC_I3C_MDYNADDR. If the controller loses register state during suspend or hibernation, wouldn't I3C_AO_FCLK_DIV_CTRL remain unconfigured on resume unless it is saved and restored or re-initialized? [ ... ] > --=20 > 2.47.3 --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261019-a9_i3c-v1-= 0-329d819d621f@amlogic.com?part=3D3 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 202F5CCF2D3 for ; Mon, 19 Oct 2026 05:52:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Date:References: In-Reply-To:Cc:To:Subject:From:Message-ID:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xwXYydMflgrZJ7Z0xK1W00kgWSSOzLLoqsJ5tuAbDro=; b=gaLV/N0OdrDmHP ZQANINBG0G7tjdDnqhhCiERePz++VoV6GS0PzGrGYdWa2XpoWcpHN9Gne4jNWOOg10krBrGze0oIM VYtjT0tD+/40cA37x1SpaTAMYzeCQUY7Vzo+8dUnGlwOQBcFk2VYv2yqfdGd4yHmnsfcY3A3kuCVo HwSYFfExHXfrIdsnmTQqI5mPgqntCfrHquzkiowgS9z9A5kKTz/qLUpeUIEODPcUh1wPGEQSU0FRR N2T1jO6TPt9a63rjMnP6LN1wHlyxzheH7eEP3nPcIUwt0VTApHq/uFtcypAa1ChgKfsNeO9Jb8acN yN4ygZh+PSgyLdZi8C6Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xIgI9-00000006eyl-3IMG; Mon, 19 Oct 2026 05:52:13 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xIgI6-00000006eyT-115T; Mon, 19 Oct 2026 05:52:10 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 1F0AE600CB; Mon, 19 Oct 2026 05:52:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7193A1F000C5; Mon, 19 Oct 2026 05:52:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1792389127; bh=rkza5uVRf34cN3QyerCAeal95ev4k8kEa3sElA7jHBE=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=OFYMXqBanYhuS4CFmXxh8oVGz7ZlxTDx99/nflQfpNGVEaiEVutaAGucoj/4rUSL2 rz3hIzTqv1ClPFoQ882yy3Wx7us2HvNYAyOShCcD/kLMDH76WsMRQLYpQEY5MrT0bJ r9HSi4bTDPBje+MLoTf5XG4fGZmllMDFpLiQk7u9F7Sjqxot97R1iea3ozk4lcZybZ BUfQEK+TsjcAgmMbIAlLbZ6MURi5H/GuBzyMBSGgapvI3Jkm4WBsb87Wj6bmqYZ5de vWlvBqNAAkslUahxpbivyXgSpCslTlVD1ZKkF69u2OoTmCg8anOfBfKVfOyxC+YfWI rwbKUfSsqLf0A== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH 3/3] i3c: master: svc: Add Amlogic A9 glue layer To: "Junyi Zhao" Cc: linux-i3c@lists.infradead.org, devicetree@vger.kernel.org, linux-amlogic@lists.infradead.org, imx@lists.linux.dev, robh@kernel.org, conor+dt@kernel.org, Frank.Li@kernel.org, neil.armstrong@linaro.org, "Alexandre Belloni" In-Reply-To: <20261019-a9_i3c-v1-3-329d819d621f@amlogic.com> References: <20261019-a9_i3c-v1-0-329d819d621f@amlogic.com> <20261019-a9_i3c-v1-3-329d819d621f@amlogic.com> Date: Mon, 19 Oct 2026 05:52:07 +0000 X-BeenThere: linux-i3c@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-i3c" Errors-To: linux-i3c-bounces+linux-i3c=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg NCBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW0hpZ2hdIGkzYzogbWFzdGVyOiBz dmM6IGJyb2tlbiBwcm9iZSBkZWZlcnJhbCBpbiBhbWxvZ2ljX2kzY19wcm9iZSgpCi0gW01lZGl1 bV0gaTNjOiBtYXN0ZXI6IHN2YzogY2xvY2sgZW5hYmxlIGxlYWsgaW4gYW1sb2dpY19pM2NfcmVt b3ZlKCkKLSBbTWVkaXVtXSBpM2M6IG1hc3Rlcjogc3ZjOiBpM2MtYW1sb2dpYzogbWlzc2luZyBJ M0NfQU9fRkNMS19ESVZfQ1RSTCByZXN0b3JlIG9uIHJlc3VtZQotIFtNZWRpdW1dIGkzYzogbWFz dGVyOiBzdmM6IGluY29ycmVjdCBmY2xrIHJhdGUgYW5kIGRpdmlkZXIgbWF0aCBpbiBhbWxvZ2lj X2kzY19wcm9iZSgpCi0tCgpjb21taXQgY2Y3MGNkN2I1OTM5NWRlODQ1NjFkMzBhNWUzYjM4NjJh YTI3NWFjNApBdXRob3I6IEp1bnlpIFpoYW8gPGp1bnlpLnpoYW9AYW1sb2dpYy5jb20+CgppM2M6 IG1hc3Rlcjogc3ZjOiBBZGQgQW1sb2dpYyBBOSBnbHVlIGxheWVyCgpUaGlzIGNvbW1pdCBhZGRz IGFuIEFtbG9naWMgQTkgZ2x1ZSBkcml2ZXIgZm9yIHRoZSBTaWx2YWNvIFNWQyBJM0MKY29udHJv bGxlciwgcHJvdmlkaW5nIEFtbG9naWMtc3BlY2lmaWMgY2xvY2sgYW5kIHJ1bnRpbWUgUE0gaGFu ZGxpbmcgd2hpbGUKcmV1c2luZyB0aGUgY29tbW9uIFNWQyBJM0MgY29yZSBkcml2ZXIuCgo+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL2kzYy9tYXN0ZXIvc3ZjL2kzYy1hbWxvZ2ljLmMgYi9kcml2ZXJz L2kzYy9tYXN0ZXIvc3ZjL2kzYy1hbWxvZ2ljLmMKPiBuZXcgZmlsZSBtb2RlIDEwMDY0NAo+IGlu ZGV4IDAwMDAwMDAwMDAwMDAuLjgyMzAwZDZhZTVhMzEKPiAtLS0gL2Rldi9udWxsCj4gKysrIGIv ZHJpdmVycy9pM2MvbWFzdGVyL3N2Yy9pM2MtYW1sb2dpYy5jCj4gQEAgLTAsMCArMSwyNTAgQEAK ClsgLi4uIF0KCj4gK3N0YXRpYyBpbnQgZGVmYXVsdF9pM2NfZmNsa19yYXRlX2luaXQoc3RydWN0 IHN2Y19pM2NfbWFzdGVyICptYXN0ZXIsCj4gKwkJCQkgICAgICBzdHJ1Y3QgY2xrICpmY2xrLCB1 bnNpZ25lZCBsb25nIHJhdGUpCj4gK3sKPiArCWludCBlcnI7Cj4gKwo+ICsJZXJyID0gY2xrX3Nl dF9yYXRlKGZjbGssIHJhdGUpOwo+ICsJaWYgKGVycikKPiArCQlyZXR1cm4gZGV2X2Vycl9wcm9i ZShtYXN0ZXItPmRldiwgZXJyLAo+ICsJCQkJICAgICAic2V0dGluZyBmYXN0IGNsb2NrIHJhdGUg ZmFpbGVkXG4iKTsKPiArCj4gKwlyZXR1cm4gMDsKPiArfQo+ICsKPiArc3RhdGljIGludCBhb19p M2NfZmNsa19yYXRlX2luaXQoc3RydWN0IHN2Y19pM2NfbWFzdGVyICptYXN0ZXIsCj4gKwkJCQkg c3RydWN0IGNsayAqZmNsaywgdW5zaWduZWQgbG9uZyByYXRlKQo+ICt7Cj4gKwl1bnNpZ25lZCBp bnQgZGl2X2NudCwgcmVnX3ZhbDsKPiArCXVuc2lnbmVkIGxvbmcgZmluX2ZyZXEgPSBjbGtfZ2V0 X3JhdGUoZmNsayk7Cj4gKwo+ICsJaWYgKCFmaW5fZnJlcSkKPiArCQlyZXR1cm4gZGV2X2Vycl9w cm9iZShtYXN0ZXItPmRldiwgLUVJTlZBTCwKPiArCQkJCSAgICAgImNhbid0IGdldCBJM0MgZmFz dCBjbG9jayByYXRlXG4iKTsKPiArCj4gKwlkaXZfY250ID0gZGl2NjRfdTY0KGZpbl9mcmVxLCBy YXRlKTsKPiArCWlmICghZGl2X2NudCB8fCBkaXZfY250ID4gSTNDX0FPX0ZDTEtfRElWX01BU0sp Cj4gKwkJcmV0dXJuIGRldl9lcnJfcHJvYmUobWFzdGVyLT5kZXYsIC1FSU5WQUwsCj4gKwkJCQkg ICAgICJyZXF1ZXN0ZWQgZmFzdCBjbG9jayBmcmVxdWVuY3kgdG9vIGxvd1xuIik7Cj4gKwo+ICsJ cmVnX3ZhbCA9IEkzQ19BT19GQ0xLX0RJVl9FTiB8IEkzQ19BT19GQ0xLX0VOIHwgKGRpdl9jbnQg LSAxKTsKPiArCXdyaXRlbChyZWdfdmFsLCBtYXN0ZXItPnJlZ3MgKyBJM0NfQU9fRkNMS19ESVZf Q1RSTCk7Cj4gKwo+ICsJcmV0dXJuIDA7Cj4gK30KPiArCj4gK3N0YXRpYyBpbnQgYW1sb2dpY19p M2NfcHJvYmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKPiArewo+ICsJc3RydWN0IGRl dmljZSAqZGV2ID0gJnBkZXYtPmRldjsKPiArCWNvbnN0IHN0cnVjdCBhbWxvZ2ljX2kzY19kcnZk YXRhICpkYXRhOwo+ICsJc3RydWN0IHN2Y19pM2NfbWFzdGVyICptYXN0ZXI7Cj4gKwlzdHJ1Y3Qg YW1sb2dpY19pM2NfcHJpdiAqcHJpdjsKPiArCXN0cnVjdCBjbGsgKmZjbGs7Cj4gKwlpbnQgcmV0 LCBpOwoKWyAuLi4gXQoKPiArCXByaXYtPm51bV9jbGtzID0gZGV2bV9jbGtfYnVsa19nZXRfYWxs KGRldiwgJnByaXYtPmNsa3MpOwo+ICsJaWYgKHByaXYtPm51bV9jbGtzIDwgMCkKPiArCQlyZXR1 cm4gZGV2X2Vycl9wcm9iZShkZXYsIC1FSU5WQUwsICJjYW4ndCBnZXQgSTNDIGNsb2Nrc1xuIik7 CgpbU2V2ZXJpdHk6IEhpZ2hdClNob3VsZCBhbWxvZ2ljX2kzY19wcm9iZSgpIHBhc3MgcHJpdi0+ bnVtX2Nsa3MgaW5zdGVhZCBvZiAtRUlOVkFMIHRvCmRldl9lcnJfcHJvYmUoKSBoZXJlPwoKV2hl biBkZXZtX2Nsa19idWxrX2dldF9hbGwoKSByZXR1cm5zIC1FUFJPQkVfREVGRVIgYmVjYXVzZSB0 aGUgY2xvY2sKY29udHJvbGxlciBoYXMgbm90IHByb2JlZCB5ZXQsIHBhc3NpbmcgYSBoYXJkY29k ZWQgLUVJTlZBTCBjYXVzZXMKZGV2X2Vycl9wcm9iZSgpIHRvIGxvZyBhbiBlcnJvciBhbmQgYWJv cnQgcHJvYmluZyBwZXJtYW5lbnRseSBpbnN0ZWFkIG9mCmRlZmVycmluZy4KCj4gKwo+ICsJZm9y IChpID0gMDsgaSA8IHByaXYtPm51bV9jbGtzOyBpKyspIHsKPiArCQlpZiAoIXN0cmNtcChwcml2 LT5jbGtzW2ldLmlkLCAiZmFzdF9jbGsiKSkKPiArCQkJYnJlYWs7Cj4gKwl9Cj4gKwo+ICsJaWYg KGkgPT0gcHJpdi0+bnVtX2Nsa3MpCj4gKwkJcmV0dXJuIGRldl9lcnJfcHJvYmUoZGV2LCAtRUlO VkFMLAo+ICsJCQkJICAgICAiY2FuJ3QgZ2V0IEkzQyBwZXJpcGhlcmFsIGNsb2NrXG4iKTsKPiAr Cj4gKwlpZiAoSVNfRVJSKHByaXYtPmNsa3NbaV0uY2xrKSkKPiArCQlyZXR1cm4gUFRSX0VSUihw cml2LT5jbGtzW2ldLmNsayk7Cj4gKwlmY2xrID0gcHJpdi0+Y2xrc1tpXS5jbGs7Cj4gKwo+ICsJ cmV0ID0gY2xrX2J1bGtfcHJlcGFyZV9lbmFibGUocHJpdi0+bnVtX2Nsa3MsIHByaXYtPmNsa3Mp Owo+ICsJaWYgKHJldCkKPiArCQlyZXR1cm4gZGV2X2Vycl9wcm9iZShkZXYsIHJldCwgImNhbid0 IGVuYWJsZSBJM0MgY2xvY2tzXG4iKTsKPiArCj4gKwltYXN0ZXItPmRldiA9IGRldjsKPiArCW1h c3Rlci0+YnNwX3ByaXYgPSBwcml2Owo+ICsJcmV0ID0gZGF0YS0+ZmNsa19yYXRlX2luaXQobWFz dGVyLCBmY2xrLCBJM0NfREVGQVVMVF9GQ0xLX1JBVEUpOwo+ICsJaWYgKHJldCkKPiArCQlnb3Rv IGVycl9kaXNhYmxlX2Nsa3M7Cj4gKwltYXN0ZXItPmZjbGtfcmF0ZSA9IEkzQ19ERUZBVUxUX0ZD TEtfUkFURTsKCltTZXZlcml0eTogTWVkaXVtXQpDYW4gdGhlIGRpdmlkZXIgbWF0aCBpbiBhb19p M2NfZmNsa19yYXRlX2luaXQoKSBhbmQgdGhlIGhhcmRjb2RlZAptYXN0ZXItPmZjbGtfcmF0ZSBh c3NpZ25tZW50IGluIGFtbG9naWNfaTNjX3Byb2JlKCkgZmFpbCBwcm9iZSBvbiBhIDI0IE1Iegpp bnB1dCBjbG9jayBvciBwcm9kdWNlIGFuIGluYWNjdXJhdGUgZmNsa19yYXRlPwoKSW4gYW9faTNj X2ZjbGtfcmF0ZV9pbml0KCksIGRpdl9jbnQgPSBkaXY2NF91NjQoZmluX2ZyZXEsIHJhdGUpIHRy dW5jYXRlcyB2aWEKaW50ZWdlciBkaXZpc2lvbjoKCjEuIEZvciB0aGUgQWx3YXlzLU9uIEkzQyBj b250cm9sbGVyLCBmYXN0X2NsayBpcyBhOV9hb19zeXNfaTNjLCB3aGljaCBpcwogICBnYXRlZCBm cm9tIGE5X2FvX3N5cyAobXV4ZWQgYmV0d2VlbiB0aGUgMjQgTUh6IGFvX3h0YWwgYW5kIHN5cyku IFdoZW4KICAgZmluX2ZyZXEgaXMgMjQgTUh6LCBkaXY2NF91NjQoMjQwMDAwMDAsIDI1MDAwMDAw KSBldmFsdWF0ZXMgdG8gMCwgY2F1c2luZwogICBhb19pM2NfZmNsa19yYXRlX2luaXQoKSB0byBm YWlsIHByb2JlIHdpdGggLUVJTlZBTC4KCjIuIFdoZW4gZmluX2ZyZXEgaXMgbm90IGFuIGV4YWN0 IG11bHRpcGxlIG9mIDI1IE1IeiAoZm9yIGV4YW1wbGUsIGEKICAgMTY2LjY3IE1IeiBzeXMgY2xv Y2spLCBkaXY2NF91NjQoZmluX2ZyZXEsIHJhdGUpIHRydW5jYXRlcyBkb3duIHRvIDYsCiAgIGNv bmZpZ3VyaW5nIEkzQ19BT19GQ0xLX0RJVl9DVFJMIGZvciAyNy43OCBNSHogd2hpbGUgbWFzdGVy LT5mY2xrX3JhdGUgaXMKICAgaGFyZGNvZGVkIHRvIEkzQ19ERUZBVUxUX0ZDTEtfUkFURSAoMjUg TUh6KS4gU2ltaWxhcmx5LCBpbgogICBkZWZhdWx0X2kzY19mY2xrX3JhdGVfaW5pdCgpLCBjbGtf c2V0X3JhdGUoKSByb3VuZHMgdG8gdGhlIGNsb3Nlc3QgcmF0ZQogICBzdXBwb3J0ZWQgYnkgdGhl IGNsb2NrIHRyZWUgcmF0aGVyIHRoYW4gZ3VhcmFudGVlaW5nIDI1IE1Iei4gV2hlbiB0aGUKICAg YWN0dWFsIGNsb2NrIHJhdGUgZXhjZWVkcyAyNSBNSHosIHN2Y19pM2NfbWFzdGVyX2J1c19pbml0 KCkgYW5kCiAgIHN2Y19pM2NfbWFzdGVyX3NldF9zcGVlZCgpIGNvbXB1dGUgcHBiYXVkLCBvZGJh dWQsIGFuZCBpMmNiYXVkIGFzc3VtaW5nCiAgIDI1IE1Ieiwgd2hpY2ggY2FuIGRyaXZlIHB1c2gt cHVsbCBTQ0wgYWJvdmUgdGhlIDEyLjUgTUh6IE1JUEkgSTNDIGxpbWl0LgoKMy4gQmVjYXVzZSAo ZGl2X2NudCAtIDEpIGlzIHdyaXR0ZW4gaW50byB0aGUgOC1iaXQgSTNDX0FPX0ZDTEtfRElWX01B U0sgZmllbGQKICAgKEdFTk1BU0soNywgMCkpLCB0aGUgbWF4aW11bSBzdXBwb3J0ZWQgZGl2aWRl ciBpcyBJM0NfQU9fRkNMS19ESVZfTUFTSyArIDEKICAgKDI1NiksIHNvIGNoZWNraW5nIGRpdl9j bnQgPiBJM0NfQU9fRkNMS19ESVZfTUFTSyBpcyBvZmYgYnkgb25lLgoKU2hvdWxkIGFvX2kzY19m Y2xrX3JhdGVfaW5pdCgpIHJvdW5kIHRoZSBkaXZpZGVyIHVwIChmb3IgZXhhbXBsZSB3aXRoCkRJ Vl9ST1VORF9VUF9VTEwpIGFuZCB1cGRhdGUgbWFzdGVyLT5mY2xrX3JhdGUgdG8gdGhlIGFjdHVh bCBkaXZpZGVkIG9yCnF1ZXJpZWQgY2xvY2sgcmF0ZT8KCj4gKwo+ICsJcG1fcnVudGltZV9zZXRf YXV0b3N1c3BlbmRfZGVsYXkoZGV2LCBTVkNfSTNDX1BNX1RJTUVPVVRfTVMpOwo+ICsJcG1fcnVu dGltZV91c2VfYXV0b3N1c3BlbmQoZGV2KTsKPiArCXBtX3J1bnRpbWVfZ2V0X25vcmVzdW1lKGRl dik7Cj4gKwlwbV9ydW50aW1lX3NldF9hY3RpdmUoZGV2KTsKPiArCXBtX3J1bnRpbWVfZW5hYmxl KGRldik7CgpbIC4uLiBdCgo+ICtzdGF0aWMgdm9pZCBhbWxvZ2ljX2kzY19yZW1vdmUoc3RydWN0 IHBsYXRmb3JtX2RldmljZSAqcGRldikKPiArewo+ICsJc3RydWN0IHN2Y19pM2NfbWFzdGVyICpt YXN0ZXIgPSBwbGF0Zm9ybV9nZXRfZHJ2ZGF0YShwZGV2KTsKPiArCj4gKwlzdmNfaTNjX21hc3Rl cl9yZW1vdmUobWFzdGVyKTsKPiArCj4gKwlwbV9ydW50aW1lX2RvbnRfdXNlX2F1dG9zdXNwZW5k KCZwZGV2LT5kZXYpOwo+ICsJcG1fcnVudGltZV9kaXNhYmxlKCZwZGV2LT5kZXYpOwo+ICt9Cgpb U2V2ZXJpdHk6IE1lZGl1bV0KRG9lcyBhbWxvZ2ljX2kzY19yZW1vdmUoKSBsZWFrIGNsb2NrIHBy ZXBhcmUgYW5kIGVuYWJsZSByZWZlcmVuY2VzIG9uCnByaXYtPmNsa3Mgd2hlbiB0aGUgZGV2aWNl IGlzIHN0aWxsIGFjdGl2ZSBhdCByZW1vdmFsIHRpbWU/CgpJbiBhbWxvZ2ljX2kzY19wcm9iZSgp LCBjbG9ja3MgYXJlIGFjcXVpcmVkIHZpYSBkZXZtX2Nsa19idWxrX2dldF9hbGwoKSBhbmQKbWFu dWFsbHkgZW5hYmxlZCB3aXRoIGNsa19idWxrX3ByZXBhcmVfZW5hYmxlKHByaXYtPm51bV9jbGtz LCBwcml2LT5jbGtzKS4KCkR1cmluZyByZW1vdmFsLCBzdmNfaTNjX21hc3Rlcl9yZW1vdmUoKSBj YWxscwppM2NfbWFzdGVyX3VucmVnaXN0ZXIoKS0+c3ZjX2kzY19tYXN0ZXJfYnVzX2NsZWFudXAo KSwgd2hpY2ggcmVzdW1lcyB0aGUKZGV2aWNlIHZpYSBwbV9ydW50aW1lX3Jlc3VtZV9hbmRfZ2V0 KCkgYW5kIGNhbGxzCnBtX3J1bnRpbWVfcHV0X2F1dG9zdXNwZW5kKCkuCgpJZiBDT05GSUdfUE0g aXMgZGlzYWJsZWQgKHdoZXJlIHJ1bnRpbWUgUE0gaGVscGVycyBhcmUgbm8tb3BzKSwgb3IgaWYg cnVudGltZQpzdXNwZW5kIGlzIHByZXZlbnRlZCBhdCByZW1vdmFsIHRpbWUgKGZvciBleGFtcGxl IHZpYSBzeXNmcyBwb3dlci9jb250cm9sIG9yCmJlY2F1c2Ugc3ZjX2kzY19tYXN0ZXJfZW5hYmxl X2hvdGpvaW4oKSBpbmNyZW1lbnRlZCBtYXN0ZXItPmRldidzIHJ1bnRpbWUgUE0KdXNhZ2UgY291 bnQgd2l0aG91dCBhIG1hdGNoaW5nIHB1dCBpbiBzdmNfaTNjX21hc3Rlcl9yZW1vdmUoKSksCnBt X3J1bnRpbWVfZG9udF91c2VfYXV0b3N1c3BlbmQoKSB3aWxsIG5vdCBpbnZva2UKYW1sb2dpY19p M2NfcnVudGltZV9zdXNwZW5kKCkuCgpTaG91bGQgYW1sb2dpY19pM2NfcmVtb3ZlKCkgY2hlY2sg IXBtX3J1bnRpbWVfc3RhdHVzX3N1c3BlbmRlZCgmcGRldi0+ZGV2KQphZnRlciBwbV9ydW50aW1l X2Rpc2FibGUoJnBkZXYtPmRldikgYW5kIGNhbGwgY2xrX2J1bGtfZGlzYWJsZV91bnByZXBhcmUo KQphbmQgcG1fcnVudGltZV9zZXRfc3VzcGVuZGVkKCZwZGV2LT5kZXYpPwoKPiArCj4gK3N0YXRp YyBpbnQgX19tYXliZV91bnVzZWQgYW1sb2dpY19pM2NfcnVudGltZV9zdXNwZW5kKHN0cnVjdCBk ZXZpY2UgKmRldikKPiArewo+ICsJc3RydWN0IHN2Y19pM2NfbWFzdGVyICptYXN0ZXIgPSBkZXZf Z2V0X2RydmRhdGEoZGV2KTsKPiArCXN0cnVjdCBhbWxvZ2ljX2kzY19wcml2ICpwcml2ID0gbWFz dGVyLT5ic3BfcHJpdjsKPiArCj4gKwlzdmNfaTNjX3NhdmVfcmVncyhtYXN0ZXIpOwo+ICsJY2xr X2J1bGtfZGlzYWJsZV91bnByZXBhcmUocHJpdi0+bnVtX2Nsa3MsIHByaXYtPmNsa3MpOwo+ICsJ cGluY3RybF9wbV9zZWxlY3Rfc2xlZXBfc3RhdGUoZGV2KTsKPiArCj4gKwlyZXR1cm4gMDsKPiAr fQo+ICsKPiArc3RhdGljIGludCBfX21heWJlX3VudXNlZCBhbWxvZ2ljX2kzY19ydW50aW1lX3Jl c3VtZShzdHJ1Y3QgZGV2aWNlICpkZXYpCj4gK3sKPiArCXN0cnVjdCBzdmNfaTNjX21hc3RlciAq bWFzdGVyID0gZGV2X2dldF9kcnZkYXRhKGRldik7Cj4gKwlzdHJ1Y3QgYW1sb2dpY19pM2NfcHJp diAqcHJpdiA9IG1hc3Rlci0+YnNwX3ByaXY7Cj4gKwlpbnQgcmV0Owo+ICsKPiArCXBpbmN0cmxf cG1fc2VsZWN0X2RlZmF1bHRfc3RhdGUoZGV2KTsKPiArCXJldCA9IGNsa19idWxrX3ByZXBhcmVf ZW5hYmxlKHByaXYtPm51bV9jbGtzLCBwcml2LT5jbGtzKTsKPiArCWlmIChyZXQpCj4gKwkJcmV0 dXJuIHJldDsKPiArCj4gKwlzdmNfaTNjX3Jlc3RvcmVfcmVncyhtYXN0ZXIpOwo+ICsKPiArCXJl dHVybiAwOwo+ICt9CgpbU2V2ZXJpdHk6IE1lZGl1bV0KT24gImFtbG9naWMsaTNjLWFvLWE5IiBk ZXZpY2VzLCBjYW4gSTNDX0FPX0ZDTEtfRElWX0NUUkwgbG9zZSBpdHMKY29uZmlndXJhdGlvbiBh Y3Jvc3Mgc3VzcGVuZCBhbmQgcmVzdW1lPwoKRHVyaW5nIHByb2JlLCBhb19pM2NfZmNsa19yYXRl X2luaXQoKSB3cml0ZXMgSTNDX0FPX0ZDTEtfRElWX0VOLApJM0NfQU9fRkNMS19FTiwgYW5kIHRo ZSBkaXZpZGVyIGludG8gbWFzdGVyLT5yZWdzICsgSTNDX0FPX0ZDTEtfRElWX0NUUkwuCgpXaGVu IHN1c3BlbmRpbmcgYW5kIHJlc3VtaW5nIHZpYSBhbWxvZ2ljX2kzY19ydW50aW1lX3N1c3BlbmQo KSBhbmQKYW1sb2dpY19pM2NfcnVudGltZV9yZXN1bWUoKSAod2hpY2ggYXJlIGFsc28gdXNlZCBm b3Igc3lzdGVtIHNsZWVwIHZpYQpwbV9ydW50aW1lX2ZvcmNlX3N1c3BlbmQoKSBhbmQgcG1fcnVu dGltZV9mb3JjZV9yZXN1bWUoKSksCnN2Y19pM2Nfc2F2ZV9yZWdzKCkgYW5kIHN2Y19pM2NfcmVz dG9yZV9yZWdzKCkgb25seSBzYXZlIGFuZCByZXN0b3JlClNWQ19JM0NfTUNPTkZJRyBhbmQgU1ZD X0kzQ19NRFlOQUREUi4KCklmIHRoZSBjb250cm9sbGVyIGxvc2VzIHJlZ2lzdGVyIHN0YXRlIGR1 cmluZyBzdXNwZW5kIG9yIGhpYmVybmF0aW9uLAp3b3VsZG4ndCBJM0NfQU9fRkNMS19ESVZfQ1RS TCByZW1haW4gdW5jb25maWd1cmVkIG9uIHJlc3VtZSB1bmxlc3MgaXQgaXMKc2F2ZWQgYW5kIHJl c3RvcmVkIG9yIHJlLWluaXRpYWxpemVkPwoKWyAuLi4gXQoKPiAtLSAKPiAyLjQ3LjMKCi0tIApT YXNoaWtvIEFJIHJldmlldyDCtyBodHRwczovL3Nhc2hpa28uZGV2LyMvcGF0Y2hzZXQvMjAyNjEw MTktYTlfaTNjLXYxLTAtMzI5ZDgxOWQ2MjFmQGFtbG9naWMuY29tP3BhcnQ9MwoKLS0gCmxpbnV4 LWkzYyBtYWlsaW5nIGxpc3QKbGludXgtaTNjQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xp c3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1pM2MK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ABA2BCCF2DB for ; Mon, 19 Oct 2026 05:52:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Date:References: In-Reply-To:Cc:To:Subject:From:Message-ID:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Satt55HujdqC6Jo1SO3M0TVwcmSDpO35Y2KYTUKLcGw=; b=rb38ZV7OevRBxS +PK+J6CUcAFGsHF87V7u6C9bbeStGYnIAIEnJULR+SZbrUWhoo+LuZtT2Z2k7EiyJKqQwPPN4n+Qk 6nWxIfKxDYfHeJ6S2g1VUFBVwjuHjXbHM0vahBkxaMJJLoN+c7OuF+WwdKXJTONNg1zK5CUjbm1Pv uBBmOkEpeg9qtHNIjLd7IA+OmP+lUdhSXNAIlHlR5U+yqLLXTxk4y0HOepRJyHBZSvcrCzQ+Ja6pF aPtDDraaZxxY8yaSjl4lnGTYKp21HPDdXzMKsH8X0bphtkfi3M3hReErX83wXI9xJi+uZQWKRztA8 ot9qlEDhMWAtdlkDKcBg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xIgI8-00000006eyg-0TDg; Mon, 19 Oct 2026 05:52:13 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xIgI6-00000006eyT-115T; Mon, 19 Oct 2026 05:52:10 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 1F0AE600CB; Mon, 19 Oct 2026 05:52:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7193A1F000C5; Mon, 19 Oct 2026 05:52:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1792389127; bh=rkza5uVRf34cN3QyerCAeal95ev4k8kEa3sElA7jHBE=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=OFYMXqBanYhuS4CFmXxh8oVGz7ZlxTDx99/nflQfpNGVEaiEVutaAGucoj/4rUSL2 rz3hIzTqv1ClPFoQ882yy3Wx7us2HvNYAyOShCcD/kLMDH76WsMRQLYpQEY5MrT0bJ r9HSi4bTDPBje+MLoTf5XG4fGZmllMDFpLiQk7u9F7Sjqxot97R1iea3ozk4lcZybZ BUfQEK+TsjcAgmMbIAlLbZ6MURi5H/GuBzyMBSGgapvI3Jkm4WBsb87Wj6bmqYZ5de vWlvBqNAAkslUahxpbivyXgSpCslTlVD1ZKkF69u2OoTmCg8anOfBfKVfOyxC+YfWI rwbKUfSsqLf0A== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH 3/3] i3c: master: svc: Add Amlogic A9 glue layer To: "Junyi Zhao" Cc: linux-i3c@lists.infradead.org, devicetree@vger.kernel.org, linux-amlogic@lists.infradead.org, imx@lists.linux.dev, robh@kernel.org, conor+dt@kernel.org, Frank.Li@kernel.org, neil.armstrong@linaro.org, "Alexandre Belloni" In-Reply-To: <20261019-a9_i3c-v1-3-329d819d621f@amlogic.com> References: <20261019-a9_i3c-v1-0-329d819d621f@amlogic.com> <20261019-a9_i3c-v1-3-329d819d621f@amlogic.com> Date: Mon, 19 Oct 2026 05:52:07 +0000 X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg NCBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW0hpZ2hdIGkzYzogbWFzdGVyOiBz dmM6IGJyb2tlbiBwcm9iZSBkZWZlcnJhbCBpbiBhbWxvZ2ljX2kzY19wcm9iZSgpCi0gW01lZGl1 bV0gaTNjOiBtYXN0ZXI6IHN2YzogY2xvY2sgZW5hYmxlIGxlYWsgaW4gYW1sb2dpY19pM2NfcmVt b3ZlKCkKLSBbTWVkaXVtXSBpM2M6IG1hc3Rlcjogc3ZjOiBpM2MtYW1sb2dpYzogbWlzc2luZyBJ M0NfQU9fRkNMS19ESVZfQ1RSTCByZXN0b3JlIG9uIHJlc3VtZQotIFtNZWRpdW1dIGkzYzogbWFz dGVyOiBzdmM6IGluY29ycmVjdCBmY2xrIHJhdGUgYW5kIGRpdmlkZXIgbWF0aCBpbiBhbWxvZ2lj X2kzY19wcm9iZSgpCi0tCgpjb21taXQgY2Y3MGNkN2I1OTM5NWRlODQ1NjFkMzBhNWUzYjM4NjJh YTI3NWFjNApBdXRob3I6IEp1bnlpIFpoYW8gPGp1bnlpLnpoYW9AYW1sb2dpYy5jb20+CgppM2M6 IG1hc3Rlcjogc3ZjOiBBZGQgQW1sb2dpYyBBOSBnbHVlIGxheWVyCgpUaGlzIGNvbW1pdCBhZGRz IGFuIEFtbG9naWMgQTkgZ2x1ZSBkcml2ZXIgZm9yIHRoZSBTaWx2YWNvIFNWQyBJM0MKY29udHJv bGxlciwgcHJvdmlkaW5nIEFtbG9naWMtc3BlY2lmaWMgY2xvY2sgYW5kIHJ1bnRpbWUgUE0gaGFu ZGxpbmcgd2hpbGUKcmV1c2luZyB0aGUgY29tbW9uIFNWQyBJM0MgY29yZSBkcml2ZXIuCgo+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL2kzYy9tYXN0ZXIvc3ZjL2kzYy1hbWxvZ2ljLmMgYi9kcml2ZXJz L2kzYy9tYXN0ZXIvc3ZjL2kzYy1hbWxvZ2ljLmMKPiBuZXcgZmlsZSBtb2RlIDEwMDY0NAo+IGlu ZGV4IDAwMDAwMDAwMDAwMDAuLjgyMzAwZDZhZTVhMzEKPiAtLS0gL2Rldi9udWxsCj4gKysrIGIv ZHJpdmVycy9pM2MvbWFzdGVyL3N2Yy9pM2MtYW1sb2dpYy5jCj4gQEAgLTAsMCArMSwyNTAgQEAK ClsgLi4uIF0KCj4gK3N0YXRpYyBpbnQgZGVmYXVsdF9pM2NfZmNsa19yYXRlX2luaXQoc3RydWN0 IHN2Y19pM2NfbWFzdGVyICptYXN0ZXIsCj4gKwkJCQkgICAgICBzdHJ1Y3QgY2xrICpmY2xrLCB1 bnNpZ25lZCBsb25nIHJhdGUpCj4gK3sKPiArCWludCBlcnI7Cj4gKwo+ICsJZXJyID0gY2xrX3Nl dF9yYXRlKGZjbGssIHJhdGUpOwo+ICsJaWYgKGVycikKPiArCQlyZXR1cm4gZGV2X2Vycl9wcm9i ZShtYXN0ZXItPmRldiwgZXJyLAo+ICsJCQkJICAgICAic2V0dGluZyBmYXN0IGNsb2NrIHJhdGUg ZmFpbGVkXG4iKTsKPiArCj4gKwlyZXR1cm4gMDsKPiArfQo+ICsKPiArc3RhdGljIGludCBhb19p M2NfZmNsa19yYXRlX2luaXQoc3RydWN0IHN2Y19pM2NfbWFzdGVyICptYXN0ZXIsCj4gKwkJCQkg c3RydWN0IGNsayAqZmNsaywgdW5zaWduZWQgbG9uZyByYXRlKQo+ICt7Cj4gKwl1bnNpZ25lZCBp bnQgZGl2X2NudCwgcmVnX3ZhbDsKPiArCXVuc2lnbmVkIGxvbmcgZmluX2ZyZXEgPSBjbGtfZ2V0 X3JhdGUoZmNsayk7Cj4gKwo+ICsJaWYgKCFmaW5fZnJlcSkKPiArCQlyZXR1cm4gZGV2X2Vycl9w cm9iZShtYXN0ZXItPmRldiwgLUVJTlZBTCwKPiArCQkJCSAgICAgImNhbid0IGdldCBJM0MgZmFz dCBjbG9jayByYXRlXG4iKTsKPiArCj4gKwlkaXZfY250ID0gZGl2NjRfdTY0KGZpbl9mcmVxLCBy YXRlKTsKPiArCWlmICghZGl2X2NudCB8fCBkaXZfY250ID4gSTNDX0FPX0ZDTEtfRElWX01BU0sp Cj4gKwkJcmV0dXJuIGRldl9lcnJfcHJvYmUobWFzdGVyLT5kZXYsIC1FSU5WQUwsCj4gKwkJCQkg ICAgICJyZXF1ZXN0ZWQgZmFzdCBjbG9jayBmcmVxdWVuY3kgdG9vIGxvd1xuIik7Cj4gKwo+ICsJ cmVnX3ZhbCA9IEkzQ19BT19GQ0xLX0RJVl9FTiB8IEkzQ19BT19GQ0xLX0VOIHwgKGRpdl9jbnQg LSAxKTsKPiArCXdyaXRlbChyZWdfdmFsLCBtYXN0ZXItPnJlZ3MgKyBJM0NfQU9fRkNMS19ESVZf Q1RSTCk7Cj4gKwo+ICsJcmV0dXJuIDA7Cj4gK30KPiArCj4gK3N0YXRpYyBpbnQgYW1sb2dpY19p M2NfcHJvYmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKPiArewo+ICsJc3RydWN0IGRl dmljZSAqZGV2ID0gJnBkZXYtPmRldjsKPiArCWNvbnN0IHN0cnVjdCBhbWxvZ2ljX2kzY19kcnZk YXRhICpkYXRhOwo+ICsJc3RydWN0IHN2Y19pM2NfbWFzdGVyICptYXN0ZXI7Cj4gKwlzdHJ1Y3Qg YW1sb2dpY19pM2NfcHJpdiAqcHJpdjsKPiArCXN0cnVjdCBjbGsgKmZjbGs7Cj4gKwlpbnQgcmV0 LCBpOwoKWyAuLi4gXQoKPiArCXByaXYtPm51bV9jbGtzID0gZGV2bV9jbGtfYnVsa19nZXRfYWxs KGRldiwgJnByaXYtPmNsa3MpOwo+ICsJaWYgKHByaXYtPm51bV9jbGtzIDwgMCkKPiArCQlyZXR1 cm4gZGV2X2Vycl9wcm9iZShkZXYsIC1FSU5WQUwsICJjYW4ndCBnZXQgSTNDIGNsb2Nrc1xuIik7 CgpbU2V2ZXJpdHk6IEhpZ2hdClNob3VsZCBhbWxvZ2ljX2kzY19wcm9iZSgpIHBhc3MgcHJpdi0+ bnVtX2Nsa3MgaW5zdGVhZCBvZiAtRUlOVkFMIHRvCmRldl9lcnJfcHJvYmUoKSBoZXJlPwoKV2hl biBkZXZtX2Nsa19idWxrX2dldF9hbGwoKSByZXR1cm5zIC1FUFJPQkVfREVGRVIgYmVjYXVzZSB0 aGUgY2xvY2sKY29udHJvbGxlciBoYXMgbm90IHByb2JlZCB5ZXQsIHBhc3NpbmcgYSBoYXJkY29k ZWQgLUVJTlZBTCBjYXVzZXMKZGV2X2Vycl9wcm9iZSgpIHRvIGxvZyBhbiBlcnJvciBhbmQgYWJv cnQgcHJvYmluZyBwZXJtYW5lbnRseSBpbnN0ZWFkIG9mCmRlZmVycmluZy4KCj4gKwo+ICsJZm9y IChpID0gMDsgaSA8IHByaXYtPm51bV9jbGtzOyBpKyspIHsKPiArCQlpZiAoIXN0cmNtcChwcml2 LT5jbGtzW2ldLmlkLCAiZmFzdF9jbGsiKSkKPiArCQkJYnJlYWs7Cj4gKwl9Cj4gKwo+ICsJaWYg KGkgPT0gcHJpdi0+bnVtX2Nsa3MpCj4gKwkJcmV0dXJuIGRldl9lcnJfcHJvYmUoZGV2LCAtRUlO VkFMLAo+ICsJCQkJICAgICAiY2FuJ3QgZ2V0IEkzQyBwZXJpcGhlcmFsIGNsb2NrXG4iKTsKPiAr Cj4gKwlpZiAoSVNfRVJSKHByaXYtPmNsa3NbaV0uY2xrKSkKPiArCQlyZXR1cm4gUFRSX0VSUihw cml2LT5jbGtzW2ldLmNsayk7Cj4gKwlmY2xrID0gcHJpdi0+Y2xrc1tpXS5jbGs7Cj4gKwo+ICsJ cmV0ID0gY2xrX2J1bGtfcHJlcGFyZV9lbmFibGUocHJpdi0+bnVtX2Nsa3MsIHByaXYtPmNsa3Mp Owo+ICsJaWYgKHJldCkKPiArCQlyZXR1cm4gZGV2X2Vycl9wcm9iZShkZXYsIHJldCwgImNhbid0 IGVuYWJsZSBJM0MgY2xvY2tzXG4iKTsKPiArCj4gKwltYXN0ZXItPmRldiA9IGRldjsKPiArCW1h c3Rlci0+YnNwX3ByaXYgPSBwcml2Owo+ICsJcmV0ID0gZGF0YS0+ZmNsa19yYXRlX2luaXQobWFz dGVyLCBmY2xrLCBJM0NfREVGQVVMVF9GQ0xLX1JBVEUpOwo+ICsJaWYgKHJldCkKPiArCQlnb3Rv IGVycl9kaXNhYmxlX2Nsa3M7Cj4gKwltYXN0ZXItPmZjbGtfcmF0ZSA9IEkzQ19ERUZBVUxUX0ZD TEtfUkFURTsKCltTZXZlcml0eTogTWVkaXVtXQpDYW4gdGhlIGRpdmlkZXIgbWF0aCBpbiBhb19p M2NfZmNsa19yYXRlX2luaXQoKSBhbmQgdGhlIGhhcmRjb2RlZAptYXN0ZXItPmZjbGtfcmF0ZSBh c3NpZ25tZW50IGluIGFtbG9naWNfaTNjX3Byb2JlKCkgZmFpbCBwcm9iZSBvbiBhIDI0IE1Iegpp bnB1dCBjbG9jayBvciBwcm9kdWNlIGFuIGluYWNjdXJhdGUgZmNsa19yYXRlPwoKSW4gYW9faTNj X2ZjbGtfcmF0ZV9pbml0KCksIGRpdl9jbnQgPSBkaXY2NF91NjQoZmluX2ZyZXEsIHJhdGUpIHRy dW5jYXRlcyB2aWEKaW50ZWdlciBkaXZpc2lvbjoKCjEuIEZvciB0aGUgQWx3YXlzLU9uIEkzQyBj b250cm9sbGVyLCBmYXN0X2NsayBpcyBhOV9hb19zeXNfaTNjLCB3aGljaCBpcwogICBnYXRlZCBm cm9tIGE5X2FvX3N5cyAobXV4ZWQgYmV0d2VlbiB0aGUgMjQgTUh6IGFvX3h0YWwgYW5kIHN5cyku IFdoZW4KICAgZmluX2ZyZXEgaXMgMjQgTUh6LCBkaXY2NF91NjQoMjQwMDAwMDAsIDI1MDAwMDAw KSBldmFsdWF0ZXMgdG8gMCwgY2F1c2luZwogICBhb19pM2NfZmNsa19yYXRlX2luaXQoKSB0byBm YWlsIHByb2JlIHdpdGggLUVJTlZBTC4KCjIuIFdoZW4gZmluX2ZyZXEgaXMgbm90IGFuIGV4YWN0 IG11bHRpcGxlIG9mIDI1IE1IeiAoZm9yIGV4YW1wbGUsIGEKICAgMTY2LjY3IE1IeiBzeXMgY2xv Y2spLCBkaXY2NF91NjQoZmluX2ZyZXEsIHJhdGUpIHRydW5jYXRlcyBkb3duIHRvIDYsCiAgIGNv bmZpZ3VyaW5nIEkzQ19BT19GQ0xLX0RJVl9DVFJMIGZvciAyNy43OCBNSHogd2hpbGUgbWFzdGVy LT5mY2xrX3JhdGUgaXMKICAgaGFyZGNvZGVkIHRvIEkzQ19ERUZBVUxUX0ZDTEtfUkFURSAoMjUg TUh6KS4gU2ltaWxhcmx5LCBpbgogICBkZWZhdWx0X2kzY19mY2xrX3JhdGVfaW5pdCgpLCBjbGtf c2V0X3JhdGUoKSByb3VuZHMgdG8gdGhlIGNsb3Nlc3QgcmF0ZQogICBzdXBwb3J0ZWQgYnkgdGhl IGNsb2NrIHRyZWUgcmF0aGVyIHRoYW4gZ3VhcmFudGVlaW5nIDI1IE1Iei4gV2hlbiB0aGUKICAg YWN0dWFsIGNsb2NrIHJhdGUgZXhjZWVkcyAyNSBNSHosIHN2Y19pM2NfbWFzdGVyX2J1c19pbml0 KCkgYW5kCiAgIHN2Y19pM2NfbWFzdGVyX3NldF9zcGVlZCgpIGNvbXB1dGUgcHBiYXVkLCBvZGJh dWQsIGFuZCBpMmNiYXVkIGFzc3VtaW5nCiAgIDI1IE1Ieiwgd2hpY2ggY2FuIGRyaXZlIHB1c2gt cHVsbCBTQ0wgYWJvdmUgdGhlIDEyLjUgTUh6IE1JUEkgSTNDIGxpbWl0LgoKMy4gQmVjYXVzZSAo ZGl2X2NudCAtIDEpIGlzIHdyaXR0ZW4gaW50byB0aGUgOC1iaXQgSTNDX0FPX0ZDTEtfRElWX01B U0sgZmllbGQKICAgKEdFTk1BU0soNywgMCkpLCB0aGUgbWF4aW11bSBzdXBwb3J0ZWQgZGl2aWRl ciBpcyBJM0NfQU9fRkNMS19ESVZfTUFTSyArIDEKICAgKDI1NiksIHNvIGNoZWNraW5nIGRpdl9j bnQgPiBJM0NfQU9fRkNMS19ESVZfTUFTSyBpcyBvZmYgYnkgb25lLgoKU2hvdWxkIGFvX2kzY19m Y2xrX3JhdGVfaW5pdCgpIHJvdW5kIHRoZSBkaXZpZGVyIHVwIChmb3IgZXhhbXBsZSB3aXRoCkRJ Vl9ST1VORF9VUF9VTEwpIGFuZCB1cGRhdGUgbWFzdGVyLT5mY2xrX3JhdGUgdG8gdGhlIGFjdHVh bCBkaXZpZGVkIG9yCnF1ZXJpZWQgY2xvY2sgcmF0ZT8KCj4gKwo+ICsJcG1fcnVudGltZV9zZXRf YXV0b3N1c3BlbmRfZGVsYXkoZGV2LCBTVkNfSTNDX1BNX1RJTUVPVVRfTVMpOwo+ICsJcG1fcnVu dGltZV91c2VfYXV0b3N1c3BlbmQoZGV2KTsKPiArCXBtX3J1bnRpbWVfZ2V0X25vcmVzdW1lKGRl dik7Cj4gKwlwbV9ydW50aW1lX3NldF9hY3RpdmUoZGV2KTsKPiArCXBtX3J1bnRpbWVfZW5hYmxl KGRldik7CgpbIC4uLiBdCgo+ICtzdGF0aWMgdm9pZCBhbWxvZ2ljX2kzY19yZW1vdmUoc3RydWN0 IHBsYXRmb3JtX2RldmljZSAqcGRldikKPiArewo+ICsJc3RydWN0IHN2Y19pM2NfbWFzdGVyICpt YXN0ZXIgPSBwbGF0Zm9ybV9nZXRfZHJ2ZGF0YShwZGV2KTsKPiArCj4gKwlzdmNfaTNjX21hc3Rl cl9yZW1vdmUobWFzdGVyKTsKPiArCj4gKwlwbV9ydW50aW1lX2RvbnRfdXNlX2F1dG9zdXNwZW5k KCZwZGV2LT5kZXYpOwo+ICsJcG1fcnVudGltZV9kaXNhYmxlKCZwZGV2LT5kZXYpOwo+ICt9Cgpb U2V2ZXJpdHk6IE1lZGl1bV0KRG9lcyBhbWxvZ2ljX2kzY19yZW1vdmUoKSBsZWFrIGNsb2NrIHBy ZXBhcmUgYW5kIGVuYWJsZSByZWZlcmVuY2VzIG9uCnByaXYtPmNsa3Mgd2hlbiB0aGUgZGV2aWNl IGlzIHN0aWxsIGFjdGl2ZSBhdCByZW1vdmFsIHRpbWU/CgpJbiBhbWxvZ2ljX2kzY19wcm9iZSgp LCBjbG9ja3MgYXJlIGFjcXVpcmVkIHZpYSBkZXZtX2Nsa19idWxrX2dldF9hbGwoKSBhbmQKbWFu dWFsbHkgZW5hYmxlZCB3aXRoIGNsa19idWxrX3ByZXBhcmVfZW5hYmxlKHByaXYtPm51bV9jbGtz LCBwcml2LT5jbGtzKS4KCkR1cmluZyByZW1vdmFsLCBzdmNfaTNjX21hc3Rlcl9yZW1vdmUoKSBj YWxscwppM2NfbWFzdGVyX3VucmVnaXN0ZXIoKS0+c3ZjX2kzY19tYXN0ZXJfYnVzX2NsZWFudXAo KSwgd2hpY2ggcmVzdW1lcyB0aGUKZGV2aWNlIHZpYSBwbV9ydW50aW1lX3Jlc3VtZV9hbmRfZ2V0 KCkgYW5kIGNhbGxzCnBtX3J1bnRpbWVfcHV0X2F1dG9zdXNwZW5kKCkuCgpJZiBDT05GSUdfUE0g aXMgZGlzYWJsZWQgKHdoZXJlIHJ1bnRpbWUgUE0gaGVscGVycyBhcmUgbm8tb3BzKSwgb3IgaWYg cnVudGltZQpzdXNwZW5kIGlzIHByZXZlbnRlZCBhdCByZW1vdmFsIHRpbWUgKGZvciBleGFtcGxl IHZpYSBzeXNmcyBwb3dlci9jb250cm9sIG9yCmJlY2F1c2Ugc3ZjX2kzY19tYXN0ZXJfZW5hYmxl X2hvdGpvaW4oKSBpbmNyZW1lbnRlZCBtYXN0ZXItPmRldidzIHJ1bnRpbWUgUE0KdXNhZ2UgY291 bnQgd2l0aG91dCBhIG1hdGNoaW5nIHB1dCBpbiBzdmNfaTNjX21hc3Rlcl9yZW1vdmUoKSksCnBt X3J1bnRpbWVfZG9udF91c2VfYXV0b3N1c3BlbmQoKSB3aWxsIG5vdCBpbnZva2UKYW1sb2dpY19p M2NfcnVudGltZV9zdXNwZW5kKCkuCgpTaG91bGQgYW1sb2dpY19pM2NfcmVtb3ZlKCkgY2hlY2sg IXBtX3J1bnRpbWVfc3RhdHVzX3N1c3BlbmRlZCgmcGRldi0+ZGV2KQphZnRlciBwbV9ydW50aW1l X2Rpc2FibGUoJnBkZXYtPmRldikgYW5kIGNhbGwgY2xrX2J1bGtfZGlzYWJsZV91bnByZXBhcmUo KQphbmQgcG1fcnVudGltZV9zZXRfc3VzcGVuZGVkKCZwZGV2LT5kZXYpPwoKPiArCj4gK3N0YXRp YyBpbnQgX19tYXliZV91bnVzZWQgYW1sb2dpY19pM2NfcnVudGltZV9zdXNwZW5kKHN0cnVjdCBk ZXZpY2UgKmRldikKPiArewo+ICsJc3RydWN0IHN2Y19pM2NfbWFzdGVyICptYXN0ZXIgPSBkZXZf Z2V0X2RydmRhdGEoZGV2KTsKPiArCXN0cnVjdCBhbWxvZ2ljX2kzY19wcml2ICpwcml2ID0gbWFz dGVyLT5ic3BfcHJpdjsKPiArCj4gKwlzdmNfaTNjX3NhdmVfcmVncyhtYXN0ZXIpOwo+ICsJY2xr X2J1bGtfZGlzYWJsZV91bnByZXBhcmUocHJpdi0+bnVtX2Nsa3MsIHByaXYtPmNsa3MpOwo+ICsJ cGluY3RybF9wbV9zZWxlY3Rfc2xlZXBfc3RhdGUoZGV2KTsKPiArCj4gKwlyZXR1cm4gMDsKPiAr fQo+ICsKPiArc3RhdGljIGludCBfX21heWJlX3VudXNlZCBhbWxvZ2ljX2kzY19ydW50aW1lX3Jl c3VtZShzdHJ1Y3QgZGV2aWNlICpkZXYpCj4gK3sKPiArCXN0cnVjdCBzdmNfaTNjX21hc3RlciAq bWFzdGVyID0gZGV2X2dldF9kcnZkYXRhKGRldik7Cj4gKwlzdHJ1Y3QgYW1sb2dpY19pM2NfcHJp diAqcHJpdiA9IG1hc3Rlci0+YnNwX3ByaXY7Cj4gKwlpbnQgcmV0Owo+ICsKPiArCXBpbmN0cmxf cG1fc2VsZWN0X2RlZmF1bHRfc3RhdGUoZGV2KTsKPiArCXJldCA9IGNsa19idWxrX3ByZXBhcmVf ZW5hYmxlKHByaXYtPm51bV9jbGtzLCBwcml2LT5jbGtzKTsKPiArCWlmIChyZXQpCj4gKwkJcmV0 dXJuIHJldDsKPiArCj4gKwlzdmNfaTNjX3Jlc3RvcmVfcmVncyhtYXN0ZXIpOwo+ICsKPiArCXJl dHVybiAwOwo+ICt9CgpbU2V2ZXJpdHk6IE1lZGl1bV0KT24gImFtbG9naWMsaTNjLWFvLWE5IiBk ZXZpY2VzLCBjYW4gSTNDX0FPX0ZDTEtfRElWX0NUUkwgbG9zZSBpdHMKY29uZmlndXJhdGlvbiBh Y3Jvc3Mgc3VzcGVuZCBhbmQgcmVzdW1lPwoKRHVyaW5nIHByb2JlLCBhb19pM2NfZmNsa19yYXRl X2luaXQoKSB3cml0ZXMgSTNDX0FPX0ZDTEtfRElWX0VOLApJM0NfQU9fRkNMS19FTiwgYW5kIHRo ZSBkaXZpZGVyIGludG8gbWFzdGVyLT5yZWdzICsgSTNDX0FPX0ZDTEtfRElWX0NUUkwuCgpXaGVu IHN1c3BlbmRpbmcgYW5kIHJlc3VtaW5nIHZpYSBhbWxvZ2ljX2kzY19ydW50aW1lX3N1c3BlbmQo KSBhbmQKYW1sb2dpY19pM2NfcnVudGltZV9yZXN1bWUoKSAod2hpY2ggYXJlIGFsc28gdXNlZCBm b3Igc3lzdGVtIHNsZWVwIHZpYQpwbV9ydW50aW1lX2ZvcmNlX3N1c3BlbmQoKSBhbmQgcG1fcnVu dGltZV9mb3JjZV9yZXN1bWUoKSksCnN2Y19pM2Nfc2F2ZV9yZWdzKCkgYW5kIHN2Y19pM2NfcmVz dG9yZV9yZWdzKCkgb25seSBzYXZlIGFuZCByZXN0b3JlClNWQ19JM0NfTUNPTkZJRyBhbmQgU1ZD X0kzQ19NRFlOQUREUi4KCklmIHRoZSBjb250cm9sbGVyIGxvc2VzIHJlZ2lzdGVyIHN0YXRlIGR1 cmluZyBzdXNwZW5kIG9yIGhpYmVybmF0aW9uLAp3b3VsZG4ndCBJM0NfQU9fRkNMS19ESVZfQ1RS TCByZW1haW4gdW5jb25maWd1cmVkIG9uIHJlc3VtZSB1bmxlc3MgaXQgaXMKc2F2ZWQgYW5kIHJl c3RvcmVkIG9yIHJlLWluaXRpYWxpemVkPwoKWyAuLi4gXQoKPiAtLSAKPiAyLjQ3LjMKCi0tIApT YXNoaWtvIEFJIHJldmlldyDCtyBodHRwczovL3Nhc2hpa28uZGV2LyMvcGF0Y2hzZXQvMjAyNjEw MTktYTlfaTNjLXYxLTAtMzI5ZDgxOWQ2MjFmQGFtbG9naWMuY29tP3BhcnQ9MwoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYW1sb2dpYyBtYWls aW5nIGxpc3QKbGludXgtYW1sb2dpY0BsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5p bmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYW1sb2dpYwo=