From: sashiko-bot@kernel.org
To: "Alexander Stein" <alexander.stein@ew.tq-group.com>
Cc: imx@lists.linux.dev, devicetree@vger.kernel.org, robh@kernel.org,
conor+dt@kernel.org, Frank.Li@kernel.org
Subject: Re: [PATCH v3 5/5] arm64: dts: freescale: Add dual-channel LVDS overlay for TQMa8Xx
Date: Mon, 19 Oct 2026 08:15:41 +0000 [thread overview]
Message-ID: <sashiko-outbox-176786@kernel.org> (raw)
In-Reply-To: <20261019080621.194103-6-alexander.stein@ew.tq-group.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] arm64: dts: freescale: missing Makefile target for TQMa8XDP LVDS overlay
--
commit d3dd5b226ab9afbea90194501219da137ea03c3a
Author: Alexander Stein <alexander.stein@ew.tq-group.com>
arm64: dts: freescale: Add dual-channel LVDS overlay for TQMa8Xx
This commit adds a device tree overlay for the AUO G133HAN01 dual-channel LVDS
display on the MBa8Xx carrier board and wires it into the Freescale device
tree Makefile.
> diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
> index 84aeff0e78cf2..3b3b1c51fcd6a 100644
> --- a/arch/arm64/boot/dts/freescale/Makefile
> +++ b/arch/arm64/boot/dts/freescale/Makefile
> @@ -846,8 +846,10 @@ dtb-${CONFIG_ARCH_MXC} += imx8qxp-mek-ov5640-csi.dtb
> dtb-$(CONFIG_ARCH_MXC) += imx8qxp-tqma8xqp-mba8xx.dtb
> dtb-$(CONFIG_ARCH_MXC) += imx8qxp-tqma8xqps-mb-smarc-2.dtb
>
> +imx8qxp-tqma8xqp-mba8xx-lvds-g133han01-dtbs += imx8qxp-tqma8xqp-mba8xx.dtb mba8xx-lvds-g133han01.dtbo
> imx8qxp-tqma8xqp-mba8xx-lvds0-tm070jvhg33-dtbs += imx8qxp-tqma8xqp-mba8xx.dtb mba8xx-lvds0-tm070jvhg33.dtbo
> imx8qxp-tqma8xqp-mba8xx-lvds1-tm070jvhg33-dtbs += imx8qxp-tqma8xqp-mba8xx.dtb mba8xx-lvds1-tm070jvhg33.dtbo
> +dtb-$(CONFIG_ARCH_MXC) += imx8qxp-tqma8xqp-mba8xx-lvds-g133han01.dtb
> dtb-$(CONFIG_ARCH_MXC) += imx8qxp-tqma8xqp-mba8xx-lvds0-tm070jvhg33.dtb
> dtb-$(CONFIG_ARCH_MXC) += imx8qxp-tqma8xqp-mba8xx-lvds1-tm070jvhg33.dtb
[Severity: Low]
In the preceding commit ("arm64: dts: freescale: Add LVDS overlays for
TQMa8Xx"), the single-channel LVDS overlays were added for both
imx8qxp-tqma8xqp-mba8xx and imx8dxp-tqma8xdp-mba8xx in
arch/arm64/boot/dts/freescale/Makefile:
imx8dxp-tqma8xdp-mba8xx-lvds0-tm070jvhg33-dtbs += imx8dxp-tqma8xdp-mba8xx.dtb mba8xx-lvds0-tm070jvhg33.dtbo
imx8dxp-tqma8xdp-mba8xx-lvds1-tm070jvhg33-dtbs += imx8dxp-tqma8xdp-mba8xx.dtb mba8xx-lvds1-tm070jvhg33.dtbo
dtb-$(CONFIG_ARCH_MXC) += imx8dxp-tqma8xdp-mba8xx-lvds0-tm070jvhg33.dtb
dtb-$(CONFIG_ARCH_MXC) += imx8dxp-tqma8xdp-mba8xx-lvds1-tm070jvhg33.dtb
Since both boards share mba8xx.dtsi, tqma8xx.dtsi, and the MIPI-LVDS0/1 and
DC0 definitions from imx8qxp.dtsi, should imx8dxp-tqma8xdp-mba8xx-lvds-g133han01.dtb
also be added to the Makefile for TQMa8XDP?
[ ... ]
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261019080621.194103-1-alexander.stein@ew.tq-group.com?part=5
next prev parent reply other threads:[~2026-10-19 8:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-19 8:06 [PATCH v3 0/5] LVDS support for TQMa8Xx Alexander Stein
2026-10-19 8:06 ` [PATCH v3 1/5] dt-bindings: firmware: fsl,scu: Add imx8qxp-pixel-link nodes Alexander Stein
2026-10-21 3:31 ` Rob Herring (Arm)
2026-10-19 8:06 ` [PATCH v3 2/5] arm64: dts: imx8qxp: Add display controller subsystem Alexander Stein
2026-10-19 8:06 ` [PATCH v3 3/5] arm64: dts: imx8qxp: Add MIPI-LVDS combo subsystems Alexander Stein
2026-10-19 8:06 ` [PATCH v3 4/5] arm64: dts: freescale: Add LVDS overlays for TQMa8Xx Alexander Stein
2026-10-19 8:06 ` [PATCH v3 5/5] arm64: dts: freescale: Add dual-channel LVDS overlay " Alexander Stein
2026-10-19 8:15 ` sashiko-bot [this message]
2026-10-20 19:06 ` [PATCH v3 0/5] LVDS support " Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-176786@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=alexander.stein@ew.tq-group.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.