Re: [PATCH v12 2/7] mfd: Add driver for ASUS Transformer embedded controller

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] mfd: asus-transformer-ec: hard-coded cell IDs instead of PLATFORM_DEVID_AUTO
--

commit 69f71ab310cf2527cceba8746f7a17bbb27f3ab4
Author: Michał Mirosław <mirq-linux@rere.qmqm.pl>

mfd: Add driver for ASUS Transformer embedded controller

This commit adds an MFD core driver for the Nuvoton NPCE795-based embedded
controller found in ASUS Transformer series tablets and keyboard docks. It
handles I2C communication, firmware detection, interrupt notifications, and
sub-device registration.

> diff --git a/drivers/mfd/asus-transformer-ec.c b/drivers/mfd/asus-transformer-ec.c
> new file mode 100644
> index 0000000000000..15942ea59fe1a
> --- /dev/null
> +++ b/drivers/mfd/asus-transformer-ec.c
> @@ -0,0 +1,569 @@

[ ... ]

> +static const struct mfd_cell asus_ec_sl101_dock_mfd_devices[] = {
> +	MFD_CELL_NAME("asus-transformer-ec-kbc"),
> +};
> +
> +static const struct mfd_cell asus_ec_tf101_dock_mfd_devices[] = {
> +	MFD_CELL_BASIC("asus-transformer-ec-battery", NULL, NULL, 0, 1),
> +	MFD_CELL_BASIC("asus-transformer-ec-charger", NULL, NULL, 0, 1),
> +	MFD_CELL_BASIC("asus-transformer-ec-led", NULL, NULL, 0, 1),
> +	MFD_CELL_NAME("asus-transformer-ec-kbc"),
> +	MFD_CELL_NAME("asus-transformer-ec-keys"),
> +};
> +
> +static const struct mfd_cell asus_ec_tf201_pad_mfd_devices[] = {
> +	MFD_CELL_NAME("asus-transformer-ec-battery"),
> +	MFD_CELL_NAME("asus-transformer-ec-led"),
> +};
> +
> +static const struct mfd_cell asus_ec_tf600t_pad_mfd_devices[] = {
> +	MFD_CELL_NAME("asus-transformer-ec-battery"),
> +	MFD_CELL_NAME("asus-transformer-ec-charger"),
> +	MFD_CELL_NAME("asus-transformer-ec-led"),
> +};
> +
> +static int asus_ec_probe(struct i2c_client *client)
> +{

[ ... ]

> +	/* Parent I2C controller uses DMA, ASUS EC and child devices do not */
> +	client->dev.coherent_dma_mask = 0;
> +	client->dev.dma_mask = &client->dev.coherent_dma_mask;
> +
> +	return devm_mfd_add_devices(dev, 0, cells, num_cells, NULL, 0, NULL);
> +}

[Severity: Low]
In asus_ec_probe(), devm_mfd_add_devices() is called with a hard-coded base
ID of 0, while asus_ec_tf101_dock_mfd_devices[] manually sets a cell ID of
1 via MFD_CELL_BASIC() for the battery, charger, and led subdevices to offset
them from the pad EC cells (leaving kbc and keys at ID 0).

Could devm_mfd_add_devices() pass PLATFORM_DEVID_AUTO instead of 0, so that
asus_ec_tf101_dock_mfd_devices[] can use MFD_CELL_NAME() for all entries and
rely on automatic cell indexing without risk of platform device name
collisions in sysfs if multiple EC instances with identical cell IDs are
registered?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261019100406.103687-1-clamor95@gmail.com?part=2