Re: [PATCH v5 3/5] powerpc/pseries/eeh: Implement RTAS-based EEH error injection

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] powerpc/eeh: unused function eeh_break_device() when CONFIG_DEBUG_FS=n
--

commit f6dd99f31147847bdca67c87e513a0d4e111ae24
Author: Narayana Murty N <nnmlinux@linux.ibm.com>

powerpc/pseries/eeh: Implement RTAS-based EEH error injection

This commit replaces the legacy MMIO stub in pseries_eeh_err_inject() with
a PAPR-compliant RTAS error injection sequence using ibm,open-errinjct,
ibm,errinjct, and ibm,close-errinjct. It also removes the now-unused
eeh_pe_inject_mmio_error() helper.

> diff --git a/arch/powerpc/kernel/eeh.c b/arch/powerpc/kernel/eeh.c
> index bb836f02101cf..369aad298f752 100644
> --- a/arch/powerpc/kernel/eeh.c
> +++ b/arch/powerpc/kernel/eeh.c
> @@ -1664,11 +1664,6 @@ static int eeh_break_device(struct pci_dev *pdev)
>  	return 0;
>  }
>  
> -int eeh_pe_inject_mmio_error(struct pci_dev *pdev)
> -{
> -	return eeh_break_device(pdev);
> -}
> -
>  #ifdef CONFIG_DEBUG_FS
>  
>  

[Severity: Low]
Previously, commit 3af2e2f68cc6 ("powerpc/pseries/eeh: move
pseries_eeh_err_inject() outside CONFIG_DEBUG_FS block") moved
eeh_break_device() outside the CONFIG_DEBUG_FS block in
arch/powerpc/kernel/eeh.c so that eeh_pe_inject_mmio_error() could call it
when CONFIG_DEBUG_FS=n.

With eeh_pe_inject_mmio_error() removed, the only remaining caller of
eeh_break_device() is eeh_dev_break_write(), which is inside the
CONFIG_DEBUG_FS block:

arch/powerpc/kernel/eeh.c:eeh_dev_break_write() {
	...
	ret = eeh_break_device(pdev);
	...
}

When building with CONFIG_EEH=y and CONFIG_DEBUG_FS=n, won't leaving
eeh_break_device() outside CONFIG_DEBUG_FS trigger an unused-function
compiler warning? Should eeh_break_device() be moved back inside the
CONFIG_DEBUG_FS block?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261019101813.45085-1-nnmlinux@linux.ibm.com?part=3