From: sashiko-bot@kernel.org
To: "Johan Hovold" <johan@kernel.org>
Cc: linux-usb@vger.kernel.org
Subject: Re: [PATCH] USB: serial: upd78f0730: fix NULL-deref on hangup
Date: Mon, 19 Oct 2026 12:36:43 +0000 [thread overview]
Message-ID: <sashiko-outbox-177075@kernel.org> (raw)
In-Reply-To: <20261019123412.2007715-1-johan@kernel.org>
> The port tty pointer is cleared on hangup before deasserting the modem
> control signals and should not be used in the dtr_rts() callback.
>
> Factor out a new upd78f0730_port_tiocmset() helper that can be used in
> upd78f0730_dtr_rts() to avoid dereferencing a NULL-pointer on hangup
> (e.g. on disconnect).
>
> This issue was flagged by an LLM.
>
> Fixes: ea534e0b4047 ("USB: serial: add uPD78F0730 USB to Serial Adaptor Driver")
> Cc: stable@vger.kernel.org # 4.11
> Cc: Maksim Salau <maksim.salau@gmail.com>
> Assisted-by: LLM
> Signed-off-by: Johan Hovold <johan@kernel.org>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261019123412.2007715-1-johan@kernel.org?part=1
prev parent reply other threads:[~2026-10-19 12:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-19 12:34 [PATCH] USB: serial: upd78f0730: fix NULL-deref on hangup Johan Hovold
2026-10-19 12:36 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-177075@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=johan@kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.