From: sashiko-bot@kernel.org
To: Biju <biju.das.au@gmail.com>
Cc: linux-serial@vger.kernel.org
Subject: Re: [PATCH 1/4] serial: sh-sci: Drop TE disable at end of transmission on SCI
Date: Mon, 19 Oct 2026 17:07:28 +0000 [thread overview]
Message-ID: <sashiko-outbox-177993@kernel.org> (raw)
In-Reply-To: <20261019170139.473808-2-biju.das.jz@bp.renesas.com>
> From: Biju Das <biju.das.jz@bp.renesas.com>
>
> Commit f06c2a9000eb ("tty: serial: sh-sci: Fix end of transmission on
> SCI") made sci_transmit_chars() clear SCSCR.TE and return early on
> PORT_SCI once the transmit FIFO is empty.
>
> The hardware manual does not describe disabling the transmitter to end
> a transmission, so this special case has no basis in the documented
> programming sequence. Remove it and let SCI follow the same path as the
> other port types. A plain revert no longer applies because the driver
> now uses a kfifo, so the code is removed by hand.
>
> Fixes: f06c2a9000eb ("tty: serial: sh-sci: Fix end of transmission on SCI")
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261019170139.473808-1-biju.das.jz@bp.renesas.com?part=1
next prev parent reply other threads:[~2026-10-19 17:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-19 17:01 [PATCH 0/4] Fix transmit handling on SCI/RSCI ports Biju
2026-10-19 17:01 ` [PATCH 1/4] serial: sh-sci: Drop TE disable at end of transmission on SCI Biju
2026-10-19 17:07 ` sashiko-bot [this message]
2026-10-19 17:01 ` [PATCH 2/4] serial: sh-sci: Don’t disable TX on TEI while the xmit kfifo still holds data Biju
2026-10-19 17:17 ` sashiko-bot
2026-10-20 15:23 ` Biju Das
2026-10-19 17:01 ` [PATCH 3/4] serial: sh-sci: Skip TDxE status clear for PORT_SCI Biju
2026-10-19 17:19 ` sashiko-bot
2026-10-20 15:28 ` Biju Das
2026-10-20 8:36 ` Geert Uytterhoeven
2026-10-20 9:40 ` Biju Das
2026-10-19 17:01 ` [PATCH 4/4] serial: sh-sci: Toggle TE when restoring SCSCR in console write on SCI Biju
2026-10-19 17:08 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-177993@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=biju.das.au@gmail.com \
--cc=linux-serial@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.