Re: [PATCH v2 03/13] ARM: dts: imx6dl-b155v2: add touchscreen size properties

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] ARM: dts: imx6dl-b155v2: commit message contradicts 16384 touchscreen size
--

commit 9dc060e080fedd6ab87ca8276cfb3bb59a468536
Author: Frank Li <Frank.Li@nxp.com>

ARM: dts: imx6dl-b155v2: add touchscreen size properties

This commit adds touchscreen-size-x and touchscreen-size-y properties to the
touchscreen@2a node in arch/arm/boot/dts/nxp/imx/imx6dl-b155v2.dts to satisfy
the eeti,exc3000 binding schema.

>     ARM: dts: imx6dl-b155v2: add touchscreen size properties
>     
>     The eeti,exc3000 schema requires touchscreen-size-x and touchscreen-size-y
>     properties. Add them for the EXC80H84 touchscreen on the B155v2 board,
>     matching the 1366x768 resolution of the AUO G156XTN01 panel.
>     
>     Fix below CHECK_DTBS warnings:
>       arch/arm/boot/dts/nxp/imx/imx6dl-b155v2.dtb: touchscreen@2a (eeti,exc80h84): 'touchscreen-size-x' is a required property
>             from schema $id: http://devicetree.org/schemas/input/touchscreen/eeti,exc3000.yaml
>     
>     Signed-off-by: Frank Li <Frank.Li@nxp.com>
> 
> diff --git a/arch/arm/boot/dts/nxp/imx/imx6dl-b155v2.dts b/arch/arm/boot/dts/nxp/imx/imx6dl-b155v2.dts
> index 7edc788bcb8f3..dd7b892cf0722 100644
> --- a/arch/arm/boot/dts/nxp/imx/imx6dl-b155v2.dts
> +++ b/arch/arm/boot/dts/nxp/imx/imx6dl-b155v2.dts
> @@ -25,6 +25,8 @@ touchscreen@2a {
>  		pinctrl-0 = <&pinctrl_q7_gpio0>;
>  		interrupt-parent = <&gpio5>;
>  		interrupts = <2 IRQ_TYPE_LEVEL_LOW>;
> +		touchscreen-size-x = <16384>;
> +		touchscreen-size-y = <16384>;
>  		touchscreen-inverted-x;
>  		touchscreen-inverted-y;
>  		reset-gpios = <&tca6424a 21 GPIO_ACTIVE_HIGH>;

[Severity: Medium]
The commit message states that these properties are added "matching the
1366x768 resolution of the AUO G156XTN01 panel", but the touchscreen@2a node in
arch/arm/boot/dts/nxp/imx/imx6dl-b155v2.dts sets both touchscreen-size-x and
touchscreen-size-y to 16384.

In drivers/input/touchscreen/exc3000.c, exc3000_info defines the native
coordinate range for EETI_EXC80H84 as 16K:

drivers/input/touchscreen/exc3000.c:exc3000_info[] = {
	...
	[EETI_EXC80H84] = {
		.name = "EETI EXC80H84 Touch Screen",
		.max_xy = SZ_16K - 1,
	},
	...
};

Should the commit message be updated to reflect that the properties are set to
16384 to match the EXC80H84 controller's 16K coordinate range rather than the
1366x768 panel resolution?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261019-arm_dts_cleanup2-v2-0-dcdcbe6389c1@nxp.com?part=3