Re: [PATCH 3/3] hwmon: (fs1603) Add driver for TDK FS160x and FS1006 uPOL converters

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] hwmon: (fs1603) positional initializers in struct i2c_device_id fs1603_id
--

commit d32400df72d7884af500586426d84640110c0f0e
Author: Kevin Jia <kjia@nexthop.ai>

hwmon: (fs1603) Add driver for TDK FS160x and FS1006 uPOL converters

This commit adds a read-only hwmon driver for the TDK FS1603, FS1604,
FS1606, and FS1006 uPOL DC-DC converters, reporting input and output
voltages, output current, temperature, and protection thresholds over a
proprietary I2C register map.

> diff --git a/drivers/hwmon/fs1603.c b/drivers/hwmon/fs1603.c
> new file mode 100644
> index 0000000000000..ae22964d22b2c
> --- /dev/null
> +++ b/drivers/hwmon/fs1603.c
> @@ -0,0 +1,480 @@

[ ... ]

> +static const struct i2c_device_id fs1603_id[] = {
> +	{ "fs1603", (kernel_ulong_t)&fs1603_models[fs1603] },
> +	{ "fs1604", (kernel_ulong_t)&fs1603_models[fs1604] },
> +	{ "fs1606", (kernel_ulong_t)&fs1603_models[fs1606] },
> +	{ "fs1606_0600", (kernel_ulong_t)&fs1603_models[fs1606_0600] },
> +	{ "fs1606_2500", (kernel_ulong_t)&fs1603_models[fs1606_2500] },
> +	{ "fs1006_5000", (kernel_ulong_t)&fs1603_models[fs1006] },
> +	{ "fs1006_3300", (kernel_ulong_t)&fs1603_models[fs1006] },
> +	{}
> +};
> +MODULE_DEVICE_TABLE(i2c, fs1603_id);

[Severity: Low]
This isn't a bug, but should the entries in fs1603_id[] in
drivers/hwmon/fs1603.c use named initializers (.name and .driver_data)
rather than positional initializers, matching the convention for new
struct i2c_device_id tables and the style used in fs1603_of_match[] right
below?

[ ... ]

────
Touestas, feedback, or questions about this review? Email
linux-kernel-bot@google.com.
────

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261019-fs1603-v1-0-8adf972386c1@nexthop.ai?part=3