From: sashiko-bot@kernel.org
To: "Prashant Sengar" <prashantsengar25031@gmail.com>
Cc: linux-usb@vger.kernel.org
Subject: Re: [PATCH net v2] net: usb: lan78xx: avoid NULL PHY dereference in WoL setup
Date: Mon, 19 Oct 2026 19:43:20 +0000 [thread overview]
Message-ID: <sashiko-outbox-178149@kernel.org> (raw)
In-Reply-To: <20261019193148.1381545-1-prashantsengar25031@gmail.com>
> LAN7801 supports fixed-link configurations without an attached PHY.
> However, lan78xx_set_wol() unconditionally passes netdev->phydev
> to phy_ethtool_set_wol(), causing a NULL pointer dereference when
> a userspace WoL request reaches this path.
>
> Use phylink_expects_phy() to skip PHY WoL configuration for fixed
> links, and use phylink_ethtool_set_wol() for configurations that
> expect a PHY. This avoids the NULL dereference while keeping PHY
> operations within the phylink API.
>
> The issue was reproduced using USB Raw Gadget and dummy_hcd in QEMU.
> An ETHTOOL_SWOL ioctl triggered a kernel Oops with the original
> driver. With this change, the same request completes successfully.
>
> Fixes: e110bc825897 ("net: usb: lan78xx: Convert to PHYLINK for improved PHY and MAC management")
> Signed-off-by: Prashant Sengar <prashantsengar25031@gmail.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261019193148.1381545-1-prashantsengar25031@gmail.com?part=1
next prev parent reply other threads:[~2026-10-19 19:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-19 19:31 [PATCH net v2] net: usb: lan78xx: avoid NULL PHY dereference in WoL setup Prashant Sengar
2026-10-19 19:39 ` netdev-bot+sinfo
2026-10-19 19:43 ` sashiko-bot [this message]
2026-10-19 21:24 ` Andrew Lunn
2026-10-20 7:05 ` Prashant Sengar
2026-10-20 12:17 ` Andrew Lunn
[not found] ` <CABW1sB=n--dJDK2zieM1bzOjG3AEwfZLTZ6HJrXLG+F1R1LB1A@mail.gmail.com>
2026-10-20 14:02 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-178149@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=prashantsengar25031@gmail.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.