From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 51F75606A319 for ; Tue, 20 Oct 2026 08:36:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=YJ5EK4/d Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AD7BB10EB8D; Tue, 20 Oct 2026 08:36:39 +0000 (UTC) Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2DA6010EB9B for ; Tue, 20 Oct 2026 08:35:48 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 4F1A660DB0; Tue, 20 Oct 2026 08:35:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 992151F000CC; Tue, 20 Oct 2026 08:35:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1792485347; bh=crQcIFFBAX4Hpvb1vY/ep2aby/VU13YvjlGE1CBkL4I=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=YJ5EK4/d+RC+HFhf04s1RILOqB+fHmoq+VEcRZKAhcQaP+PWzCMXjG10rWZ5Lq/Mh Msp/wca+lPSHb006XfpNizr4pSQybPKf7DCvwS1yreyVZ4mCnaS3g0DS7+BYCxMAO+ fxzj5MphIaO0sLMPPC63IlfmoxkffiXRSOKJ/U17eGFOyqA91XLlnwQgix9NFz1rEi sFrBUy2aisBzzfJe6AB41Q3lmexeTzRId/wZzbjewnouZjxuIoq7v3OnT3X5PsZBGW MFx9/A7nP+XGJlemrJAX2Fv4qJWGhWyBz3TZ2s4qwEEF0wXpSYMA0FRR1Zb+6sfpp7 yJSYqqzfZ9Aag== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v8 4/7] drm/bridge: aux: Add drm_aux_bridge_register_from_node() To: "Chaoyi Chen" Cc: dri-devel@lists.freedesktop.org, linux-phy@lists.infradead.org, vkoul@kernel.org, neil.armstrong@linaro.org, olteanv@gmail.com In-Reply-To: <20261020072816.180-5-kernel@airkyi.com> References: <20261020072816.180-1-kernel@airkyi.com> <20261020072816.180-5-kernel@airkyi.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 20 Oct 2026 08:35:46 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev Sender: "dri-devel" X-Spam-Status: No, score=-11.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 X-Archived-By: Thank you for your contribution! Sashiko AI review found 2 potential issue(= s) to consider: - [High] drm/bridge: aux: missing of_node_get() in drm_aux_bridge_register_= from_node() - [High] drm/bridge: aux: improper OF node setup in drm_aux_bridge_register= _from_node() -- commit 36532c7bf6a02e3a0e3f70873a369995bccbc3c6 Author: Chaoyi Chen drm/bridge: aux: Add drm_aux_bridge_register_from_node() This commit adds drm_aux_bridge_register_from_node() so callers can specify= an explicit device_node for the auxiliary bridge instead of always using the parent device's of_node. > diff --git a/drivers/gpu/drm/bridge/aux-bridge.c b/drivers/gpu/drm/bridge= /aux-bridge.c > index 90f76bb529cc2..f1adcdece7b95 100644 > --- a/drivers/gpu/drm/bridge/aux-bridge.c > +++ b/drivers/gpu/drm/bridge/aux-bridge.c > @@ -35,8 +35,9 @@ static void drm_aux_bridge_unregister_adev(void *_adev) > } > =20 > /** > - * drm_aux_bridge_register - Create a simple bridge device to link the c= hain > + * drm_aux_bridge_register_from_node - Create a simple bridge device to = link the chain > * @parent: device instance providing this bridge > + * @np: device node pointer corresponding to this bridge instance > * > * Creates a simple DRM bridge that doesn't implement any drm_bridge > * operations. Such bridges merely fill a place in the bridge chain link= ing > @@ -44,7 +45,7 @@ static void drm_aux_bridge_unregister_adev(void *_adev) > * > * Return: zero on success, negative error code on failure > */ > -int drm_aux_bridge_register(struct device *parent) > +int drm_aux_bridge_register_from_node(struct device *parent, struct devi= ce_node *np) > { > struct auxiliary_device *adev; > int ret; > @@ -64,7 +65,10 @@ int drm_aux_bridge_register(struct device *parent) > adev->dev.parent =3D parent; > adev->dev.release =3D drm_aux_bridge_release; > =20 > - device_set_of_node_from_dev(&adev->dev, parent); > + if (np) > + device_set_node(&adev->dev, of_fwnode_handle(np)); > + else > + device_set_of_node_from_dev(&adev->dev, parent); [Severity: High] Does calling device_set_node() when np is non-NULL underflow the OF node reference count on cleanup? In drivers/base/core.c, device_set_of_node_from_dev() increments the refere= nce count via of_node_get() and marks the node as reused, whereas device_set_node() only assigns the pointers: drivers/base/core.c: void device_set_of_node_from_dev(struct device *dev, const struct device *d= ev2) { of_node_put(dev->of_node); dev->of_node =3D of_node_get(dev2->of_node); dev_set_of_node_reused(dev); } void device_set_node(struct device *dev, struct fwnode_handle *fwnode) { dev->fwnode =3D fwnode; dev->of_node =3D to_of_node(fwnode); } However, both the auxiliary_device_init() failure path in drm_aux_bridge_register_from_node() and the device release callback drm_aux_bridge_release() (reached if auxiliary_device_add() fails via auxiliary_device_uninit() -> put_device(), or when the parent unbinds via drm_aux_bridge_unregister_adev()) unconditionally drop a reference on dev->of_node: drivers/gpu/drm/bridge/aux-bridge.c:drm_aux_bridge_release() { struct auxiliary_device *adev =3D to_auxiliary_dev(dev); of_node_put(dev->of_node); ida_free(&drm_aux_bridge_ida, adev->id); kfree(adev); } When a caller such as rockchip_typec_phy_probe() passes a child node via for_each_available_child_of_node(np, child_np) without taking an extra reference for the bridge, won't this drop a reference that drm_aux_bridge_register_from_node() never acquired? [Severity: High] Also, is device_set_node() appropriate here when np is shared with a parent= or subnode device (such as the dp-port PHY subnode in phy-rockchip-typec)? Unlike device_set_of_node_from_dev(), device_set_node() sets adev->dev.fwno= de and leaves DEV_FLAG_OF_NODE_REUSED unset on &adev->dev. Because adev->dev.fwnode is set and the node is not marked reused: 1. device_add() assigns np->fwnode.dev =3D &adev->dev, so fw_devlink treats= the aux_bridge auxiliary device as the supplier for np. If np is a PHY subno= de without an OF graph port (for example, tcphy0_dp / tcphy1_dp referenced = via phys =3D <&tcphy0_dp>), drm_aux_bridge_probe() returns -ENODEV and leave= s the auxiliary device unbound, which can cause consumers like cdn_dp to defer probe indefinitely with -EPROBE_DEFER. 2. really_probe() -> pinctrl_bind_pins() only skips pin binding when of_node_is_reused() is true, which can conflict if np carries pinctrl properties. Should the non-NULL np path instead set adev->dev.of_node =3D of_node_get(n= p) and call dev_set_of_node_reused(&adev->dev) to match device_set_of_node_from_dev()? [ ... ] > ret =3D auxiliary_device_init(adev); > if (ret) { [ ... ] --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261020072816.180-= 1-kernel@airkyi.com?part=3D4 From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0DDE7606A322 for ; Tue, 20 Oct 2026 08:35:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=1cXouzFi; dkim=fail reason="signature verification failed" (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=YJ5EK4/d DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Date:References: In-Reply-To:Cc:To:Subject:From:Message-ID:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zZqXVLMMscxcVHBQ4qG8fzIKJpXv7IXyfdnEt0VyBi8=; b=1cXouzFi6l/RfR XJYFoxOs9TE8//SCraiT/tp/2vODhxfY82/04UiodK/yefK1SEJG4z9jMAFx+7skn7YmoD3VvEoD3 0YLcPQswXfTiob+s/ER5jdpEu0X3/xyJrAtUqxEgivsXKqUiOiMNIF3agRJRQwO9R8dQfdm8we+j+ KorcbD8wJw10mWlGjhiTsV6KZPfkwmMMlhvuBvp6aFQGIg8zkvRLSpdqCOWRnaNJAQ+KeNvdmM2js CzIgdR/dn0bvwfA1DoFS9hdgS71xtWS4kWgrgMj0v3JAYIdtmyWzzlpEcuomaAkrT18TF7PMuJ1O8 FDXyPBfXuI55jACbiSxA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xJ5K0-00000009CMw-2gfW; Tue, 20 Oct 2026 08:35:48 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xJ5K0-00000009CMn-0tyw for linux-phy@lists.infradead.org; Tue, 20 Oct 2026 08:35:48 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 4F1A660DB0; Tue, 20 Oct 2026 08:35:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 992151F000CC; Tue, 20 Oct 2026 08:35:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1792485347; bh=crQcIFFBAX4Hpvb1vY/ep2aby/VU13YvjlGE1CBkL4I=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=YJ5EK4/d+RC+HFhf04s1RILOqB+fHmoq+VEcRZKAhcQaP+PWzCMXjG10rWZ5Lq/Mh Msp/wca+lPSHb006XfpNizr4pSQybPKf7DCvwS1yreyVZ4mCnaS3g0DS7+BYCxMAO+ fxzj5MphIaO0sLMPPC63IlfmoxkffiXRSOKJ/U17eGFOyqA91XLlnwQgix9NFz1rEi sFrBUy2aisBzzfJe6AB41Q3lmexeTzRId/wZzbjewnouZjxuIoq7v3OnT3X5PsZBGW MFx9/A7nP+XGJlemrJAX2Fv4qJWGhWyBz3TZ2s4qwEEF0wXpSYMA0FRR1Zb+6sfpp7 yJSYqqzfZ9Aag== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v8 4/7] drm/bridge: aux: Add drm_aux_bridge_register_from_node() To: "Chaoyi Chen" Cc: dri-devel@lists.freedesktop.org, linux-phy@lists.infradead.org, vkoul@kernel.org, neil.armstrong@linaro.org, olteanv@gmail.com In-Reply-To: <20261020072816.180-5-kernel@airkyi.com> References: <20261020072816.180-1-kernel@airkyi.com> <20261020072816.180-5-kernel@airkyi.com> Date: Tue, 20 Oct 2026 08:35:46 +0000 X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" X-Spam-Status: No, score=-9.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MiBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW0hpZ2hdIGRybS9icmlkZ2U6IGF1 eDogbWlzc2luZyBvZl9ub2RlX2dldCgpIGluIGRybV9hdXhfYnJpZGdlX3JlZ2lzdGVyX2Zyb21f bm9kZSgpCi0gW0hpZ2hdIGRybS9icmlkZ2U6IGF1eDogaW1wcm9wZXIgT0Ygbm9kZSBzZXR1cCBp biBkcm1fYXV4X2JyaWRnZV9yZWdpc3Rlcl9mcm9tX25vZGUoKQotLQoKY29tbWl0IDM2NTMyYzdi ZjZhMDJlM2EwZTNmNzA4NzNhMzY5OTk1YmNjYmMzYzYKQXV0aG9yOiBDaGFveWkgQ2hlbiA8Y2hh b3lpLmNoZW5Acm9jay1jaGlwcy5jb20+Cgpkcm0vYnJpZGdlOiBhdXg6IEFkZCBkcm1fYXV4X2Jy aWRnZV9yZWdpc3Rlcl9mcm9tX25vZGUoKQoKVGhpcyBjb21taXQgYWRkcyBkcm1fYXV4X2JyaWRn ZV9yZWdpc3Rlcl9mcm9tX25vZGUoKSBzbyBjYWxsZXJzIGNhbiBzcGVjaWZ5IGFuCmV4cGxpY2l0 IGRldmljZV9ub2RlIGZvciB0aGUgYXV4aWxpYXJ5IGJyaWRnZSBpbnN0ZWFkIG9mIGFsd2F5cyB1 c2luZyB0aGUKcGFyZW50IGRldmljZSdzIG9mX25vZGUuCgo+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vYnJpZGdlL2F1eC1icmlkZ2UuYyBiL2RyaXZlcnMvZ3B1L2RybS9icmlkZ2UvYXV4 LWJyaWRnZS5jCj4gaW5kZXggOTBmNzZiYjUyOWNjMi4uZjFhZGNkZWNlN2I5NSAxMDA2NDQKPiAt LS0gYS9kcml2ZXJzL2dwdS9kcm0vYnJpZGdlL2F1eC1icmlkZ2UuYwo+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS9icmlkZ2UvYXV4LWJyaWRnZS5jCj4gQEAgLTM1LDggKzM1LDkgQEAgc3RhdGljIHZv aWQgZHJtX2F1eF9icmlkZ2VfdW5yZWdpc3Rlcl9hZGV2KHZvaWQgKl9hZGV2KQo+ICB9Cj4gIAo+ ICAvKioKPiAtICogZHJtX2F1eF9icmlkZ2VfcmVnaXN0ZXIgLSBDcmVhdGUgYSBzaW1wbGUgYnJp ZGdlIGRldmljZSB0byBsaW5rIHRoZSBjaGFpbgo+ICsgKiBkcm1fYXV4X2JyaWRnZV9yZWdpc3Rl cl9mcm9tX25vZGUgLSBDcmVhdGUgYSBzaW1wbGUgYnJpZGdlIGRldmljZSB0byBsaW5rIHRoZSBj aGFpbgo+ICAgKiBAcGFyZW50OiBkZXZpY2UgaW5zdGFuY2UgcHJvdmlkaW5nIHRoaXMgYnJpZGdl Cj4gKyAqIEBucDogZGV2aWNlIG5vZGUgcG9pbnRlciBjb3JyZXNwb25kaW5nIHRvIHRoaXMgYnJp ZGdlIGluc3RhbmNlCj4gICAqCj4gICAqIENyZWF0ZXMgYSBzaW1wbGUgRFJNIGJyaWRnZSB0aGF0 IGRvZXNuJ3QgaW1wbGVtZW50IGFueSBkcm1fYnJpZGdlCj4gICAqIG9wZXJhdGlvbnMuIFN1Y2gg YnJpZGdlcyBtZXJlbHkgZmlsbCBhIHBsYWNlIGluIHRoZSBicmlkZ2UgY2hhaW4gbGlua2luZwo+ IEBAIC00NCw3ICs0NSw3IEBAIHN0YXRpYyB2b2lkIGRybV9hdXhfYnJpZGdlX3VucmVnaXN0ZXJf YWRldih2b2lkICpfYWRldikKPiAgICoKPiAgICogUmV0dXJuOiB6ZXJvIG9uIHN1Y2Nlc3MsIG5l Z2F0aXZlIGVycm9yIGNvZGUgb24gZmFpbHVyZQo+ICAgKi8KPiAtaW50IGRybV9hdXhfYnJpZGdl X3JlZ2lzdGVyKHN0cnVjdCBkZXZpY2UgKnBhcmVudCkKPiAraW50IGRybV9hdXhfYnJpZGdlX3Jl Z2lzdGVyX2Zyb21fbm9kZShzdHJ1Y3QgZGV2aWNlICpwYXJlbnQsIHN0cnVjdCBkZXZpY2Vfbm9k ZSAqbnApCj4gIHsKPiAgCXN0cnVjdCBhdXhpbGlhcnlfZGV2aWNlICphZGV2Owo+ICAJaW50IHJl dDsKPiBAQCAtNjQsNyArNjUsMTAgQEAgaW50IGRybV9hdXhfYnJpZGdlX3JlZ2lzdGVyKHN0cnVj dCBkZXZpY2UgKnBhcmVudCkKPiAgCWFkZXYtPmRldi5wYXJlbnQgPSBwYXJlbnQ7Cj4gIAlhZGV2 LT5kZXYucmVsZWFzZSA9IGRybV9hdXhfYnJpZGdlX3JlbGVhc2U7Cj4gIAo+IC0JZGV2aWNlX3Nl dF9vZl9ub2RlX2Zyb21fZGV2KCZhZGV2LT5kZXYsIHBhcmVudCk7Cj4gKwlpZiAobnApCj4gKwkJ ZGV2aWNlX3NldF9ub2RlKCZhZGV2LT5kZXYsIG9mX2Z3bm9kZV9oYW5kbGUobnApKTsKPiArCWVs c2UKPiArCQlkZXZpY2Vfc2V0X29mX25vZGVfZnJvbV9kZXYoJmFkZXYtPmRldiwgcGFyZW50KTsK CltTZXZlcml0eTogSGlnaF0KRG9lcyBjYWxsaW5nIGRldmljZV9zZXRfbm9kZSgpIHdoZW4gbnAg aXMgbm9uLU5VTEwgdW5kZXJmbG93IHRoZSBPRiBub2RlCnJlZmVyZW5jZSBjb3VudCBvbiBjbGVh bnVwPwoKSW4gZHJpdmVycy9iYXNlL2NvcmUuYywgZGV2aWNlX3NldF9vZl9ub2RlX2Zyb21fZGV2 KCkgaW5jcmVtZW50cyB0aGUgcmVmZXJlbmNlCmNvdW50IHZpYSBvZl9ub2RlX2dldCgpIGFuZCBt YXJrcyB0aGUgbm9kZSBhcyByZXVzZWQsIHdoZXJlYXMKZGV2aWNlX3NldF9ub2RlKCkgb25seSBh c3NpZ25zIHRoZSBwb2ludGVyczoKCmRyaXZlcnMvYmFzZS9jb3JlLmM6CnZvaWQgZGV2aWNlX3Nl dF9vZl9ub2RlX2Zyb21fZGV2KHN0cnVjdCBkZXZpY2UgKmRldiwgY29uc3Qgc3RydWN0IGRldmlj ZSAqZGV2MikKewoJb2Zfbm9kZV9wdXQoZGV2LT5vZl9ub2RlKTsKCWRldi0+b2Zfbm9kZSA9IG9m X25vZGVfZ2V0KGRldjItPm9mX25vZGUpOwoJZGV2X3NldF9vZl9ub2RlX3JldXNlZChkZXYpOwp9 Cgp2b2lkIGRldmljZV9zZXRfbm9kZShzdHJ1Y3QgZGV2aWNlICpkZXYsIHN0cnVjdCBmd25vZGVf aGFuZGxlICpmd25vZGUpCnsKCWRldi0+Zndub2RlID0gZndub2RlOwoJZGV2LT5vZl9ub2RlID0g dG9fb2Zfbm9kZShmd25vZGUpOwp9CgpIb3dldmVyLCBib3RoIHRoZSBhdXhpbGlhcnlfZGV2aWNl X2luaXQoKSBmYWlsdXJlIHBhdGggaW4KZHJtX2F1eF9icmlkZ2VfcmVnaXN0ZXJfZnJvbV9ub2Rl KCkgYW5kIHRoZSBkZXZpY2UgcmVsZWFzZSBjYWxsYmFjawpkcm1fYXV4X2JyaWRnZV9yZWxlYXNl KCkgKHJlYWNoZWQgaWYgYXV4aWxpYXJ5X2RldmljZV9hZGQoKSBmYWlscyB2aWEKYXV4aWxpYXJ5 X2RldmljZV91bmluaXQoKSAtPiBwdXRfZGV2aWNlKCksIG9yIHdoZW4gdGhlIHBhcmVudCB1bmJp bmRzIHZpYQpkcm1fYXV4X2JyaWRnZV91bnJlZ2lzdGVyX2FkZXYoKSkgdW5jb25kaXRpb25hbGx5 IGRyb3AgYSByZWZlcmVuY2Ugb24KZGV2LT5vZl9ub2RlOgoKZHJpdmVycy9ncHUvZHJtL2JyaWRn ZS9hdXgtYnJpZGdlLmM6ZHJtX2F1eF9icmlkZ2VfcmVsZWFzZSgpIHsKCXN0cnVjdCBhdXhpbGlh cnlfZGV2aWNlICphZGV2ID0gdG9fYXV4aWxpYXJ5X2RldihkZXYpOwoKCW9mX25vZGVfcHV0KGRl di0+b2Zfbm9kZSk7CglpZGFfZnJlZSgmZHJtX2F1eF9icmlkZ2VfaWRhLCBhZGV2LT5pZCk7CgoJ a2ZyZWUoYWRldik7Cn0KCldoZW4gYSBjYWxsZXIgc3VjaCBhcyByb2NrY2hpcF90eXBlY19waHlf cHJvYmUoKSBwYXNzZXMgYSBjaGlsZCBub2RlIHZpYQpmb3JfZWFjaF9hdmFpbGFibGVfY2hpbGRf b2Zfbm9kZShucCwgY2hpbGRfbnApIHdpdGhvdXQgdGFraW5nIGFuIGV4dHJhCnJlZmVyZW5jZSBm b3IgdGhlIGJyaWRnZSwgd29uJ3QgdGhpcyBkcm9wIGEgcmVmZXJlbmNlIHRoYXQKZHJtX2F1eF9i cmlkZ2VfcmVnaXN0ZXJfZnJvbV9ub2RlKCkgbmV2ZXIgYWNxdWlyZWQ/CgpbU2V2ZXJpdHk6IEhp Z2hdCkFsc28sIGlzIGRldmljZV9zZXRfbm9kZSgpIGFwcHJvcHJpYXRlIGhlcmUgd2hlbiBucCBp cyBzaGFyZWQgd2l0aCBhIHBhcmVudCBvcgpzdWJub2RlIGRldmljZSAoc3VjaCBhcyB0aGUgZHAt cG9ydCBQSFkgc3Vibm9kZSBpbiBwaHktcm9ja2NoaXAtdHlwZWMpPwoKVW5saWtlIGRldmljZV9z ZXRfb2Zfbm9kZV9mcm9tX2RldigpLCBkZXZpY2Vfc2V0X25vZGUoKSBzZXRzIGFkZXYtPmRldi5m d25vZGUKYW5kIGxlYXZlcyBERVZfRkxBR19PRl9OT0RFX1JFVVNFRCB1bnNldCBvbiAmYWRldi0+ ZGV2LgoKQmVjYXVzZSBhZGV2LT5kZXYuZndub2RlIGlzIHNldCBhbmQgdGhlIG5vZGUgaXMgbm90 IG1hcmtlZCByZXVzZWQ6CjEuIGRldmljZV9hZGQoKSBhc3NpZ25zIG5wLT5md25vZGUuZGV2ID0g JmFkZXYtPmRldiwgc28gZndfZGV2bGluayB0cmVhdHMgdGhlCiAgIGF1eF9icmlkZ2UgYXV4aWxp YXJ5IGRldmljZSBhcyB0aGUgc3VwcGxpZXIgZm9yIG5wLiBJZiBucCBpcyBhIFBIWSBzdWJub2Rl CiAgIHdpdGhvdXQgYW4gT0YgZ3JhcGggcG9ydCAoZm9yIGV4YW1wbGUsIHRjcGh5MF9kcCAvIHRj cGh5MV9kcCByZWZlcmVuY2VkIHZpYQogICBwaHlzID0gPCZ0Y3BoeTBfZHA+KSwgZHJtX2F1eF9i cmlkZ2VfcHJvYmUoKSByZXR1cm5zIC1FTk9ERVYgYW5kIGxlYXZlcyB0aGUKICAgYXV4aWxpYXJ5 IGRldmljZSB1bmJvdW5kLCB3aGljaCBjYW4gY2F1c2UgY29uc3VtZXJzIGxpa2UgY2RuX2RwIHRv IGRlZmVyCiAgIHByb2JlIGluZGVmaW5pdGVseSB3aXRoIC1FUFJPQkVfREVGRVIuCjIuIHJlYWxs eV9wcm9iZSgpIC0+IHBpbmN0cmxfYmluZF9waW5zKCkgb25seSBza2lwcyBwaW4gYmluZGluZyB3 aGVuCiAgIG9mX25vZGVfaXNfcmV1c2VkKCkgaXMgdHJ1ZSwgd2hpY2ggY2FuIGNvbmZsaWN0IGlm IG5wIGNhcnJpZXMgcGluY3RybAogICBwcm9wZXJ0aWVzLgoKU2hvdWxkIHRoZSBub24tTlVMTCBu cCBwYXRoIGluc3RlYWQgc2V0IGFkZXYtPmRldi5vZl9ub2RlID0gb2Zfbm9kZV9nZXQobnApCmFu ZCBjYWxsIGRldl9zZXRfb2Zfbm9kZV9yZXVzZWQoJmFkZXYtPmRldikgdG8gbWF0Y2gKZGV2aWNl X3NldF9vZl9ub2RlX2Zyb21fZGV2KCk/CgpbIC4uLiBdCgo+ICAJcmV0ID0gYXV4aWxpYXJ5X2Rl dmljZV9pbml0KGFkZXYpOwo+ICAJaWYgKHJldCkgewoKWyAuLi4gXQoKLS0gClNhc2hpa28gQUkg cmV2aWV3IMK3IGh0dHBzOi8vc2FzaGlrby5kZXYvIy9wYXRjaHNldC8yMDI2MTAyMDA3MjgxNi4x ODAtMS1rZXJuZWxAYWlya3lpLmNvbT9wYXJ0PTQKCi0tIApsaW51eC1waHkgbWFpbGluZyBsaXN0 CmxpbnV4LXBoeUBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHBzOi8vbGlzdHMuaW5mcmFkZWFkLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXBoeQo=