Re: [PATCH v3 6/7] drm/xe/kunit: Test partitioned VRAM manager

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] drm/xe/kunit: xe_ttm_vram_mgr test included in xe.ko when modular
--

commit 5fbb2803b441b2f0a8dc39a38c6ece7e9b2329ff
Author: Piotr Piórkowski <piotr.piorkowski@intel.com>

drm/xe/kunit: Test partitioned VRAM manager

This commit adds KUnit tests for the partitioned VRAM manager to exercise
partition selection, address lookup, pool usage, and CPU-visible memory
accounting across partitions.

> diff --git a/drivers/gpu/drm/xe/tests/xe_ttm_vram_mgr.c b/drivers/gpu/drm/xe/tests/xe_ttm_vram_mgr.c
> new file mode 100644
> index 0000000000000..1ad3186e6d5be
> --- /dev/null
> +++ b/drivers/gpu/drm/xe/tests/xe_ttm_vram_mgr.c
> @@ -0,0 +1,147 @@

[ ... ]

> +static struct kunit_suite xe_ttm_vram_mgr_test_suite = {
> +	.name = "xe_ttm_vram_mgr",
> +	.test_cases = xe_ttm_vram_mgr_tests,
> +};
> +
> +kunit_test_suite(xe_ttm_vram_mgr_test_suite);
> diff --git a/drivers/gpu/drm/xe/xe_ttm_vram_mgr.c b/drivers/gpu/drm/xe/xe_ttm_vram_mgr.c
> index 83baeec2ef9b1..509f2e2345553 100644
> --- a/drivers/gpu/drm/xe/xe_ttm_vram_mgr.c
> +++ b/drivers/gpu/drm/xe/xe_ttm_vram_mgr.c
> @@ -1303,3 +1303,7 @@ void xe_ttm_vram_debugfs_init(struct xe_device *xe, struct dentry *root)
>  		return;
>  	debugfs_create_file("vram_bad_pages", 0444, root, xe, &vram_bad_pages_fops);
>  }
> +
> +#if IS_ENABLED(CONFIG_DRM_XE_KUNIT_TEST)
> +#include "tests/xe_ttm_vram_mgr.c"
> +#endif

[Severity: Medium]
Should this guard use IS_BUILTIN(CONFIG_DRM_XE_KUNIT_TEST) instead of
IS_ENABLED(CONFIG_DRM_XE_KUNIT_TEST) (or export the suite to xe_test.ko via
EXPORT_SYMBOL_IF_KUNIT)?

Because CONFIG_DRM_XE_KUNIT_TEST is tristate and tests/xe_ttm_vram_mgr.c
registers xe_ttm_vram_mgr_test_suite via kunit_test_suite(), building with
CONFIG_DRM_XE_KUNIT_TEST=m links the suite into the .kunit_test_suites
section of the core xe driver (xe.ko or vmlinux) rather than a test module.

When xe.ko is loaded (or during boot when built-in),
kunit_module_notify()->kunit_module_init()->kunit_run_tests() will
immediately run xe_ttm_vram_mgr_test_suite and taint the kernel with
TAINT_TEST even when no test module is loaded.

Other inlined unit tests in drivers/gpu/drm/xe/ that use kunit_test_suite()
(such as xe_lmtt.c, xe_log.c, and xe_guc_id_mgr.c) guard the #include with
#if IS_BUILTIN(CONFIG_DRM_XE_KUNIT_TEST).

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261020084258.443645-1-piotr.piorkowski@intel.com?part=6