From: sashiko-bot@kernel.org
To: "Niklas Cassel" <cassel@kernel.org>
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH v2 3/3] PCI: meson: Remove redundant MPS configuration
Date: Tue, 20 Oct 2026 12:36:28 +0000 [thread overview]
Message-ID: <sashiko-outbox-178952@kernel.org> (raw)
In-Reply-To: <20261020122854.1500883-8-cassel@kernel.org>
> From: Hans Zhang <18255117159@163.com>
>
> The Meson PCIe controller driver manually configures maximum payload
> size (MPS) through meson_set_max_payload, duplicating functionality now
> centralized in the PCI core. Deprecating redundant code simplifies the
> driver and aligns it with the consolidated MPS management strategy,
> improving long-term maintainability.
>
> With meson_set_max_payload() gone, meson_size_to_payload() is only used
> for MRRS. Rename it to meson_size_to_mrrs(), update its comment and
> warning message, and drop the now-unused PCIE_CAP_MAX_PAYLOAD_SIZE and
> MAX_PAYLOAD_SIZE macros.
>
> Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
> Signed-off-by: Hans Zhang <18255117159@163.com>
> Signed-off-by: Niklas Cassel <cassel@kernel.org>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261020122854.1500883-5-cassel@kernel.org?part=3
prev parent reply other threads:[~2026-10-20 12:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-20 12:28 [PATCH v2 0/3] PCI: Fix and improve default MPS configuration Niklas Cassel
2026-10-20 12:28 ` Niklas Cassel
2026-10-20 12:28 ` Niklas Cassel
2026-10-20 12:28 ` [PATCH v2 1/3] PCI: Match the hierarchy's MPS to a device's MPSS as necessary Niklas Cassel
2026-10-20 12:28 ` Niklas Cassel
2026-10-20 12:28 ` Niklas Cassel
2026-10-20 12:44 ` sashiko-bot
2026-10-20 12:28 ` [PATCH v2 2/3] PCI: Configure Root Port MPS after scanning its hierarchy Niklas Cassel
2026-10-20 12:28 ` Niklas Cassel
2026-10-20 12:28 ` Niklas Cassel
2026-10-20 13:10 ` sashiko-bot
2026-10-20 12:28 ` [PATCH v2 3/3] PCI: meson: Remove redundant MPS configuration Niklas Cassel
2026-10-20 12:28 ` Niklas Cassel
2026-10-20 12:28 ` Niklas Cassel
2026-10-20 12:36 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-178952@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=cassel@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.